Subject: Re: MultiXact\SLRU buffers configuration
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
 Daniel Gustafsson <daniel@yesql.se>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <a7f1c4e1-1015-92a4-2bd4-6736bd13d03e@postgrespro.ru>
 <CAPpHfduekT=BrM3rLqvo4ajzKYmDk+6aCoYJrNHhK0Je+v2z=Q@mail.gmail.com>
 <8A94938B-054C-4439-9866-2C220B4D0DD7@yandex-team.ru>
 <CAPpHfduT0Kb+8fMt4t0EF5G_3hig+wYgeRadQnNq20F4VxP7LA@mail.gmail.com>
 <CAPpHfdsUtSGxRrKn65F_wrE66sNztNY4TpDGDHh2kvAZZDOMqA@mail.gmail.com>
 <20201028013651.de5cj2xadgmba5nf@development>
 <13D8FD63-559A-4737-B7FD-05288D1CEF8B@yandex-team.ru>
 <20201028233243.ygm6yqlynkqpzekr@development>
 <43F3DE92-F236-4EA5-B4D6-39BEF6BD849D@yandex-team.ru>
 <20201029134933.xd4mh2cofuf6tdfz@development>
 <65C1B4BA-D16F-4939-978B-AC8F370F5A5E@yandex-team.ru>
 <9b4d17df-b811-8323-16be-3cab913216d1@enterprisedb.com>
 <A64B924A-B08E-417D-BD3D-D396D722053B@yandex-team.ru>
 <35862787-8b4d-a290-789e-6e12dc6527e8@enterprisedb.com>
 <13F86913-C01B-4983-AE2E-493F5A028280@yandex-team.ru>
 <6ba7eae2-8b0c-0690-11a5-e921e6586180@darold.net>
 <3F5E23A3-6250-486E-9CCA-E2A5B6A28B4F@yandex-team.ru>
From: Gilles Darold <gilles@darold.net>
Message-ID: <3a092075-b4f9-a983-8438-95a8d964a81c@darold.net>
Date: Wed, 9 Dec 2020 11:51:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <3F5E23A3-6250-486E-9CCA-E2A5B6A28B4F@yandex-team.ru>
Content-Type: multipart/alternative;
 boundary="------------0FBDDFB29502FA76DE6B21A1"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------0FBDDFB29502FA76DE6B21A1
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrey,

Thanks for the backport. I have issue with the first patch "Use shared 
lock in GetMultiXactIdMembers for offsets and members" 
(v1106-0001-Use-shared-lock-in-GetMultiXactIdMembers-for-o.patch) the 
applications are not working anymore when I'm applying it. Also PG 
regression tests are failing too on several part.


    test insert_conflict              ... ok
    test create_function_1            ... FAILED
    test create_type                  ... FAILED
    test create_table                 ... FAILED
    test create_function_2            ... FAILED
    test copy                         ... FAILED
    test copyselect                   ... ok
    test copydml                      ... ok
    test create_misc                  ... FAILED
    test create_operator              ... FAILED
    test create_procedure             ... ok
    test create_index                 ... FAILED
    test index_including              ... ok
    test create_view                  ... FAILED
    test create_aggregate             ... ok
    test create_function_3            ... ok
    test create_cast                  ... ok
    test constraints                  ... FAILED
    test triggers                     ... FAILED
    test inherit                      ...
    ^C


This is also where I left my last try to back port for PG11, I will try 
to fix it again but it could take time to have it working.

Best regards,

-- 
Gilles Darold


Le 08/12/2020 à 18:52, Andrey Borodin a écrit :
> Hi Gilles!
>
> Many thanks for your message!
>
>> 8 дек. 2020 г., в 21:05, Gilles Darold <gilles@darold.net> написал(а):
>>
>> I know that this report is not really helpful
> Quite contrary - this benchmarks prove that controllable reproduction exists. I've rebased patches for PG11. Can you please benchmark them (without extending SLRU)?
>
> Best regards, Andrey Borodin.
>

--------------0FBDDFB29502FA76DE6B21A1
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hi Andrey,</div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Thanks for the backport. I have issue
      with the first patch "Use shared lock in GetMultiXactIdMembers for
      offsets and members"
      (v1106-0001-Use-shared-lock-in-GetMultiXactIdMembers-for-o.patch)
      the applications are not working anymore when I'm applying it.
      Also PG regression tests are failing too on several part.</div>
    <blockquote>
      <div class="moz-cite-prefix"><br>
      </div>
      <tt>test insert_conflict              ... ok</tt><tt><br>
      </tt><tt>test create_function_1            ... FAILED</tt><tt><br>
      </tt><tt>test create_type                  ... FAILED</tt><tt><br>
      </tt><tt>test create_table                 ... FAILED</tt><tt><br>
      </tt><tt>test create_function_2            ... FAILED</tt><tt><br>
      </tt><tt>test copy                         ... FAILED</tt><tt><br>
      </tt><tt>test copyselect                   ... ok</tt><tt><br>
      </tt><tt>test copydml                      ... ok</tt><tt><br>
      </tt><tt>test create_misc                  ... FAILED</tt><tt><br>
      </tt><tt>test create_operator              ... FAILED</tt><tt><br>
      </tt><tt>test create_procedure             ... ok</tt><tt><br>
      </tt><tt>test create_index                 ... FAILED</tt><tt><br>
      </tt><tt>test index_including              ... ok</tt><tt><br>
      </tt><tt>test create_view                  ... FAILED</tt><tt><br>
      </tt><tt>test create_aggregate             ... ok</tt><tt><br>
      </tt><tt>test create_function_3            ... ok</tt><tt><br>
      </tt><tt>test create_cast                  ... ok</tt><tt><br>
      </tt><tt>test constraints                  ... FAILED</tt><tt><br>
      </tt><tt>test triggers                     ... FAILED</tt><tt><br>
      </tt><tt>test inherit                      ...<br>
        ^C<br>
      </tt></blockquote>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix"> This is also where I left my last try
      to back port for PG11, I will try to fix it again but it could
      take time to have it working. <br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Best regards,<br>
    </div>
    <div class="moz-cite-prefix">
      <pre class="moz-signature" cols="72">-- 
Gilles Darold</pre>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Le 08/12/2020 à 18:52, Andrey Borodin a
      écrit :<br>
    </div>
    <blockquote type="cite"
      cite="mid:3F5E23A3-6250-486E-9CCA-E2A5B6A28B4F@yandex-team.ru">
      <pre class="moz-quote-pre" wrap="">Hi Gilles!

Many thanks for your message!

</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">8 дек. 2020 г., в 21:05, Gilles Darold <a class="moz-txt-link-rfc2396E" href="mailto:gilles@darold.net">&lt;gilles@darold.net&gt;</a> написал(а):

I know that this report is not really helpful 
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Quite contrary - this benchmarks prove that controllable reproduction exists. I've rebased patches for PG11. Can you please benchmark them (without extending SLRU)?

Best regards, Andrey Borodin.

</pre>
    </blockquote>
  </body>
</html>

--------------0FBDDFB29502FA76DE6B21A1--