Message-ID: <3a9ac72a-00b5-e56c-f4a8-05fc4d184f10@dunslane.net>
Date: Mon, 18 Apr 2022 13:32:33 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and
 recovery_end_comman
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>, Andres Freund
 <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de>
 <3386734.1649354265@sss.pgh.pa.us>
 <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de>
 <4015413.1649454951@sss.pgh.pa.us>
 <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de>
 <CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com>
 <YlT23IvsXkGuLzFi@paquier.xyz>
 <CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com>
 <YluU3C4i8sHoVeOQ@paquier.xyz>
 <0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net>
 <YlynfULh/svXYbfT@paquier.xyz>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <YlynfULh/svXYbfT@paquier.xyz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/3a9ac72a-00b5-e56c-f4a8-05fc4d184f10%40dunslane.net>
Precedence: bulk


On 2022-04-17 Su 19:49, Michael Paquier wrote:
> On Sun, Apr 17, 2022 at 10:56:08AM -0400, Andrew Dunstan wrote:
>> I don't really think it's Cluster.pm's business to deal with that. It
>> takes an install path as given either explicitly or implicitly.
>>
>> It shouldn't be too hard to get Makefile.global to install valgrind
>> wrappers into the tmp_install/bin directory.
> Or what gets used in just a wrapper of the contents of bin/ that get
> enforced to be first in PATH?


That seems likely to be difficult. For example pg_ctl might find its
colocated postgres rather than the valgrind wrapper. Ditto initdb.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com