public inbox for [email protected]  
help / color / mirror / Atom feed
From: Peter Eisentraut <[email protected]>
To: Yurii Rashkovskii <[email protected]>
To: Tom Lane <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Greg Stark <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Allow Postgres to pick an unused port to listen
Date: Wed, 19 Apr 2023 06:10:27 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+RLCQw=a-=CQ6Pg-zuNwfNR=_Aa9R--F6jAR7bJZ5TCGYfOhw@mail.gmail.com>
References: <CA+RLCQwJBGAnBo7OZ6QxqJjEn6w=Mju9GrHQmwFxX_io+4Cwhw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CA+RLCQyTov4RhU8J9iRebdMangR7w99i1em23DeZx7NgpjBF+Q@mail.gmail.com>
	<CA+TgmobxUVJ9O6i_tYX9bFL4dO1UAKSgTnj1tGz0+c5MTRDLXA@mail.gmail.com>
	<CA+RLCQwmNGvENLWaHwh3gDMnDUWyopV35+V3dXsNUA9A6_ZxKQ@mail.gmail.com>
	<CA+TgmobBZs7mAVUoUAUc6yFOQTRefN8DnT_QMvqtm1QAv8Gfpg@mail.gmail.com>
	<CAM-w4HNO6d9Egr1JX+wGRFSJDOFVN6wMFxajfqdpgdx=eH20zQ@mail.gmail.com>
	<CA+Tgmob5BHPRhCZuZupKeacxMnvxHnuHAPXcA8XNj2KiPFDsKQ@mail.gmail.com>
	<[email protected]>
	<CA+RLCQzF2r1ShfXQRyTL6azhpuPMxDRWzJdHK75r5csrm_crHA@mail.gmail.com>
	<[email protected]>
	<CA+RLCQw=a-=CQ6Pg-zuNwfNR=_Aa9R--F6jAR7bJZ5TCGYfOhw@mail.gmail.com>

On 13.04.23 04:45, Yurii Rashkovskii wrote:
> But getting your agreement is important to get this in; I am willing to 
> play along and resolve both (1) and (2) in one go. As for the 
> implementation approach for (2), which of the following options would 
> you prefer?
> 
> a) Document postmaster.pid as it stands today
> b) Expose the port number through pg_ctl (*my personal favorite)
> c) Redesign its content below line 1 to make it extensible (make unnamed 
> lines named, for example)
> 
> If none of the above options suit you, do you have a strategy you'd prefer?

You could just drop another file into the data directory that just 
contains the port number ($PGDATA/port).  However, if we ever do 
multiple ports, that would still require a change in the format of that 
file, so I don't know if that's actually better than a).

I don't think involving pg_ctl is necessary or desirable, since it would 
make any future changes like that even more complicated.






view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Allow Postgres to pick an unused port to listen
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox