Subject: Re: Unix-domain socket support on Windows
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
References: <54bde68c-d134-4eb8-5bd3-8af33b72a010@2ndquadrant.com>
 <00d4945e-b437-f3b5-f4af-42e99321c846@2ndquadrant.com>
 <CA+hUKGLkUTNjRZC9e4XjvLQCXL9Dre5ZQhoPqN+rZWbGYV1BQA@mail.gmail.com>
 <fe46da42-00f0-ef1f-ab52-456df58b5bff@2ndquadrant.com>
 <5974caea-1267-7708-40f2-6009a9d653b0@2ndquadrant.com>
 <CAA8=A7-VsWR9Z8Dg0XWTreP_x5=u2cXpGgJymy8-_yesEpHMFg@mail.gmail.com>
 <ce26e70c-cfa6-2f47-5c33-f88bc4d4f288@2ndquadrant.com>
 <75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Organization: 2ndQuadrant
Message-ID: <3b5fed50-9017-49ca-b556-303a0cc1b660@2ndquadrant.com>
Date: Thu, 30 Jan 2020 19:28:00 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-12-18 14:52, Peter Eisentraut wrote:
> Next patch:  This allows building *with* Unix-domain socket support but
> *without* a default Unix socket path.  This is needed because on Windows
> we don't have a good default location like "/tmp" and we probably don't
> want Unix sockets by default at run time so that older Windows versions
> continue to work out of the box with the same binaries.
> 
> We have code paths for Unix socket support and no Unix socket support.
> Now add a third variant: Unix socket support but do not use a Unix
> socket by default in the client or the server, only if you explicitly
> specify one.
> 
> To implement this, tweak things so that setting DEFAULT_PGSOCKET_DIR
> to "" has the desired effect.  This mostly already worked like that;
> only a few places needed to be adjusted.  Notably, the reference to
> DEFAULT_PGSOCKET_DIR in UNIXSOCK_PATH() could be removed because all
> callers already resolve an empty socket directory setting with a
> default if appropriate.

Perhaps this patch is too boring to be reviewed.  If there are no 
objections, I'll commit it soon and then submit the final patches with 
the real functionality for the next commit fest.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services