Message-ID: <3b6d9bcf-5b48-4210-921b-4641c74e1b39@gmail.com>
Date: Mon, 21 Oct 2024 09:36:04 +0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: type cache cleanup improvements
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Artur Zakirov <zaartur@gmail.com>, Alexander Lakhin
 <exclusion@gmail.com>, jian he <jian.universality@gmail.com>,
 Pavel Borisov <pashkin.elfe@gmail.com>, Teodor Sigaev <teodor@sigaev.ru>,
 Pgsql Hackers <pgsql-hackers@postgresql.org>,
 Aleksander Alekseev <aleksander@timescale.com>, Tom Lane
 <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>
References: <f815773a-215c-4ffd-8b1b-35901f92f52f@sigaev.ru>
 <1927cba4-177e-5c23-cbcc-d444a850304f@gmail.com>
 <CAPpHfduPbcfQShtxGO72zr0+7EGKTob4HzQfUw7=3K3H5ZgqRw@mail.gmail.com>
 <CAPpHfduFDXgu3VCCWSPiiv+RKp3igO4PqPJOy_+Vf7mU3_n6iQ@mail.gmail.com>
 <8613a1d1-e19c-41fc-8b9d-efc62d63fc17@gmail.com>
 <CAPpHfdvYFxjsoRHiQb=pVoYuFogyw4Wd2W0f-c0sFwNLehmbbw@mail.gmail.com>
 <CAPpHfdtkn=Q3JicCgoubDuty9f+V36=4zEsTSCVqE71XiwS8pQ@mail.gmail.com>
 <57fe476a-01c1-452e-ad0a-8eb49123bd28@gmail.com>
 <CAPpHfdsQhwUrnB3of862j9RgHoJM--eRbifvBMvtQxpC57dxCA@mail.gmail.com>
 <CAKNkYnxKgjLaQrbJaxqvS_bdvVVZ6Ty9ihGWL5b6sEFCAshJtw@mail.gmail.com>
 <CAPpHfdtQHpr6aMALxRmB+6SGBsYWVdTim9iW+zJtUjjU1L2CPQ@mail.gmail.com>
 <CACJufxHJ7ZRMbYgmsM3S3Tcw9UxMa7hE1S_1L3V9N-pVG=Te0A@mail.gmail.com>
 <CAPpHfdss4xOrAXD8bS+0nc2GyZBuNX=1QbgLwpjCLg4rzbbrhw@mail.gmail.com>
 <f3f5db41-ffd3-4d67-9dd6-3d00786ac3ab@gmail.com>
 <CAPpHfdtj5yXgPiPJBenTLaFvBbF7U+LVpN=Eho1=o01jU_KQaA@mail.gmail.com>
Content-Language: en-US
From: Andrei Lepikhov <lepihov@gmail.com>
In-Reply-To: <CAPpHfdtj5yXgPiPJBenTLaFvBbF7U+LVpN=Eho1=o01jU_KQaA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/3b6d9bcf-5b48-4210-921b-4641c74e1b39%40gmail.com>
Precedence: bulk

On 21/10/2024 00:36, Alexander Korotkov wrote:
> On Thu, Oct 17, 2024 at 12:41 PM Andrei Lepikhov <lepihov@gmail.com> wrote:
>> I think the first patch may already be committed, and this little burden
>> may be avoided in future versions.
> I've integrated your patch.  But I think
> finalize_in_progress_typentries() is more appropriate place to check
> typentry for NULL.  Also, I've revised the
> finalize_in_progress_typentries() header comment.  I'm going to push
> these patches if no objections.
I agree with your idea. Also, I think it would be more conventional not 
to check the type entry for a NULL value but to test the 'found' value 
instead.
And thanks for the injection points tests! I must have slipped my mind 
about this option.
Now, the patch set looks good for me.

-- 
regards, Andrei Lepikhov