From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: btree_gin and btree_gist for enums
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <56EA8A71.8060107@dunslane.net> <56EACB8C.1040406@dunslane.net>
 <CAE2gYzyB=vyquQ2hEWA9UwNb=zYAKFsNO5vBtbfkV2=PzoPZjg@mail.gmail.com>
 <03f7d748-0f89-e8e1-094d-f04e1026b93d@dunslane.net>
 <27220.1478360811@sss.pgh.pa.us>
 <e60f50c4-899a-d48a-6cb4-4611acf2f73c@dunslane.net>
 <31412.1478366009@sss.pgh.pa.us>
 <60fb708c-8b3c-1337-934e-c1bfe2afc539@dunslane.net>
 <db2b70a4-78d7-294a-a315-8e7f506c5978@2ndQuadrant.com>
 <8258.1487886101@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Message-ID: <3b969375-dcb5-aa73-b8e9-cacd5c8d60ef@2ndQuadrant.com>
Date: Thu, 23 Feb 2017 16:45:00 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <8258.1487886101@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 02/23/2017 04:41 PM, Tom Lane wrote:
> BTW, while I'm looking at this ... isn't gin_enum_cmp broken on its face?
> It's using DirectFunctionCall2 to call enum_cmp, and that's wrong because
> DirectFunctionCall2 does not pass through a flinfo but enum_cmp needs to
> have one.  I've not tested, but I'm certain that this would dump core if
> asked to compare odd-numbered enum OIDs.
>
> 			


Yes, that's what I'm trying to fix.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers