public inbox for [email protected]  

help / color / mirror / Atom feed

From: Drouvot, Bertrand <[email protected]>
To: [email protected]
To: pgsql-hackers <[email protected]>
Subject: Re: Add the ability to limit the amount of memory that can be allocated to backends.
Date: Fri, 2 Sep 2022 09:30:21 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi,

On 8/31/22 6:50 PM, Reid Thompson wrote:
> Hi Hackers,
>
> Add the ability to limit the amount of memory that can be allocated to
> backends.

Thanks for the patch.

+ 1 on the idea.

> Specifies a limit to the amount of memory (MB) that may be allocated to
> backends in total (i.e. this is not a per user or per backend limit).
> If unset, or set to 0 it is disabled. It is intended as a resource to
> help avoid the OOM killer. A backend request that would push the total
> over the limit will be denied with an out of memory error causing that
> backends current query/transaction to fail.

I'm not sure we are choosing the right victims here (aka the ones that 
are doing the request that will push the total over the limit).

Imagine an extreme case where a single backend consumes say 99% of the 
limit, shouldn't it be the one to be "punished"? (and somehow forced to 
give the memory back).

The problem that i see with the current approach is that a "bad" backend 
could impact all the others and continue to do so.

what about punishing say the highest consumer , what do you think? (just 
speaking about the general idea here, not about the implementation)

Regards,

-- 

Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Add the ability to limit the amount of memory that can be allocated to backends.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox