Content-Type: multipart/alternative;
 boundary="------------lVohkdpjzsipWmbrXy1okgDw"
Message-ID: <3bd49b59-7a87-4ab6-9eac-59b5d9cb78de@dunslane.net>
Date: Mon, 16 Feb 2026 11:28:58 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] pgindent truncates last line of files missing a trailing
 newline
To: Akshay Joshi <akshay.joshi@enterprisedb.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <CANxoLDfca8O5SkeDxB_j6SVNXd+pNKaDmVmEW+2yyicdU8fy0w@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: <CANxoLDfca8O5SkeDxB_j6SVNXd+pNKaDmVmEW+2yyicdU8fy0w@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/3bd49b59-7a87-4ab6-9eac-59b5d9cb78de%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------lVohkdpjzsipWmbrXy1okgDw
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2026-02-16 Mo 9:09 AM, Akshay Joshi wrote:
> Hi Hackers,
>
> I have encountered a bug in "*src/tools/pg_bsd_indent/lexi.c"* where 
> pgindent was incorrectly dropping the final line of a file if that 
> line did not end with a newline character (\n). This occurred because 
> the EOF logic triggered a termination of the processing loop before 
> the remaining buffer was flushed to the output.
>
> *Steps to Reproduce:*
>
>  1. Create a *header/c* file with some content but no newline at the
>     very end.
>  2. Run pgindent on those files.
>  3. Check the file content. The file is now empty or missing the last
>     line.
>
> This patch ensures that had_eof states do not bypass the final buffer 
> processing, preserving the integrity of the source code regardless of 
> trailing whitespace.


Yeah. I wonder if we shouldn't be just ensuring that there is a line 
feed at the end of the buffer, i.e. add one if it's not there. We 
shouldn't be adding files without a trailing LF, and ensuring there is 
one seems like a reasonable thing to do in pg_bsd_indent.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------lVohkdpjzsipWmbrXy1okgDw
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2026-02-16 Mo 9:09 AM, Akshay Joshi
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CANxoLDfca8O5SkeDxB_j6SVNXd+pNKaDmVmEW+2yyicdU8fy0w@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div>Hi Hackers,<br>
          <br>
          I have encountered a bug in "<b>src/tools/pg_bsd_indent/lexi.c"</b> where
          pgindent was incorrectly dropping the final line of a file if
          that line did not end with a newline character (\n). This
          occurred because the EOF logic triggered a termination of the
          processing loop before the remaining buffer was flushed to the
          output.<br>
          <br>
          <b>Steps to Reproduce:</b><br>
          <ol>
            <li>Create a <b>header/c</b> file with some content but no
              newline at the very end.</li>
            <li>Run pgindent on those files.</li>
            <li>Check the file content. The file is now empty or missing
              the last line.</li>
          </ol>
        </div>
        <div>This patch ensures that had_eof states do not bypass the
          final buffer processing, preserving the integrity of the
          source code regardless of trailing whitespace.<br>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>Yeah. I wonder if we shouldn't be just ensuring that there is a
      line feed at the end of the buffer, i.e. add one if it's not
      there. We shouldn't be adding files without a trailing LF, and
      ensuring there is one seems like a reasonable thing to do in
      pg_bsd_indent.<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><br>
    </p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------lVohkdpjzsipWmbrXy1okgDw--