Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xM1JT-00000001oR7-0R3K for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Oct 2026 10:55:23 +0000 Received: from localhost ([127.0.0.1]:56728 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xM1JS-0000000FKDw-2Rv5 for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Oct 2026 10:55:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:34090) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xM1JS-0000000FKDm-0zMZ for pgsql-hackers@lists.postgresql.org; Wed, 28 Oct 2026 10:55:22 +0000 Received: from eastern.birch.relay.mailchannels.net ([23.83.209.55]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xM1JQ-00000001Ld2-0NQe for pgsql-hackers@postgresql.org; Wed, 28 Oct 2026 10:55:21 +0000 X-Sender-Id: hostingeremail|x-authuser|david@pgbackrest.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 888098C336E; Wed, 28 Oct 2026 10:55:18 +0000 (UTC) Received: from de-fra-smtpout4.hostinger.io (100-96-13-77.trex-nlb.outbound.svc.cluster.local [100.96.13.77]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id C7B448C1DEE; Wed, 28 Oct 2026 10:55:16 +0000 (UTC) X-Sender-Id: hostingeremail|x-authuser|david@pgbackrest.org X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|david@pgbackrest.org X-MailChannels-Auth-Id: hostingeremail X-Tangy-Turn: 568ee4e764871d79_1793184918299_3278615855 X-MC-Loop-Signature: 1793184918299:2612245784 X-MC-Ingress-Time: 1793184918299 Received: from de-fra-smtpout4.hostinger.io (de-fra-smtpout4.hostinger.io [148.222.55.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.96.13.77 (trex/8.0.2); Wed, 28 Oct 2026 10:55:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgbackrest.org; s=hostingermail1; t=1793184914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ewy2qnNUN0k8+2ueiuszFsfpnwTrCA2jDV4nYdlJVmE=; b=pNlAUOc7/unlzqekHv3NsSObTSWIFm0KUyKYV3vQCjhHwhAcYdmkmifF1Nk0Y35QavdRXI kid+pMTNtYPFRePPIydULyEHMlPOco80bZjFLnjooFXfCCKtlETF7pFBqNtwOng+p7tIaA dklnzeKcVfOL0uzDp30YuIpczsfZppoMQExtDeeoQ84W/c52+jXou2ajw89NJB7T6cZGtn 0lX6fODFGw7YORhZAcOrS/g0jjluBKDQh34s9QHmqkk9LBqQrk+LZuzyoHH+ptVSJJxBGL ELpmzwT3uPy7wIBvZ6FtbBqGJfCpqdqTPTTsD2DrP5yug0l5EPHe2kyQdBz8fA== Received: from [10.3.0.2] (unknown [87.249.138.129]) (Authenticated sender: david@pgbackrest.org) by smtp.hostinger.com (smtp.hostinger.com) with ESMTPSA id 4jF45C5bR5z3xM0; Wed, 28 Oct 2026 10:55:11 +0000 (UTC) Message-ID: <3bddbc41-b274-47b6-abd4-d11918906b32@pgbackrest.org> MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Return pg_control from pg_backup_stop(). To: Heikki Linnakangas , Pg Hackers Cc: Michael Paquier , Robert Haas , Andres Freund , Fujii Masao , solai v References: <8b8aa673-fcef-4e14-a05d-0885283ef1b8@pgbackrest.org> <17DC1346-0CDE-4E39-B110-3D6FB0797AC6@gmail.com> <7F7B289B-F94F-42C2-9E54-6A689C0D64BB@gmail.com> <1800c83c-264a-4183-9da5-ac78e25849a8@pgbackrest.org> <3b23e3b7-53d2-4784-b482-05cca3327acb@pgbackrest.org> <4193dcbc-591e-44bb-816c-43b4ae70d31c@pgbackrest.org> <86436ff9-eb98-4c8a-825e-3bcae022107b@pgbackrest.org> <9b37265e-8025-4e8a-9a9c-c4232eaf746f@pgbackrest.org> <7971d005-e713-4a17-b0d9-855d9897ef14@iki.fi> <9ae9db4e-5a6a-4b4d-aa24-7e5da664bd0e@pgbackrest.org> <3e174819-8682-444b-905c-c2c40a709c8f@iki.fi> Content-Language: en-US From: David Steele In-Reply-To: <3e174819-8682-444b-905c-c2c40a709c8f@iki.fi> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 28 Oct 2026 10:55:11 +0000 (UTC) X-CM-Envelope: MS4xfMaGRGQDYcxJYJTvBRUv7awneY+oXv44Xn5XXW/LYPj0Yp+AzEvEqo9u8PWXjTf76R3Ym4gYIfbDaDcO6yTiFJkvveE8PyObEkeOlMMa6et0JAj1UIYU a2nK79ZjBrKKzb4qRYhGZZ01XJO8tL7/P/XO2gfiTzQOgvBWzeCX/f0EktumEpIlfjEsrAwQlQjoHd/J32/JOJ2S2jXi2hYrykjVhcpFNTWc3y8pJ0MbTIsT ZpJXlMAHphVsrr3zGx1pjI17+wSE95zJ18ijPkF8ZcHYQn7k0stB9so9Iy6gtaQWo0TP6Fl3epZGUw034GsBeJjwIqqSzn0CzkJnZc5YTIfdMBo82xw0bxsG 1TYbbi4Sz2T/BdQgi5EHrwh9Rj9MwQ== X-CM-Analysis: v=2.4 cv=fOFr3oae c=1 sm=1 tr=0 ts=6ae1d492 a=BQQuLM3hWoeC1D9SHByaVQ==:117 a=BQQuLM3hWoeC1D9SHByaVQ==:17 a=IkcTkHD0fZMA:10 a=ubVzeBKoAFmHuVMIT2MA:9 a=QEXdDO2ut3YA:10 X-AuthUser: david@pgbackrest.org List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 10/28/26 10:48, Heikki Linnakangas wrote: > On 26/10/2026 13:42, David Steele wrote: >> On 10/23/26 18:17, Heikki Linnakangas wrote: >>> On 23/10/2026 15:42, David Steele wrote: >>> Umm, not new with his patch, but why do we still have that hint to >>> remove backup_label? Is that ever the right thing to do? Why didn't >>> we remove that hint when exclusive-mode backups were removed? >> >> Unfortunately I believe there is still a use case for this hint. When >> making a backup, e.g. via snapshot, it is still easier to write the >> backup_label into PGDATA, make the snapshot, then remove it. If the >> cluster crashes before the removal then the answer is to remove the >> backup label, just as it was if exclusive backup crashed. >> >> I'm not excited about the above use case but not sure we can discount >> it entirely. > > If you take an atomic filesystem-level snapshot, restoring it is > equivalent to crash recovery, so you don't need a backup_label to > restore it to a consistent state. There's no need for pg_start_backup() > or a backup_label in that case. Admittedly, a non-atomic snapshot is a > different story. True, but I recommend *always* using the documented backup procedure, especially if PITR will be used on restore. > But I don't see how you could do that anyway. The backup_label is > returned by pg_stop_backup(). If the sequence is: > > 1. pg_start_backup() > 2. take filesystem snapshot > 3. pg_stop_backup() > > there's no way to include the backup_label in the snapshot, because you > don't have it until you call pg_stop_backup(). Oops, yeah, that was an old pattern what was still usable up until PG14 but should no longer be possible. I searched the thread where we removed exclusive backup and I can't see any reason why we would have kept it, so it was probably an oversight. Once Michael and I have resolved the build farm issue with 01 I'll rebase and make the removal a small patch before adding the pgcontrol flag -- unless you would prefer a separate thread. Regards, -David