Feedback-ID: i131946ab:Fastmail
Message-ID: <3c36b798-fbb2-9246-fafd-4e4b2f546de8@enterprisedb.com>
Date: Thu, 13 Oct 2022 12:26:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: Allow tests to pass in OpenSSL FIPS mode
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <dbbd927f-ef1f-c9a1-4ec6-c759778ac852@enterprisedb.com>
 <647f6cc1-473d-f788-ade0-c09201e5ab6a@enterprisedb.com>
 <Y0YV+lQNQFRIdvGJ@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <Y0YV+lQNQFRIdvGJ@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/3c36b798-fbb2-9246-fafd-4e4b2f546de8%40enterprisedb.com>
Precedence: bulk

On 12.10.22 03:18, Michael Paquier wrote:
> On Tue, Oct 11, 2022 at 01:51:50PM +0200, Peter Eisentraut wrote:
>> Let's make a small start on this.  The attached patch moves the tests of the
>> md5() function to a separate test file.  That would ultimately make it
>> easier to maintain a variant expected file for FIPS mode where that function
>> will fail (similar to how we have done it for the pgcrypto tests).
> 
> Makes sense to me.  This slice looks fine.

Committed.

> I think that the other md5() computations done in the main regression
> test suite could just be switched to use one of the sha*() functions
> as they just want to put their hands on text values.  It looks like a
> few of them have some expections with the output size and
> generate_series(), though, but this could be tweaked by making the
> series shorter, for example.

Right, that's the rest of my original patch.  I'll come back with an 
updated version of that.