MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Mon, 05 Apr 2021 10:30:01 +0300
From: Maxim Orlov <m.orlov@postgrespro.ru>
To: Fujii Masao <masao.fujii@oss.nttdata.com>, Pgsql Hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: Failed assertion on standby while shutdown
In-Reply-To: <ba2c75e0-22c1-2903-6cb3-18ebc107534d@oss.nttdata.com>
References: <ad4ce692cc1d89a093b471ab1d969b0b@postgrespro.ru>
 <c4c70e9a-297d-feb4-b299-a2e61f6a9920@oss.nttdata.com>
 <161712624344.1180.1891286647778019120.pgcf@coridan.postgresql.org>
 <aab1eaacb409fef145aad0e9e1088e65@postgrespro.ru>
 <ba2c75e0-22c1-2903-6cb3-18ebc107534d@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.4.0
Message-ID: <3c454bbe91f4ee67d9fc078926a72dc1@postgrespro.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/3c454bbe91f4ee67d9fc078926a72dc1%40postgrespro.ru>
Precedence: bulk

On 2021-04-01 15:02, Fujii Masao wrote:
> On 2021/03/31 19:51, Maxim Orlov wrote:
>> On 2021-03-30 20:44, Maxim Orlov wrote:
>>> The following review has been posted through the commitfest 
>>> application:
>>> make installcheck-world:  tested, passed
>>> Implements feature:       tested, passed
>>> Spec compliant:           not tested
>>> Documentation:            not tested
>>> 
>>> All the tests passed successfully.
>>> 
>>> The new status of this patch is: Ready for Committer
>> 
>> The patch is good. One note, should we put a comment about 
>> ShutdownRecoveryTransactionEnvironment not reentrant behaviour? Or 
>> maybe rename it to ShutdownRecoveryTransactionEnvironmentOnce?
> 
> +1 to add more comments into ShutdownRecoveryTransactionEnvironment().
> I did that. What about the attached patch?
> 
> Regards,

Well done! In my view is just what it's needed.

---
Best regards,
Maxim Orlov.