Feedback-ID: i131946ab:Fastmail
Message-ID: <3c87f4db-560b-d9b7-77f4-bdb67e0d122b@enterprisedb.com>
Date: Wed, 7 Dec 2022 17:11:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.1
Subject: Re: Think-o in foreign key comments
Content-Language: en-US
To: Ian Lawrence Barwick <barwick@gmail.com>,
 Paul Jungwirth <pj@illuminatedcomputing.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
References: <6a7c7338-1aa2-4689-d171-0b0b294fdd84@illuminatedcomputing.com>
 <CAB8KJ=h=X0QgK_MciFR8r1dpXpsmkBxSkuK75+okOG3P5T2cnA@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAB8KJ=h=X0QgK_MciFR8r1dpXpsmkBxSkuK75+okOG3P5T2cnA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/3c87f4db-560b-d9b7-77f4-bdb67e0d122b%40enterprisedb.com>
Precedence: bulk

On 03.12.22 05:59, Ian Lawrence Barwick wrote:
> 2022年12月3日(土) 7:19 Paul Jungwirth <pj@illuminatedcomputing.com>:
>> I noticed a few places in the new foreign key code where a comment says
>> "the ON DELETE SET NULL/DELETE clause". I believe it should say "ON
>> DELETE SET NULL/DEFAULT".
>>
>> These comments were added in d6f96ed94e7, "Allow specifying column list
>> for foreign key ON DELETE SET actions." Here is a patch to correct them.
> 
> LGTM.
> 
> I do notice the same patch adds the function "validateFkOnDeleteSetColumns"
> but the name in the comment preceding it is "validateFkActionSetColumns",
> might as well fix that the same time.

Committed with that addition and backpatched to PG15.