Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYzC5-0005yo-4O for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Apr 2021 22:50:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lYzC4-0002Sn-33 for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Apr 2021 22:50:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYzC3-0002Qk-Os for pgsql-hackers@lists.postgresql.org; Tue, 20 Apr 2021 22:50:07 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lYzBy-0002RY-Ef for pgsql-hackers@lists.postgresql.org; Tue, 20 Apr 2021 22:50:06 +0000 Received: from mail.postgrespro.ru (cyclops.postgrespro.ru [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id A15AC21C60E4; Wed, 21 Apr 2021 01:49:59 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1618958999; bh=mvBIVmTvfG7eRhAkG29Y6TXwvZnMoQWv7REKUjLbrm4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=J+6oYL7bC9p2lDeLF2ny6xqoDLh2fshkGZcHWXtNrE0vO1gJDXsTWanGz5RcXGd/L TeSnUt99oijz/Qduw51Ap9WVZa3eeWXtOLLvMcnI9+xoGQwLStf4h6JAAO5Nhw6fMi oQskg4nQHKpkUYvMPvIAB3qKGuOo2DPAQ6OAsnlc= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_32949d44d43550d188088443bea76734" Content-Transfer-Encoding: 7bit Date: Wed, 21 Apr 2021 01:49:59 +0300 From: Alexey Kondratov To: Tom Lane Cc: Andrew Dunstan , pgsql-hackers@lists.postgresql.org Subject: Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems In-Reply-To: <559792.1618931011@sss.pgh.pa.us> References: <20210127213658.GA736@alvherre.pgsql> <55c6c1526b94d2caf54c33262fe00674@postgrespro.ru> <1c506564e2a732ec17790bd8c34f042e@postgrespro.ru> <66bad38beb87fb32952d89602e467444@postgrespro.ru> <82e271a9a11928337fcb5b5e57b423c0@postgrespro.ru> <459595.1618874567@sss.pgh.pa.us> <519ddb94-f3ac-e9cc-3a61-7003c26f62f8@dunslane.net> <559792.1618931011@sss.pgh.pa.us> User-Agent: Roundcube Webmail/1.4.0 Message-ID: <3cba5930342a51665e6959002cedb4d9@postgrespro.ru> X-Sender: a.kondratov@postgrespro.ru List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_32949d44d43550d188088443bea76734 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2021-04-20 18:03, Tom Lane wrote: > Andrew Dunstan writes: >> On 4/19/21 7:22 PM, Tom Lane wrote: >>> I wonder whether we could get away with just replacing the $use_tcp >>> test with $TestLib::windows_os. It's not really apparent to me >>> why we should care about 127.0.0.not-1 on Unix-oid systems. > >> Yeah >> The comment is a bit strange anyway - Cygwin is actually going to use >> Unix sockets, not TCP. >> I think I would just change the test to this: $use_tcp && >> $TestLib::windows_os. > > Works for me, but we need to revise the comment to match. > Then it could be somewhat like that, I guess. Regards -- Alexey Kondratov Postgres Professional https://www.postgrespro.com Russian Postgres Company --=_32949d44d43550d188088443bea76734 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=PostgresNode.diff Content-Disposition: attachment; filename=PostgresNode.diff; size=1677 ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3BlcmwvUG9zdGdyZXNOb2RlLnBtIGIvc3JjL3Rlc3QvcGVy bC9Qb3N0Z3Jlc05vZGUucG0KaW5kZXggZGI0N2E5N2QxOTYuLmY3YjQ4OGVkNDY0IDEwMDY0NAot LS0gYS9zcmMvdGVzdC9wZXJsL1Bvc3RncmVzTm9kZS5wbQorKysgYi9zcmMvdGVzdC9wZXJsL1Bv c3RncmVzTm9kZS5wbQpAQCAtMTE5MSwxOSArMTE5MSwxOSBAQCBzdWIgZ2V0X2ZyZWVfcG9ydAog CQkjIENoZWNrIHRvIHNlZSBpZiBhbnl0aGluZyBlbHNlIGlzIGxpc3RlbmluZyBvbiB0aGlzIFRD UCBwb3J0LgogCQkjIFNlZWsgYSBwb3J0IGF2YWlsYWJsZSBmb3IgYWxsIHBvc3NpYmxlIGxpc3Rl bl9hZGRyZXNzZXMgdmFsdWVzLAogCQkjIHNvIGNhbGxlcnMgY2FuIGhhcm5lc3MgdGhpcyBwb3J0 IGZvciB0aGUgd2lkZXN0IHJhbmdlIG9mIHB1cnBvc2VzLgotCQkjIFRoZSAwLjAuMC4wIHRlc3Qg YWNoaWV2ZXMgdGhhdCBmb3IgcG9zdC0yMDA2IEN5Z3dpbiwgd2hpY2gKLQkJIyBhdXRvbWF0aWNh bGx5IHNldHMgU09fRVhDTFVTSVZFQUREUlVTRS4gIFRoZSBzYW1lIGhvbGRzIGZvciBNU1lTIChh Ci0JCSMgQ3lnd2luIGZvcmspLiAgVGVzdGluZyAwLjAuMC4wIGlzIGluc3VmZmljaWVudCBmb3Ig V2luZG93cyBuYXRpdmUKLQkJIyBQZXJsIChodHRwczovL3N0YWNrb3ZlcmZsb3cuY29tL2EvMTQz ODg3MDcpLCBzbyB3ZSBhbHNvIHRlc3QKLQkJIyBpbmRpdmlkdWFsIGFkZHJlc3Nlcy4KKwkJIyBU aGUgMC4wLjAuMCB0ZXN0IGFjaGlldmVzIHRoYXQgZm9yIE1TWVMsIHdoaWNoIGF1dG9tYXRpY2Fs bHkgc2V0cworCQkjIFNPX0VYQ0xVU0lWRUFERFJVU0UuICBUZXN0aW5nIDAuMC4wLjAgaXMgaW5z dWZmaWNpZW50IGZvciBXaW5kb3dzCisJCSMgbmF0aXZlIFBlcmwgKGh0dHBzOi8vc3RhY2tvdmVy Zmxvdy5jb20vYS8xNDM4ODcwNyksIHNvIHdlIGFsc28KKwkJIyBoYXZlIHRvIHRlc3QgaW5kaXZp ZHVhbCBhZGRyZXNzZXMuICBEb2luZyB0aGF0IGZvciAxMjcuMC4wLzI0CisJCSMgYWRkcmVzc2Vz IG90aGVyIHRoYW4gMTI3LjAuMC4xIG1pZ2h0IGZhaWwgd2l0aCBFQUREUk5PVEFWQUlMIG9uCisJ CSMgbm9uLUxpbnV4LCBub24tV2luZG93cyBrZXJuZWxzLgogCQkjCi0JCSMgT24gbm9uLUxpbnV4 LCBub24tV2luZG93cyBrZXJuZWxzLCBiaW5kaW5nIHRvIDEyNy4wLjAvMjQgYWRkcmVzc2VzCi0J CSMgb3RoZXIgdGhhbiAxMjcuMC4wLjEgbWlnaHQgZmFpbCB3aXRoIEVBRERSTk9UQVZBSUwuICBC aW5kaW5nIHRvCi0JCSMgMC4wLjAuMCBpcyB1bm5lY2Vzc2FyeSBvbiBub24tV2luZG93cyBzeXN0 ZW1zLgorCQkjIFRoYXQgd2F5LCAwLjAuMC4wIGFuZCBpbmRpdmlkdWFsIDEyNy4wLjAvMjQgYWRk cmVzc2VzIGFyZSB0ZXN0ZWQKKwkJIyBvbmx5IG9uIFdpbmRvd3Mgd2hlbiBUQ1AgdXNhZ2UgaXMg cmVxdWVzdGVkLgogCQlpZiAoJGZvdW5kID09IDEpCiAJCXsKIAkJCWZvcmVhY2ggbXkgJGFkZHIg KHF3KDEyNy4wLjAuMSksCi0JCQkJJHVzZV90Y3AgPyBxdygxMjcuMC4wLjIgMTI3LjAuMC4zIDAu MC4wLjApIDogKCkpCisJCQkJJHVzZV90Y3AgJiYgJFRlc3RMaWI6OndpbmRvd3Nfb3MgPyBxdygx MjcuMC4wLjIgMTI3LjAuMC4zIDAuMC4wLjApIDogKCkpCiAJCQl7CiAJCQkJaWYgKCFjYW5fYmlu ZCgkYWRkciwgJHBvcnQpKQogCQkJCXsK --=_32949d44d43550d188088443bea76734--