Content-Type: multipart/mixed; boundary="------------2amFY1dAS0YpkPTtPPzJDuCv"
Message-ID: <3ccde7a9-e4f9-e194-30e0-0936e6ad68ba@dunslane.net>
Date: Sun, 6 Feb 2022 12:06:41 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [RFC] building postgres with meson
Content-Language: en-US
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
References: <f12e3659-ec71-c6a3-56b8-7fa5e016e3c1@dunslane.net>
 <b9d19d7d-72bd-8f80-e08e-e6dbf523f15d@dunslane.net>
 <20211012165926.phrxn7vwx6ysfioj@alap3.anarazel.de>
 <20211012180934.b22v5nznbgtaoxyn@alap3.anarazel.de>
 <d1ea641b-0822-78dd-7a7e-cfe5f5f9cf8e@dunslane.net>
 <20211012192942.5chfraeix6qih6ke@alap3.anarazel.de>
 <1def3634-8d7d-a501-3caa-83e2f952418d@dunslane.net>
 <20211012204256.ie2l7j6unbbtioj5@alap3.anarazel.de>
 <20211013010304.ox6nssy3eyptbdhc@alap3.anarazel.de>
 <efe62862-6648-9f20-4b29-7441b9f99463@dunslane.net>
 <20211013172654.mjtiwpezmczk6ppy@alap3.anarazel.de>
 <20d4fa3a-e0f1-0ac4-1657-0698ee1c511f@dunslane.net>
In-Reply-To: <20d4fa3a-e0f1-0ac4-1657-0698ee1c511f@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/3ccde7a9-e4f9-e194-30e0-0936e6ad68ba%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------2amFY1dAS0YpkPTtPPzJDuCv
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 10/13/21 16:06, Andrew Dunstan wrote:
> On 10/13/21 1:26 PM, Andres Freund wrote:
>>> pexports will be in the resulting path, and the build will use the
>>> native compiler.
>> I don't see pexports anywhere in the msys installation. I can see it available
>> on sourceforge, and I see a few others asking where to get it from in the
>> context of msys, and being pointed to manually downloading it.
>
>
> Weird. fairywren has it, which means that it must have been removed from
> the packages at some stage, fairly recently as fairywren isn't that old.
> I just confirmed the absence on a 100% fresh install.
>
>
> It is in Strawberry's c/bin directory.
>
>
>> Seems like we should consider using gendef instead of pexports, given it's
>> available in msys?
>
> Yeah. It's missing on my ancient msys animal (frogmouth), but it doesn't
> build --with-perl.
>
>
> jacana seems to have it.
>
>
> If you prep a patch I'll test it.
>
>

Here's a patch. I've tested the perl piece on master and it works fine.
It applies cleanly down to 9.4, which is before we got transform modules
(9.5) which fail if we just omit doing this platform-specific piece.


Before that only plpython uses pexports, and we're not committed to
supporting plpython at all on old branches.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

--------------2amFY1dAS0YpkPTtPPzJDuCv
Content-Type: text/x-patch; charset=UTF-8; name="gendef.patch"
Content-Disposition: attachment; filename="gendef.patch"
Content-Transfer-Encoding: base64

Y29tbWl0IDgyM2IzNmQ5OGIKQXV0aG9yOiBBbmRyZXcgRHVuc3RhbiA8YW5kcmV3QGR1bnNs
YW5lLm5ldD4KRGF0ZTogICBTdW4gRmViIDYgMTA6NTM6MDYgMjAyMiAtMDUwMAoKICAgIFVz
ZSBnZW5kZWYgaW5zdGVhZCBvZiBwZXhwb3J0cyBmb3IgYnVpbGRpbmcgd2luZG93cyAuZGVm
IGZpbGVzCiAgICAKICAgIE1vZGVybiBtc3lzIHN5c3RlbXMgbGFjayBwZXhwb3J0cyBidXQg
aGF2ZSBnZW5kZWYgaW5zdGVhZCwgc28gdXNlIHRoYXQuCiAgICAKICAgIERpc2N1c3Npb246
IGh0dHBzOi8vcG9zdGdyLmVzL20vMjBkNGZhM2EtZTBmMS0wYWM0LTE2NTctMDY5OGVlMWM1
MTFmQGR1bnNsYW5lLm5ldD4KCmRpZmYgLS1naXQgYS9zcmMvcGwvcGxwZXJsL0dOVW1ha2Vm
aWxlIGIvc3JjL3BsL3BscGVybC9HTlVtYWtlZmlsZQppbmRleCA5MTlkNDY0NTNmLi5hMmU2
NDEwZjUzIDEwMDY0NAotLS0gYS9zcmMvcGwvcGxwZXJsL0dOVW1ha2VmaWxlCisrKyBiL3Ny
Yy9wbC9wbHBlcmwvR05VbWFrZWZpbGUKQEAgLTQ4LDcgKzQ4LDcgQEAgbGliJChwZXJsd2l0
aHZlcikuYTogJChwZXJsd2l0aHZlcikuZGVmCiAJZGxsdG9vbCAtLWRsbG5hbWUgJChwZXJs
d2l0aHZlcikuZGxsIC0tZGVmICQocGVybHdpdGh2ZXIpLmRlZiAtLW91dHB1dC1saWIgbGli
JChwZXJsd2l0aHZlcikuYQogCiAkKHBlcmx3aXRodmVyKS5kZWY6ICQoUEVSTERMTCkKLQlw
ZXhwb3J0cyAkXiA+ICRACisJZ2VuZGVmIC0gJF4gPiAkQAogCiBlbmRpZiAjIHdpbjMyCiAK
ZGlmZiAtLWdpdCBhL3NyYy9wbC9wbHB5dGhvbi9NYWtlZmlsZSBiL3NyYy9wbC9wbHB5dGhv
bi9NYWtlZmlsZQppbmRleCA5ZTk1Mjg1YWY4Li5hODNhZTg4NjVjIDEwMDY0NAotLS0gYS9z
cmMvcGwvcGxweXRob24vTWFrZWZpbGUKKysrIGIvc3JjL3BsL3BscHl0aG9uL01ha2VmaWxl
CkBAIC02OSw3ICs2OSw3IEBAIGxpYnB5dGhvbiR7cHl0dmVyc3RyfS5hOiBweXRob24ke3B5
dHZlcnN0cn0uZGVmCiAJZGxsdG9vbCAtLWRsbG5hbWUgcHl0aG9uJHtweXR2ZXJzdHJ9LmRs
bCAtLWRlZiBweXRob24ke3B5dHZlcnN0cn0uZGVmIC0tb3V0cHV0LWxpYiBsaWJweXRob24k
e3B5dHZlcnN0cn0uYQogCiBweXRob24ke3B5dHZlcnN0cn0uZGVmOgotCXBleHBvcnRzICQo
UFlUSE9ORExMKSA+ICRACisJZ2VuZGVmIC0gJChQWVRIT05ETEwpID4gJEAKIAogZW5kaWYg
IyB3aW4zMgogCmRpZmYgLS1naXQgYS9zcmMvcGwvdGNsL01ha2VmaWxlIGIvc3JjL3BsL3Rj
bC9NYWtlZmlsZQppbmRleCAxZTc3NDBkYTNmLi4yNWU2NTE4OWI2IDEwMDY0NAotLS0gYS9z
cmMvcGwvdGNsL01ha2VmaWxlCisrKyBiL3NyYy9wbC90Y2wvTWFrZWZpbGUKQEAgLTQ2LDcg
KzQ2LDcgQEAgbGliJCh0Y2x3aXRodmVyKS5hOiAkKHRjbHdpdGh2ZXIpLmRlZgogCWRsbHRv
b2wgLS1kbGxuYW1lICQodGNsd2l0aHZlcikuZGxsIC0tZGVmICQodGNsd2l0aHZlcikuZGVm
IC0tb3V0cHV0LWxpYiBsaWIkKHRjbHdpdGh2ZXIpLmEKIAogJCh0Y2x3aXRodmVyKS5kZWY6
ICQoVENMRExMKQotCXBleHBvcnRzICReID4gJEAKKwlnZW5kZWYgLSAkXiA+ICRACiAKIGVu
ZGlmICMgd2luMzIKIAo=

--------------2amFY1dAS0YpkPTtPPzJDuCv--