Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTdtF-0006MZ-FR for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Sep 2022 06:41:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oTdtE-000885-9B for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Sep 2022 06:41:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTdtD-00087v-Bk for pgsql-hackers@lists.postgresql.org; Thu, 01 Sep 2022 06:41:23 +0000 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTdt6-0004l9-36 for pgsql-hackers@lists.postgresql.org; Thu, 01 Sep 2022 06:41:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1662014476; x=1693550476; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to; bh=+G1nAIFL7VfL0Ql+OdS7TovqTCdqotZabRI3BLpOn1Q=; b=bKTcaDxJyWj3TXdbXD9MD1MmP4txdFHPxn8S6JrIY5o7cpolOCS2WM1e j1clhYc6gNX/kXU2DW5SzXCDJdUhPl9YIwTbXllzttWROUHkvt5Umj0rJ CimFyUqJyaY/UhpGpwRGLaVBzhyzMKPezqrERqZY0hsIvkckr6cKvAhK8 E=; X-Amazon-filename: v4-0001-pgstat_drop_relation-for-indexes.patch Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-pdx-2b-02ee77e7.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2022 06:41:04 +0000 Received: from EX13D03EUC003.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2b-02ee77e7.us-west-2.amazon.com (Postfix) with ESMTPS id 6C1A544CE1; Thu, 1 Sep 2022 06:41:01 +0000 (UTC) Received: from [10.95.84.20] (10.43.161.228) by EX13D03EUC003.ant.amazon.com (10.43.164.192) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Thu, 1 Sep 2022 06:40:58 +0000 Content-Type: multipart/mixed; boundary="------------4iRwCBgbErg9Io3bAaixRCEe" Message-ID: <3cd209a4-e2a1-0ae6-91a3-c945eb7db248@amazon.com> Date: Thu, 1 Sep 2022 08:40:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: pg_stat_have_stats() returns true for dropped indexes (or for index creation transaction rolled back) Content-Language: en-US To: Andres Freund CC: Kyotaro Horiguchi , References: <51bbf286-2b4a-8998-bd12-eaae4b765d99@amazon.com> <20220822173654.y4h2smhc4kpkvoeg@awork3.anarazel.de> <61a95a06-cf88-cd15-0412-172717943e18@amazon.com> <20220825.114727.330127256246111733.horikyota.ntt@gmail.com> <20220831192657.jqhphpud2mxbzbom@awork3.anarazel.de> From: "Drouvot, Bertrand" In-Reply-To: <20220831192657.jqhphpud2mxbzbom@awork3.anarazel.de> X-Originating-IP: [10.43.161.228] X-ClientProxiedBy: EX13D46UWB001.ant.amazon.com (10.43.161.16) To EX13D03EUC003.ant.amazon.com (10.43.164.192) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --------------4iRwCBgbErg9Io3bAaixRCEe Content-Type: multipart/alternative; boundary="------------KSk4An0OWnFS87Br0qQaTPMN" --------------KSk4An0OWnFS87Br0qQaTPMN Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Hi, On 8/31/22 9:26 PM, Andres Freund wrote: > Hiu, > > On 2022-08-25 11:44:34 +0200, Drouvot, Bertrand wrote: >> For REPLSLOT, I agree that we can add one test: I added it in >> contrib/test_decoding/sql/stats.sql. It relies on pg_stat_have_stats() (as >> relying on pg_stat_replication_slots and/or pg_stat_get_replication_slot() >> would not help that much for this test given that the slot has been removed >> from ReplicationSlotCtl) > As Horiguchi-san noted, we can't rely on specific indexes being used. Yeah. > I feel > ok with the current coverage in that area, but if we *really* feel we need to > test it, we'd need to count the number of indexes with slots before dropping > the slot and after the drop. Thanks for the suggestion, I'm coming up with this proposal in v4 attached: * count the number of slots * ensure we have at least one for which pg_stat_have_stats() returns true * get the list of ids (true_ids) for which pg_stat_have_stats() returns true * drop all the slots * get the list of ids (false_ids) for which pg_stat_have_stats() returns false * ensure that both lists (true_ids and false_ids) are the same I don't "really" feel the need we need to test it but i think that this thread was a good opportunity to try to test it. That said, that's also fine for me if this test is not part of the patch. Maybe a better/simpler option could be to expose a function to get the slot id based on its name and then write a "simple" test with it? (If so I think that would better to start another patch/thread). >> +-- pg_stat_have_stats returns true for committed index creation > Maybe another test for an uncommitted index creation would be good too? You mean in addition to the "-- pg_stat_have_stats returns false for rolled back index creation" one? > Could you try running this test with debug_discard_caches = 1 - it's pretty > easy to write tests in this area that aren't reliable timing wise. Thanks for the suggestion. I did and it passed without any issues. >> +CREATE table stats_test_tab1 as select generate_series(1,10) a; >> +CREATE index stats_test_idx1 on stats_test_tab1(a); >> +SELECT oid AS dboid from pg_database where datname = current_database() \gset > Since you introduced this, maybe convert the other instance of this query at > the end of the file as well? yeah good point. In v4, I moved the dboid recording at the top and use it when appropriate. Regards, -- Bertrand Drouvot Amazon Web Services:https://aws.amazon.com --------------KSk4An0OWnFS87Br0qQaTPMN Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit

Hi,

On 8/31/22 9:26 PM, Andres Freund wrote:
Hiu,

On 2022-08-25 11:44:34 +0200, Drouvot, Bertrand wrote:
For REPLSLOT, I agree that we can add one test: I added it in
contrib/test_decoding/sql/stats.sql. It relies on pg_stat_have_stats() (as
relying on pg_stat_replication_slots and/or pg_stat_get_replication_slot()
would not help that much for this test given that the slot has been removed
from ReplicationSlotCtl)
As Horiguchi-san noted, we can't rely on specific indexes being used. 

Yeah.

I feel
ok with the current coverage in that area, but if we *really* feel we need to
test it, we'd need to count the number of indexes with slots before dropping
the slot and after the drop.

Thanks for the suggestion, I'm coming up with this proposal in v4 attached:

  • count the number of slots
  • ensure we have at least one for which pg_stat_have_stats() returns true
  • get the list of ids (true_ids) for which pg_stat_have_stats() returns true
  • drop all the slots
  • get the list of ids (false_ids) for which pg_stat_have_stats() returns false
  • ensure that both lists (true_ids and false_ids) are the same

I don't "really" feel the need we need to test it but i think that this thread was a good opportunity to try to test it.

That said, that's also fine for me if this test is not part of the patch.

Maybe a better/simpler option could be to expose a function to get the slot id based on its name and then write a "simple" test with it? (If so I think that would better to start another patch/thread).

+-- pg_stat_have_stats returns true for committed index creation
Maybe another test for an uncommitted index creation would be good too?

You mean in addition to the "-- pg_stat_have_stats returns false for rolled back index creation" one?

Could you try running this test with debug_discard_caches = 1 - it's pretty
easy to write tests in this area that aren't reliable timing wise.

Thanks for the suggestion. I did and it passed without any issues.

+CREATE table stats_test_tab1 as select generate_series(1,10) a;
+CREATE index stats_test_idx1 on stats_test_tab1(a);
+SELECT oid AS dboid from pg_database where datname = current_database() \gset
Since you introduced this, maybe convert the other instance of this query at
the end of the file as well?

yeah good point. In v4, I moved the dboid recording at the top and use it when appropriate.

Regards,

--
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com
--------------KSk4An0OWnFS87Br0qQaTPMN-- --------------4iRwCBgbErg9Io3bAaixRCEe Content-Type: text/plain; charset="UTF-8"; name="v4-0001-pgstat_drop_relation-for-indexes.patch" Content-Disposition: attachment; filename="v4-0001-pgstat_drop_relation-for-indexes.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9leHBlY3RlZC9zdGF0cy5vdXQg Yi9jb250cmliL3Rlc3RfZGVjb2RpbmcvZXhwZWN0ZWQvc3RhdHMub3V0CmluZGV4IDc4ZDM2 NDI5YzguLmZhMThmYmE3YmEgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9l eHBlY3RlZC9zdGF0cy5vdXQKKysrIGIvY29udHJpYi90ZXN0X2RlY29kaW5nL2V4cGVjdGVk L3N0YXRzLm91dApAQCAtMTM5LDYgKzEzOSwxOSBAQCBTRUxFQ1Qgc2xvdF9uYW1lIEZST00g cGdfc3RhdF9yZXBsaWNhdGlvbl9zbG90czsKIAogQ09NTUlUOwogRFJPUCBUQUJMRSBzdGF0 c190ZXN0OworLS0gQ291bnQgdGhlIG51bWJlciBvZiBzbG90cworc2VsZWN0IGNvdW50KDEp IGFzIG5iX3Nsb3RzIGZyb20gcGdfc3RhdF9yZXBsaWNhdGlvbl9zbG90cyBcZ3NldAorLS0g V2Ugd2FudCBwZ19zdGF0X2hhdmVfc3RhdHMoKSB0byByZXR1cm4gdHJ1ZSBhdCBsZWFzdCBv bmUgdGltZSBmb3IgdGhlIHNsb3RzIGlkIHJhbmdlCitzZWxlY3QgY291bnQoMSkgPiAwIGZy b20gZ2VuZXJhdGVfc2VyaWVzKDAsIDpuYl9zbG90cyAtIDEpIGFzIG4gd2hlcmUgcGdfc3Rh dF9oYXZlX3N0YXRzKCdyZXBsc2xvdCcsIDAsIG4pOworID9jb2x1bW4/IAorLS0tLS0tLS0t LQorIHQKKygxIHJvdykKKworLS0gUmVjb3JkIHRoZSByZXBsaWNhdGlvbl9zbG90cyBpZChz KSBmb3Igd2hpY2ggcGdfc3RhdF9oYXZlX3N0YXRzKCkgcmV0dXJucyB0cnVlCitzZWxlY3Qg YXJyYXkoc2VsZWN0IG4gZnJvbSBnZW5lcmF0ZV9zZXJpZXMoMCwgOm5iX3Nsb3RzIC0gMSkg YXMgbiB3aGVyZSBwZ19zdGF0X2hhdmVfc3RhdHMoJ3JlcGxzbG90JywgMCwgbikgb3JkZXIg YnkgbiBhc2MpIGFzIHRydWVfaWRzIFxnc2V0Citcc2V0IHRydWVfaWRzICcnJycgOnRydWVf aWRzICcnJycKKy0tIERyb3AgdGhlIDMgc2xvdHMKIFNFTEVDVCBwZ19kcm9wX3JlcGxpY2F0 aW9uX3Nsb3QoJ3JlZ3Jlc3Npb25fc2xvdF9zdGF0czEnKSwKICAgICBwZ19kcm9wX3JlcGxp Y2F0aW9uX3Nsb3QoJ3JlZ3Jlc3Npb25fc2xvdF9zdGF0czInKSwKICAgICBwZ19kcm9wX3Jl cGxpY2F0aW9uX3Nsb3QoJ3JlZ3Jlc3Npb25fc2xvdF9zdGF0czMnKTsKQEAgLTE0NywzICsx NjAsMTIgQEAgU0VMRUNUIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xvdCgncmVncmVzc2lvbl9z bG90X3N0YXRzMScpLAogICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgICAgICAgICAg ICAgICAgICAgICAgICB8IAogKDEgcm93KQogCistLSBXZSB3YW50IHRoZSBvbmVzIHRoYXQg d2VyZSB0cnVlIHRvIGJlIGZhbHNlIGFmdGVyIGRyb3BwaW5nIHRoZSBzbG90cworc2VsZWN0 IGFycmF5KHNlbGVjdCBuIGZyb20gZ2VuZXJhdGVfc2VyaWVzKDAsIDpuYl9zbG90cyAtIDEp IGFzIG4gd2hlcmUgbm90IHBnX3N0YXRfaGF2ZV9zdGF0cygncmVwbHNsb3QnLCAwLCBuKSBv cmRlciBieSBuIGFzYykgYXMgZmFsc2VfaWRzIFxnc2V0Citcc2V0IGZhbHNlX2lkcyAnJycn IDpmYWxzZV9pZHMgJycnJworc2VsZWN0IDp0cnVlX2lkcyA9IDpmYWxzZV9pZHM7CisgP2Nv bHVtbj8gCistLS0tLS0tLS0tCisgdAorKDEgcm93KQorCmRpZmYgLS1naXQgYS9jb250cmli L3Rlc3RfZGVjb2Rpbmcvc3FsL3N0YXRzLnNxbCBiL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9z cWwvc3RhdHMuc3FsCmluZGV4IDYzMDM3MWYxNDcuLmZmYjAyMWY3NmQgMTAwNjQ0Ci0tLSBh L2NvbnRyaWIvdGVzdF9kZWNvZGluZy9zcWwvc3RhdHMuc3FsCisrKyBiL2NvbnRyaWIvdGVz dF9kZWNvZGluZy9zcWwvc3RhdHMuc3FsCkBAIC01MSw2ICs1MSwyMyBAQCBTRUxFQ1Qgc2xv dF9uYW1lIEZST00gcGdfc3RhdF9yZXBsaWNhdGlvbl9zbG90czsKIENPTU1JVDsKIAogRFJP UCBUQUJMRSBzdGF0c190ZXN0OworCistLSBDb3VudCB0aGUgbnVtYmVyIG9mIHNsb3RzCitz ZWxlY3QgY291bnQoMSkgYXMgbmJfc2xvdHMgZnJvbSBwZ19zdGF0X3JlcGxpY2F0aW9uX3Ns b3RzIFxnc2V0CisKKy0tIFdlIHdhbnQgcGdfc3RhdF9oYXZlX3N0YXRzKCkgdG8gcmV0dXJu IHRydWUgYXQgbGVhc3Qgb25lIHRpbWUgZm9yIHRoZSBzbG90cyBpZCByYW5nZQorc2VsZWN0 IGNvdW50KDEpID4gMCBmcm9tIGdlbmVyYXRlX3NlcmllcygwLCA6bmJfc2xvdHMgLSAxKSBh cyBuIHdoZXJlIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVwbHNsb3QnLCAwLCBuKTsKKworLS0g UmVjb3JkIHRoZSByZXBsaWNhdGlvbl9zbG90cyBpZChzKSBmb3Igd2hpY2ggcGdfc3RhdF9o YXZlX3N0YXRzKCkgcmV0dXJucyB0cnVlCitzZWxlY3QgYXJyYXkoc2VsZWN0IG4gZnJvbSBn ZW5lcmF0ZV9zZXJpZXMoMCwgOm5iX3Nsb3RzIC0gMSkgYXMgbiB3aGVyZSBwZ19zdGF0X2hh dmVfc3RhdHMoJ3JlcGxzbG90JywgMCwgbikgb3JkZXIgYnkgbiBhc2MpIGFzIHRydWVfaWRz IFxnc2V0Citcc2V0IHRydWVfaWRzICcnJycgOnRydWVfaWRzICcnJycKKworLS0gRHJvcCB0 aGUgMyBzbG90cwogU0VMRUNUIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xvdCgncmVncmVzc2lv bl9zbG90X3N0YXRzMScpLAogICAgIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xvdCgncmVncmVz c2lvbl9zbG90X3N0YXRzMicpLAogICAgIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xvdCgncmVn cmVzc2lvbl9zbG90X3N0YXRzMycpOworCistLSBXZSB3YW50IHRoZSBvbmVzIHRoYXQgd2Vy ZSB0cnVlIHRvIGJlIGZhbHNlIGFmdGVyIGRyb3BwaW5nIHRoZSBzbG90cworc2VsZWN0IGFy cmF5KHNlbGVjdCBuIGZyb20gZ2VuZXJhdGVfc2VyaWVzKDAsIDpuYl9zbG90cyAtIDEpIGFz IG4gd2hlcmUgbm90IHBnX3N0YXRfaGF2ZV9zdGF0cygncmVwbHNsb3QnLCAwLCBuKSBvcmRl ciBieSBuIGFzYykgYXMgZmFsc2VfaWRzIFxnc2V0Citcc2V0IGZhbHNlX2lkcyAnJycnIDpm YWxzZV9pZHMgJycnJworc2VsZWN0IDp0cnVlX2lkcyA9IDpmYWxzZV9pZHM7ClwgTm8gbmV3 bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9o ZWFwLmMgYi9zcmMvYmFja2VuZC9jYXRhbG9nL2hlYXAuYwppbmRleCA5YjAzNTc5ZTZlLi45 YTgwY2NkY2NkIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jYXRhbG9nL2hlYXAuYworKysg Yi9zcmMvYmFja2VuZC9jYXRhbG9nL2hlYXAuYwpAQCAtNDAzLDYgKzQwMyw5IEBAIGhlYXBf Y3JlYXRlKGNvbnN0IGNoYXIgKnJlbG5hbWUsCiAJCXJlY29yZERlcGVuZGVuY3lPblRhYmxl c3BhY2UoUmVsYXRpb25SZWxhdGlvbklkLCByZWxpZCwKIAkJCQkJCQkJCSByZWx0YWJsZXNw YWNlKTsKIAorCS8qIGVuc3VyZSB0aGF0IHN0YXRzIGFyZSBkcm9wcGVkIGlmIHRyYW5zYWN0 aW9uIGFib3J0cyAqLworCXBnc3RhdF9jcmVhdGVfcmVsYXRpb24ocmVsKTsKKwogCXJldHVy biByZWw7CiB9CiAKQEAgLTE0NzcsOSArMTQ4MCw2IEBAIGhlYXBfY3JlYXRlX3dpdGhfY2F0 YWxvZyhjb25zdCBjaGFyICpyZWxuYW1lLAogCWlmIChvbmNvbW1pdCAhPSBPTkNPTU1JVF9O T09QKQogCQlyZWdpc3Rlcl9vbl9jb21taXRfYWN0aW9uKHJlbGlkLCBvbmNvbW1pdCk7CiAK LQkvKiBlbnN1cmUgdGhhdCBzdGF0cyBhcmUgZHJvcHBlZCBpZiB0cmFuc2FjdGlvbiBhYm9y dHMgKi8KLQlwZ3N0YXRfY3JlYXRlX3JlbGF0aW9uKG5ld19yZWxfZGVzYyk7Ci0KIAkvKgog CSAqIG9rLCB0aGUgcmVsYXRpb24gaGFzIGJlZW4gY2F0YWxvZ2VkLCBzbyBjbG9zZSBvdXIg cmVsYXRpb25zIGFuZCByZXR1cm4KIAkgKiB0aGUgT0lEIG9mIHRoZSBuZXdseSBjcmVhdGVk IHJlbGF0aW9uLgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9pbmRleC5jIGIv c3JjL2JhY2tlbmQvY2F0YWxvZy9pbmRleC5jCmluZGV4IGQ3MTkyZjM1ZTMuLjYxZjFkMzky NmEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvaW5kZXguYworKysgYi9zcmMv YmFja2VuZC9jYXRhbG9nL2luZGV4LmMKQEAgLTIzMjUsNiArMjMyNSw5IEBAIGluZGV4X2Ry b3AoT2lkIGluZGV4SWQsIGJvb2wgY29uY3VycmVudCwgYm9vbCBjb25jdXJyZW50X2xvY2tf bW9kZSkKIAlpZiAoUkVMS0lORF9IQVNfU1RPUkFHRSh1c2VySW5kZXhSZWxhdGlvbi0+cmRf cmVsLT5yZWxraW5kKSkKIAkJUmVsYXRpb25Ecm9wU3RvcmFnZSh1c2VySW5kZXhSZWxhdGlv bik7CiAKKwkvKiBlbnN1cmUgdGhhdCBzdGF0cyBhcmUgZHJvcHBlZCBpZiB0cmFuc2FjdGlv biBjb21taXRzICovCisJcGdzdGF0X2Ryb3BfcmVsYXRpb24odXNlckluZGV4UmVsYXRpb24p OworCiAJLyoKIAkgKiBDbG9zZSBhbmQgZmx1c2ggdGhlIGluZGV4J3MgcmVsY2FjaGUgZW50 cnksIHRvIGVuc3VyZSByZWxjYWNoZSBkb2Vzbid0CiAJICogdHJ5IHRvIHJlYnVpbGQgaXQg d2hpbGUgd2UncmUgZGVsZXRpbmcgY2F0YWxvZyBlbnRyaWVzLiBXZSBrZWVwIHRoZQpkaWZm IC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQgYi9zcmMvdGVz dC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dAppbmRleCA2YjIzM2ZmNGMwLi5mYTBhMmM2 ZjdhIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dAor KysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dApAQCAtMTgsNiArMTgs OCBAQCBTRVQgZW5hYmxlX2luZGV4c2NhbiBUTyBvbjsKIFNFVCBlbmFibGVfaW5kZXhvbmx5 c2NhbiBUTyBvZmY7CiAtLSBub3QgZW5hYmxlZCBieSBkZWZhdWx0LCBidXQgd2Ugd2FudCB0 byB0ZXN0IGl0Li4uCiBTRVQgdHJhY2tfZnVuY3Rpb25zIFRPICdhbGwnOworLS0gcmVjb3Jk IGRib2lkIGZvciBsYXRlciB1c2UKK1NFTEVDVCBvaWQgQVMgZGJvaWQgZnJvbSBwZ19kYXRh YmFzZSB3aGVyZSBkYXRuYW1lID0gY3VycmVudF9kYXRhYmFzZSgpIFxnc2V0CiAtLSBzYXZl IGNvdW50ZXJzCiBCRUdJTjsKIFNFVCBMT0NBTCBzdGF0c19mZXRjaF9jb25zaXN0ZW5jeSA9 IHNuYXBzaG90OwpAQCAtNzcxLDE4ICs3NzMsMTIxIEBAIFNFTEVDVCBwZ19zdGF0X2hhdmVf c3RhdHMoJ2Jnd3JpdGVyJywgMCwgMCk7CiBTRUxFQ1QgcGdfc3RhdF9oYXZlX3N0YXRzKCd6 YXBob2QnLCAwLCAwKTsKIEVSUk9SOiAgaW52YWxpZCBzdGF0aXN0aWNzIGtpbmQ6ICJ6YXBo b2QiCiAtLSBkYiBzdGF0cyBoYXZlIG9iam9pZCAwCi1TRUxFQ1QgcGdfc3RhdF9oYXZlX3N0 YXRzKCdkYXRhYmFzZScsIChTRUxFQ1Qgb2lkIEZST00gcGdfZGF0YWJhc2UgV0hFUkUgZGF0 bmFtZSA9IGN1cnJlbnRfZGF0YWJhc2UoKSksIDEpOworU0VMRUNUIHBnX3N0YXRfaGF2ZV9z dGF0cygnZGF0YWJhc2UnLCA6ZGJvaWQsIDEpOwogIHBnX3N0YXRfaGF2ZV9zdGF0cyAKIC0t LS0tLS0tLS0tLS0tLS0tLS0tCiAgZgogKDEgcm93KQogCi1TRUxFQ1QgcGdfc3RhdF9oYXZl X3N0YXRzKCdkYXRhYmFzZScsIChTRUxFQ1Qgb2lkIEZST00gcGdfZGF0YWJhc2UgV0hFUkUg ZGF0bmFtZSA9IGN1cnJlbnRfZGF0YWJhc2UoKSksIDApOworU0VMRUNUIHBnX3N0YXRfaGF2 ZV9zdGF0cygnZGF0YWJhc2UnLCA6ZGJvaWQsIDApOwogIHBnX3N0YXRfaGF2ZV9zdGF0cyAK IC0tLS0tLS0tLS0tLS0tLS0tLS0tCiAgdAogKDEgcm93KQogCistLSBwZ19zdGF0X2hhdmVf c3RhdHMgcmV0dXJucyB0cnVlIGZvciBjb21taXR0ZWQgaW5kZXggY3JlYXRpb24KK0NSRUFU RSB0YWJsZSBzdGF0c190ZXN0X3RhYjEgYXMgc2VsZWN0IGdlbmVyYXRlX3NlcmllcygxLDEw KSBhOworQ1JFQVRFIGluZGV4IHN0YXRzX3Rlc3RfaWR4MSBvbiBzdGF0c190ZXN0X3RhYjEo YSk7CitTRUxFQ1QgJ3N0YXRzX3Rlc3RfaWR4MSc6OnJlZ2NsYXNzOjpvaWQgQVMgc3RhdHNf dGVzdF9pZHgxX29pZCBcZ3NldAorU0VUIGVuYWJsZV9zZXFzY2FuIFRPIG9mZjsKK3NlbGVj dCBhIGZyb20gc3RhdHNfdGVzdF90YWIxIHdoZXJlIGEgPSAzOworIGEgCistLS0KKyAzCiso MSByb3cpCisKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lk LCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7CisgcGdfc3RhdF9oYXZlX3N0YXRzIAorLS0tLS0t LS0tLS0tLS0tLS0tLS0KKyB0CisoMSByb3cpCisKKy0tIHBnX3N0YXRfaGF2ZV9zdGF0cyBy ZXR1cm5zIGZhbHNlIGZvciBkcm9wcGVkIGluZGV4IHdpdGggc3RhdHMKK1NFTEVDVCBwZ19z dGF0X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29p ZCk7CisgcGdfc3RhdF9oYXZlX3N0YXRzIAorLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyB0Ciso MSByb3cpCisKK0RST1AgaW5kZXggc3RhdHNfdGVzdF9pZHgxOworU0VMRUNUIHBnX3N0YXRf aGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsK KyBwZ19zdGF0X2hhdmVfc3RhdHMgCistLS0tLS0tLS0tLS0tLS0tLS0tLQorIGYKKygxIHJv dykKKworLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJldHVybnMgZmFsc2UgZm9yIHJvbGxlZCBi YWNrIGluZGV4IGNyZWF0aW9uCitCRUdJTjsKK0NSRUFURSBpbmRleCBzdGF0c190ZXN0X2lk eDEgb24gc3RhdHNfdGVzdF90YWIxKGEpOworU0VMRUNUICdzdGF0c190ZXN0X2lkeDEnOjpy ZWdjbGFzczo6b2lkIEFTIHN0YXRzX3Rlc3RfaWR4MV9vaWQgXGdzZXQKK3NlbGVjdCBhIGZy b20gc3RhdHNfdGVzdF90YWIxIHdoZXJlIGEgPSAzOworIGEgCistLS0KKyAzCisoMSByb3cp CisKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6c3Rh dHNfdGVzdF9pZHgxX29pZCk7CisgcGdfc3RhdF9oYXZlX3N0YXRzIAorLS0tLS0tLS0tLS0t LS0tLS0tLS0KKyB0CisoMSByb3cpCisKK1JPTExCQUNLOworU0VMRUNUIHBnX3N0YXRfaGF2 ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsKKyBw Z19zdGF0X2hhdmVfc3RhdHMgCistLS0tLS0tLS0tLS0tLS0tLS0tLQorIGYKKygxIHJvdykK KworLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJldHVybnMgdHJ1ZSBmb3IgcmVpbmRleCBDT05D VVJSRU5UTFkKK0NSRUFURSBpbmRleCBzdGF0c190ZXN0X2lkeDEgb24gc3RhdHNfdGVzdF90 YWIxKGEpOworU0VMRUNUICdzdGF0c190ZXN0X2lkeDEnOjpyZWdjbGFzczo6b2lkIEFTIHN0 YXRzX3Rlc3RfaWR4MV9vaWQgXGdzZXQKK3NlbGVjdCBhIGZyb20gc3RhdHNfdGVzdF90YWIx IHdoZXJlIGEgPSAzOworIGEgCistLS0KKyAzCisoMSByb3cpCisKK1NFTEVDVCBwZ19zdGF0 X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7 CisgcGdfc3RhdF9oYXZlX3N0YXRzIAorLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyB0CisoMSBy b3cpCisKK1JFSU5ERVggaW5kZXggQ09OQ1VSUkVOVExZIHN0YXRzX3Rlc3RfaWR4MTsKKy0t IGZhbHNlIGZvciBwcmV2aW91cyBvaWQKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3Jl bGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7CisgcGdfc3RhdF9oYXZl X3N0YXRzIAorLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyBmCisoMSByb3cpCisKKy0tIHRydWUg Zm9yIG5ldyBvaWQKK1NFTEVDVCAnc3RhdHNfdGVzdF9pZHgxJzo6cmVnY2xhc3M6Om9pZCBB UyBzdGF0c190ZXN0X2lkeDFfb2lkIFxnc2V0CitTRUxFQ1QgcGdfc3RhdF9oYXZlX3N0YXRz KCdyZWxhdGlvbicsIDpkYm9pZCwgOnN0YXRzX3Rlc3RfaWR4MV9vaWQpOworIHBnX3N0YXRf aGF2ZV9zdGF0cyAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tCisgdAorKDEgcm93KQorCistLSBw Z19zdGF0X2hhdmVfc3RhdHMgcmV0dXJucyB0cnVlIGZvciBhIHJvbGxlZCBiYWNrIGRyb3Ag aW5kZXggd2l0aCBzdGF0cworQkVHSU47CitTRUxFQ1QgcGdfc3RhdF9oYXZlX3N0YXRzKCdy ZWxhdGlvbicsIDpkYm9pZCwgOnN0YXRzX3Rlc3RfaWR4MV9vaWQpOworIHBnX3N0YXRfaGF2 ZV9zdGF0cyAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tCisgdAorKDEgcm93KQorCitEUk9QIGlu ZGV4IHN0YXRzX3Rlc3RfaWR4MTsKK1JPTExCQUNLOworU0VMRUNUIHBnX3N0YXRfaGF2ZV9z dGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsKKyBwZ19z dGF0X2hhdmVfc3RhdHMgCistLS0tLS0tLS0tLS0tLS0tLS0tLQorIHQKKygxIHJvdykKKwor LS0gcHV0IGVuYWJsZV9zZXFzY2FuIGJhY2sgdG8gb24KK1NFVCBlbmFibGVfc2Vxc2NhbiBU TyBvbjsKIC0tIGVuc3VyZSB0aGF0IHN0YXRzIGFjY2Vzc29ycyBoYW5kbGUgTlVMTCBpbnB1 dCBjb3JyZWN0bHkKIFNFTEVDVCBwZ19zdGF0X2dldF9yZXBsaWNhdGlvbl9zbG90KE5VTEwp OwogIHBnX3N0YXRfZ2V0X3JlcGxpY2F0aW9uX3Nsb3QgCmRpZmYgLS1naXQgYS9zcmMvdGVz dC9yZWdyZXNzL3NxbC9zdGF0cy5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9zdGF0cy5z cWwKaW5kZXggMDk2ZjAwY2U4Yi4uYTYzYmRlOWU2NyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3Qv cmVncmVzcy9zcWwvc3RhdHMuc3FsCisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3N0YXRz LnNxbApAQCAtMTYsNiArMTYsOSBAQCBTRVQgZW5hYmxlX2luZGV4b25seXNjYW4gVE8gb2Zm OwogLS0gbm90IGVuYWJsZWQgYnkgZGVmYXVsdCwgYnV0IHdlIHdhbnQgdG8gdGVzdCBpdC4u LgogU0VUIHRyYWNrX2Z1bmN0aW9ucyBUTyAnYWxsJzsKIAorLS0gcmVjb3JkIGRib2lkIGZv ciBsYXRlciB1c2UKK1NFTEVDVCBvaWQgQVMgZGJvaWQgZnJvbSBwZ19kYXRhYmFzZSB3aGVy ZSBkYXRuYW1lID0gY3VycmVudF9kYXRhYmFzZSgpIFxnc2V0CisKIC0tIHNhdmUgY291bnRl cnMKIEJFR0lOOwogU0VUIExPQ0FMIHN0YXRzX2ZldGNoX2NvbnNpc3RlbmN5ID0gc25hcHNo b3Q7CkBAIC0zODcsOSArMzkwLDUyIEBAIFNFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ2Jn d3JpdGVyJywgMCwgMCk7CiAtLSB1bmtub3duIHN0YXRzIGtpbmRzIGVycm9yIG91dAogU0VM RUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygnemFwaG9kJywgMCwgMCk7CiAtLSBkYiBzdGF0cyBo YXZlIG9iam9pZCAwCi1TRUxFQ1QgcGdfc3RhdF9oYXZlX3N0YXRzKCdkYXRhYmFzZScsIChT RUxFQ1Qgb2lkIEZST00gcGdfZGF0YWJhc2UgV0hFUkUgZGF0bmFtZSA9IGN1cnJlbnRfZGF0 YWJhc2UoKSksIDEpOwotU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygnZGF0YWJhc2UnLCAo U0VMRUNUIG9pZCBGUk9NIHBnX2RhdGFiYXNlIFdIRVJFIGRhdG5hbWUgPSBjdXJyZW50X2Rh dGFiYXNlKCkpLCAwKTsKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ2RhdGFiYXNlJywg OmRib2lkLCAxKTsKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ2RhdGFiYXNlJywgOmRi b2lkLCAwKTsKKworLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJldHVybnMgdHJ1ZSBmb3IgY29t bWl0dGVkIGluZGV4IGNyZWF0aW9uCitDUkVBVEUgdGFibGUgc3RhdHNfdGVzdF90YWIxIGFz IHNlbGVjdCBnZW5lcmF0ZV9zZXJpZXMoMSwxMCkgYTsKK0NSRUFURSBpbmRleCBzdGF0c190 ZXN0X2lkeDEgb24gc3RhdHNfdGVzdF90YWIxKGEpOworU0VMRUNUICdzdGF0c190ZXN0X2lk eDEnOjpyZWdjbGFzczo6b2lkIEFTIHN0YXRzX3Rlc3RfaWR4MV9vaWQgXGdzZXQKK1NFVCBl bmFibGVfc2Vxc2NhbiBUTyBvZmY7CitzZWxlY3QgYSBmcm9tIHN0YXRzX3Rlc3RfdGFiMSB3 aGVyZSBhID0gMzsKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRi b2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7CisKKy0tIHBnX3N0YXRfaGF2ZV9zdGF0cyBy ZXR1cm5zIGZhbHNlIGZvciBkcm9wcGVkIGluZGV4IHdpdGggc3RhdHMKK1NFTEVDVCBwZ19z dGF0X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29p ZCk7CitEUk9QIGluZGV4IHN0YXRzX3Rlc3RfaWR4MTsKK1NFTEVDVCBwZ19zdGF0X2hhdmVf c3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7CisKKy0t IHBnX3N0YXRfaGF2ZV9zdGF0cyByZXR1cm5zIGZhbHNlIGZvciByb2xsZWQgYmFjayBpbmRl eCBjcmVhdGlvbgorQkVHSU47CitDUkVBVEUgaW5kZXggc3RhdHNfdGVzdF9pZHgxIG9uIHN0 YXRzX3Rlc3RfdGFiMShhKTsKK1NFTEVDVCAnc3RhdHNfdGVzdF9pZHgxJzo6cmVnY2xhc3M6 Om9pZCBBUyBzdGF0c190ZXN0X2lkeDFfb2lkIFxnc2V0CitzZWxlY3QgYSBmcm9tIHN0YXRz X3Rlc3RfdGFiMSB3aGVyZSBhID0gMzsKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3Jl bGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7CitST0xMQkFDSzsKK1NF TEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVz dF9pZHgxX29pZCk7CisKKy0tIHBnX3N0YXRfaGF2ZV9zdGF0cyByZXR1cm5zIHRydWUgZm9y IHJlaW5kZXggQ09OQ1VSUkVOVExZCitDUkVBVEUgaW5kZXggc3RhdHNfdGVzdF9pZHgxIG9u IHN0YXRzX3Rlc3RfdGFiMShhKTsKK1NFTEVDVCAnc3RhdHNfdGVzdF9pZHgxJzo6cmVnY2xh c3M6Om9pZCBBUyBzdGF0c190ZXN0X2lkeDFfb2lkIFxnc2V0CitzZWxlY3QgYSBmcm9tIHN0 YXRzX3Rlc3RfdGFiMSB3aGVyZSBhID0gMzsKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMo J3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7CitSRUlOREVYIGlu ZGV4IENPTkNVUlJFTlRMWSBzdGF0c190ZXN0X2lkeDE7CistLSBmYWxzZSBmb3IgcHJldmlv dXMgb2lkCitTRUxFQ1QgcGdfc3RhdF9oYXZlX3N0YXRzKCdyZWxhdGlvbicsIDpkYm9pZCwg OnN0YXRzX3Rlc3RfaWR4MV9vaWQpOworLS0gdHJ1ZSBmb3IgbmV3IG9pZAorU0VMRUNUICdz dGF0c190ZXN0X2lkeDEnOjpyZWdjbGFzczo6b2lkIEFTIHN0YXRzX3Rlc3RfaWR4MV9vaWQg XGdzZXQKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6 c3RhdHNfdGVzdF9pZHgxX29pZCk7CisKKy0tIHBnX3N0YXRfaGF2ZV9zdGF0cyByZXR1cm5z IHRydWUgZm9yIGEgcm9sbGVkIGJhY2sgZHJvcCBpbmRleCB3aXRoIHN0YXRzCitCRUdJTjsK K1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNf dGVzdF9pZHgxX29pZCk7CitEUk9QIGluZGV4IHN0YXRzX3Rlc3RfaWR4MTsKK1JPTExCQUNL OworU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0 c190ZXN0X2lkeDFfb2lkKTsKIAorLS0gcHV0IGVuYWJsZV9zZXFzY2FuIGJhY2sgdG8gb24K K1NFVCBlbmFibGVfc2Vxc2NhbiBUTyBvbjsKIAogLS0gZW5zdXJlIHRoYXQgc3RhdHMgYWNj ZXNzb3JzIGhhbmRsZSBOVUxMIGlucHV0IGNvcnJlY3RseQogU0VMRUNUIHBnX3N0YXRfZ2V0 X3JlcGxpY2F0aW9uX3Nsb3QoTlVMTCk7Cg== --------------4iRwCBgbErg9Io3bAaixRCEe--