public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andrey Silitskiy <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Takamichi Osumi (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Greg Sabino Mullane <[email protected]>
Cc: Vitaly Davydov <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Subject: Re: Exit walsender before confirming remote flush in logical replication
Date: Sat, 17 Jan 2026 23:20:46 +0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwFk51nAFs20-dq2SLONdeyhYcvDQb_jZiPiJt5Rinb8Ug@mail.gmail.com>
References: <TYAPR01MB58661D0EDEEDDA284226D401F5DB9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<[email protected]>
	<TYAPR01MB5866A7B6E1C897586F09377DF5D89@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<TYAPR01MB586649A34F241798B206FFF5F5D89@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<TYCPR01MB83733C978995A05389F51E3BEDD99@TYCPR01MB8373.jpnprd01.prod.outlook.com>
	<TYAPR01MB586683FC450662990E356A0EF5D99@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<CAHut+PtDhN6JBHJmmeU4U-0hWf106AV39bRjcS7UuqTBtdXQCg@mail.gmail.com>
	<TYAPR01MB5866BE7EA26E20A6D19B2297F5DE9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<[email protected]>
	<CAHGQGwEnb0-tZG8K2mVSbjzJ=Z_VFbjAypO+fYm0t1ZXaxbr0A@mail.gmail.com>
	<[email protected]>
	<CAHGQGwFHJ-80uwd8jgSsm9ZL_HBvi5SXa6O6nktXiOicxHKKxQ@mail.gmail.com>
	<[email protected]>
	<CAHGQGwFk51nAFs20-dq2SLONdeyhYcvDQb_jZiPiJt5Rinb8Ug@mail.gmail.com>

On Jan 9, 2026 at 10:04 AM Fujii Masao
<masao(dot)fujii(at)gmail(dot)com> wrote:
 > Why do we need to send a "done" message to the receiver here?
 > Since delivery isn't guaranteed in immediate mode, it seems of limited
 > value.

It seems to me that it is better to send a message in cases where it is
possible, soas notto raiseerrorsonthe subscriberduringa cleanshutdown.
And when this is not possible, exit the process without waiting.

 > For the immediate mode, would it make sense to log that the walsender is
 > terminating in immediate mode and that WAL replication may be incomplete,
 > so users can more easily understand what happened?

Added to the latest patch.

Regards,
Andrey Silitskiy

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Exit walsender before confirming remote flush in logical replication
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox