Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h15A2-0006ig-K6
	for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Mar 2019 08:10:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h15A1-0003NJ-2C
	for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Mar 2019 08:10:49 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <david@pgmasters.net>)
	id 1h15A0-0003N0-Nn
	for pgsql-hackers@lists.postgresql.org; Tue, 05 Mar 2019 08:10:48 +0000
Received: from mail.thelabyrinth.net ([45.56.70.56])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <david@pgmasters.net>)
	id 1h159y-0004M0-Ih
	for pgsql-hackers@lists.postgresql.org; Tue, 05 Mar 2019 08:10:47 +0000
Received: from Davids-MacBook.local (unknown [208.54.86.153])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: dsteele)
	by mail.thelabyrinth.net (Postfix) with ESMTPSA id 848A75466C;
	Tue,  5 Mar 2019 08:10:44 +0000 (UTC)
Subject: Re: Re: [PATCH] pgbench tap tests fail if the path contains a perl
 special character
To: =?UTF-8?B?UmHDumwgTWFyw61u?= <git@rmr.ninja>,
 pgsql-hackers@lists.postgresql.org
Cc: Fabien Coelho <postgresql.org@coelho.net>
References: 
 <CAM6_UM6dGdU39PKAC24T+HD9ouy0jLN9vH6163K8QEEzr__iZw@mail.gmail.com>
 <410FDA9D-61D6-4A95-A8EC-BCE6F48654FD@yesql.se>
 <154963265100.11785.6687612388485567052.pgcf@coridan.postgresql.org>
From: David Steele <david@pgmasters.net>
Message-ID: <3d24b3cc-0c76-8338-0e70-c3f9689ff00d@pgmasters.net>
Date: Tue, 5 Mar 2019 10:10:36 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: 
 <154963265100.11785.6687612388485567052.pgcf@coridan.postgresql.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2/8/19 3:30 PM, Raúl Marín wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, failed
> Implements feature:       not tested
> Spec compliant:           not tested
> Documentation:            not tested
> 
> Tested `pgbench-tap-glob-fix-1.patch` with a "+" in the path and the tap tests now pass.

Is this now ready for committer or is there anything else Fabien needs 
to do?

Marking the patch as either Ready for Committer or Waiting on Author 
will help move things along.

Regards,
-- 
-David
david@pgmasters.net