Content-Type: multipart/alternative;
 boundary="------------3fVHEvJE8puE09IcPxFvsa5W"
Message-ID: <3d418931-51c0-47bb-9f78-cd4270a29c5c@postgrespro.ru>
Date: Mon, 16 Sep 2024 05:53:47 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
To: Andrei Lepikhov <lepihov@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Nikolay Shaplov
 <dhyan@nataraj.su>, pgsql-hackers@lists.postgresql.org,
 Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org,
 Peter Geoghegan <pg@bowt.ie>, Marcos Pegoraro <marcos@f10.com.br>,
 teodor@sigaev.ru, Peter Eisentraut <peter@eisentraut.org>,
 Ranier Vilela <ranier.vf@gmail.com>
References: <567ED6CA.2040504@sigaev.ru>
 <cf2c669f-93ec-4e35-a521-cecac67def73@postgrespro.ru>
 <CAPpHfduTM2W3kmiN1=5fvgcu6yA5=ghq82OkvLvZC8Mh9PpEuA@mail.gmail.com>
 <c3c490e2-1f04-420b-bd5c-f4840d6a7198@postgrespro.ru>
 <e657e536-f10b-4131-a3f2-667c73c86588@postgrespro.ru>
 <CAPpHfduFJHTNGCTFWt4GFs-E6Ts8xS5mCsKOYKBsZAmoOr8ZSA@mail.gmail.com>
 <65bfdcb6-0f0c-4d4c-a721-cb38a0ba91c7@postgrespro.ru>
 <CAPpHfdtR3cBKCSj_7dd7EDF_pa-rUUQBx3-guK6kZZ=_hSeMfg@mail.gmail.com>
 <670d1dc2-a280-4cf6-bc29-e2eafb107081@gmail.com>
 <CAPpHfdvF864n=Lzmjd2XBi9TwboZvrhRtLSt2hCP+JVUv6XKzg@mail.gmail.com>
 <CACJufxHCJvC3X8nUK-jRvRru-ZEXp16EBPADOwTGaqmOYM1Raw@mail.gmail.com>
 <fe11e5c9-877e-4306-a6a9-122125c7d2e5@postgrespro.ru>
 <93464dd6-d484-4021-b71f-e82928bf6758@gmail.com>
 <63617a30-6078-4e86-b44b-6364e04e210d@postgrespro.ru>
 <21752e9e-26fb-4665-bfcc-090bf4093e5a@postgrespro.ru>
 <CAPpHfduBA9RXa1LQAz=wFK8cGx_AaHVK_vnNqCnG4yA7KwFf7g@mail.gmail.com>
Content-Language: en-US
From: Alena Rybakina <a.rybakina@postgrespro.ru>
In-Reply-To: <CAPpHfduBA9RXa1LQAz=wFK8cGx_AaHVK_vnNqCnG4yA7KwFf7g@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/3d418931-51c0-47bb-9f78-cd4270a29c5c%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------3fVHEvJE8puE09IcPxFvsa5W
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi!

On 09.09.2024 13:36, Alexander Korotkov wrote:
> On Wed, Sep 4, 2024 at 6:42 PM Alena Rybakina<a.rybakina@postgrespro.ru>  wrote:
>> On 04.09.2024 18:31, Alena Rybakina wrote:
>>> I rewrote the tests with integer types. Thanks for your suggestion. If
>>> you don't mind, I've updated the diff file you attached earlier to
>>> include the tests.
>> Sorry, I've just noticed that one of your changes with the regression
>> test wasn't included. I fixed it here.
> Please, find the revised patchset attached.  I've integrated the fixes
> by you and Andrei in the thread.
Thank you for your work! It is fine now.
> Also, I've addressed the note from
> Andrei [1] about construction of RestrictInfos.
> I decided to use make_simple_restrictinfo() in
> match_orclause_to_indexcol(), because I've seen its usage in
> get_index_clause_from_support().
I agree with that. I noticed this function is used for formation quals 
from modified clauses. We have the same case in our patch.
> Also, I agree it get it's wrong to directly copy RestrictInfo struct
> in group_similar_or_args().  Instead, I've renamed
> make_restrictinfo_internal() to make_plain_restrictinfo(), which is
> intended to handle non-recursive cases when you've children already
> wrapped with RestrictInfos.
I am willing to agree with renaming function because it processes the 
plain expression without recursive functionality sub expression.
> make_plain_restrictinfo() now used in
> group_similar_or_args().
>
> Hopefully, this item is resolved by now.
>
> Links.
> 1.https://www.postgresql.org/message-id/60760203-4917-4c6c-ac74-a5ee764735a4%40gmail.com
>
I think the case didn't resolve. As I understood the problem is related 
to uncleared cached estimations to default values, namely eval_cost, 
norm_selec, outer_selec variables in RestrictInfo.

I assume we should reset it only for RestrictInfo including 
ScalarArrayOpExpr object that we got before after transformation.


-- 
Regards,
Alena Rybakina
Postgres Professional

--------------3fVHEvJE8puE09IcPxFvsa5W
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi!<br>
    </p>
    <div class="moz-cite-prefix">On 09.09.2024 13:36, Alexander Korotkov
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAPpHfduBA9RXa1LQAz=wFK8cGx_AaHVK_vnNqCnG4yA7KwFf7g@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">On Wed, Sep 4, 2024 at 6:42 PM Alena Rybakina <a class="moz-txt-link-rfc2396E" href="mailto:a.rybakina@postgrespro.ru">&lt;a.rybakina@postgrespro.ru&gt;</a> wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">On 04.09.2024 18:31, Alena Rybakina wrote:
</pre>
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">I rewrote the tests with integer types. Thanks for your suggestion. If
you don't mind, I've updated the diff file you attached earlier to
include the tests.
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">Sorry, I've just noticed that one of your changes with the regression
test wasn't included. I fixed it here.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Please, find the revised patchset attached.  I've integrated the fixes
by you and Andrei in the thread.  </pre>
    </blockquote>
    Thank you for your work! It is fine now.<span
    style="white-space: pre-wrap">
</span><span style="white-space: pre-wrap">
</span>
    <blockquote type="cite"
cite="mid:CAPpHfduBA9RXa1LQAz=wFK8cGx_AaHVK_vnNqCnG4yA7KwFf7g@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">Also, I've addressed the note from
Andrei [1] about construction of RestrictInfos.
I decided to use make_simple_restrictinfo() in
match_orclause_to_indexcol(), because I've seen its usage in
get_index_clause_from_support().</pre>
    </blockquote>
    I agree with that. I noticed this function is used for formation
    quals from modified clauses. We have the same case in our patch.<br>
    <blockquote type="cite"
cite="mid:CAPpHfduBA9RXa1LQAz=wFK8cGx_AaHVK_vnNqCnG4yA7KwFf7g@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">
Also, I agree it get it's wrong to directly copy RestrictInfo struct
in group_similar_or_args().  Instead, I've renamed
make_restrictinfo_internal() to make_plain_restrictinfo(), which is
intended to handle non-recursive cases when you've children already
wrapped with RestrictInfos.  </pre>
    </blockquote>
    I am willing to agree with renaming function because it processes
    the plain expression without recursive functionality sub expression.<br>
    <blockquote type="cite"
cite="mid:CAPpHfduBA9RXa1LQAz=wFK8cGx_AaHVK_vnNqCnG4yA7KwFf7g@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">make_plain_restrictinfo() now used in
group_similar_or_args().

Hopefully, this item is resolved by now.

Links.
1. <a class="moz-txt-link-freetext" href="https://www.postgresql.org/message-id/60760203-4917-4c6c-ac74-a5ee764735a4%40gmail.com">https://www.postgresql.org/message-id/60760203-4917-4c6c-ac74-a5ee764735a4%40gmail.com</a>

</pre>
    </blockquote>
    <p>I think the case didn't resolve. As I understood the problem is
      related to uncleared cached estimations to default values, namely
      eval_cost, norm_selec, outer_selec variables in RestrictInfo.</p>
    <p>I assume we should reset it only for RestrictInfo including
      ScalarArrayOpExpr object that we got before after transformation.</p>
    <p><br>
    </p>
    <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional</pre>
    <p></p>
    <span style="white-space: pre-wrap">
</span>
  </body>
</html>

--------------3fVHEvJE8puE09IcPxFvsa5W--