Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vvpxt-005HKm-0q for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Feb 2026 05:00:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vvpxs-000gD3-0F for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Feb 2026 05:00:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vvpxr-000gCm-24 for pgsql-hackers@lists.postgresql.org; Fri, 27 Feb 2026 05:00:35 +0000 Received: from mail.postgrespro.ru ([93.174.132.70]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vvpxn-00000001QTD-3XFQ for pgsql-hackers@lists.postgresql.org; Fri, 27 Feb 2026 05:00:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1772168429; bh=1upwhWuc4PBAl1b8x25XUFlLRuXWbWloJCi4NpOR4rs=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=yy8t+KzfRyyHYzDubkgyXYgzSX4m7G77k0JU34155v5gRYD/xKVyonKusdgF8gHHK dy/kZSleJn1FcTxHel9aMFivaJoHBinJq2FaFZpAO09sGtyGnCuGYCiCxggO2ssEG0 3kz1mFGcBuNZ9QHKNHYBklqtO9mDISX923BGw4B6MmO3n6Nkl8xCz4QU4z/doSu3Uo dxSJzp+qXjk9lBh9IbgxGQTmicEtOJ39JMfydo1XkQRlQdA0/0lkXN7xX10KjSW0P2 YvPH09LF/GgCdDejOPeWhjK8CuCQXL4VqtD3EDYzikdskCPBsctrdkjhfLrdPU5Zdj wQ9oCo9hgC9nA== Received: from [192.168.3.107] (broadband-5-228-113-160.ip.moscow.rt.ru [5.228.113.160]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: y.sokolov@postgrespro.ru) by mail.postgrespro.ru (Postfix/465) with ESMTPSA id EAC8960DC8; Fri, 27 Feb 2026 08:00:28 +0300 (MSK) Message-ID: <3d7a2207-0e61-4d95-bc00-e5248956a32b@postgrespro.ru> Date: Fri, 27 Feb 2026 08:00:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fix bug in multixact Oldest*MXactId initialization and access To: Sami Imseih Cc: "pgsql-hackers@lists.postgresql.org" , Heikki Linnakangas , Andres Freund , Chao Li References: <7acc94b0-ea82-4657-b1b0-77842cb7a60c@postgrespro.ru> <93F0BD0A-0B8B-4592-9D4B-53F405A86F6A@gmail.com> Content-Language: en-US From: Yura Sokolov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2026/02/27 02:12:00 #28229544 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk 26.02.2026 23:44, Sami Imseih пишет: >> (Sorry, I've used Google Translate to write this sentence). >> >> When you write assert, you protect yourself from shooting your leg far in >> the future. Believe me. > > The issue to me seems that we a few code paths that rely on the > total proc calculation in several places, and changing one and > forgetting to change another is what broke things. If there were asserts, then tests would have failed. Period. There would no the bug. There would no this discussion. If only array bounds were checked with asserts. -- regards Yura Sokolov aka funny-falcon