Message-ID: <3d853c6f-445f-782e-eab0-525729952d4c@amazon.com>
Date: Wed, 10 Aug 2022 14:02:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.1
Subject: Re: shared-memory based stats collector - v70
Content-Language: en-US
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, <andres@anarazel.de>
CC: <stark@mit.edu>, <pgsql-hackers@lists.postgresql.org>
References: 
 <CAM-w4HMYkM_DkYhWtUGV+qE_rrBxKOzOF0+5faozxO3vXrc9wA@mail.gmail.com>
 <20220809.172435.775392169163486535.horikyota.ntt@gmail.com>
 <20220809165319.jdzd225xohqf6o57@awork3.anarazel.de>
 <20220810.113910.92411510444435201.horikyota.ntt@gmail.com>
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
In-Reply-To: <20220810.113910.92411510444435201.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/3d853c6f-445f-782e-eab0-525729952d4c%40amazon.com>
Precedence: bulk

Hi,

On 8/10/22 4:39 AM, Kyotaro Horiguchi wrote:
> At Tue, 9 Aug 2022 09:53:19 -0700, Andres Freund <andres@anarazel.de> wrote in
>> Could you try the pgstat_lock_entry_shared() approach?
> Of course. Please find the attached.

Thanks for the patch!

It looks good to me.

One nit comment though, instead of:

+               /*
+                * Take lwlock directly instead of using 
pg_stat_lock_entry_shared()
+                * which requires a reference.
+                */

what about?

+               /*
+                * Acquire the LWLock directly instead of using 
pg_stat_lock_entry_shared()
+                * which requires a reference.
+                */


I think that's more consistent with other comments mentioning LWLock 
acquisition.

Regards,

-- 
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com