Subject: Re: multivariate statistics v14
To: Simon Riggs <simon@2ndQuadrant.com>, Tatsuo Ishii <ishii@postgresql.org>
References: <5d1d62a6-6228-188c-e079-c1be59942168@2ndquadrant.com>
 <20160409.082146.2151665005996934911.t-ishii@sraoss.co.jp>
 <77be1e99-4f97-9a0c-64b7-472fa0ba4800@2ndquadrant.com>
 <20160410.023757.532440443943028713.t-ishii@sraoss.co.jp>
 <CANP8+j+HZTnnBFxEVvi_qCOTs6a8x+HjjS=q+uy9cAQrLup5vw@mail.gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, David Steele <david@pgmasters.net>,
 Tom Lane <tgl@sss.pgh.pa.us>, =?UTF-8?Q?=c3=81lvaro_Herrera?=
 <alvherre@2ndquadrant.com>, Petr Jelinek <petr@2ndquadrant.com>,
 Jeff Janes <jeff.janes@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Message-ID: <3d9919e9-6fe6-e3c4-d1e7-cd0192ed58d5@2ndquadrant.com>
Date: Sun, 10 Apr 2016 20:29:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101
 Thunderbird/46.0a2
MIME-Version: 1.0
In-Reply-To: 
 <CANP8+j+HZTnnBFxEVvi_qCOTs6a8x+HjjS=q+uy9cAQrLup5vw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 04/10/2016 10:25 AM, Simon Riggs wrote:
> On 9 April 2016 at 18:37, Tatsuo Ishii <ishii@postgresql.org
> <mailto:ishii@postgresql.org>> wrote:
>
>     > But I still think it wouldn't move the patch any closer to committable
>     > state, because what it really needs is review whether the catalog
>     > definition makes sense, whether it should be more like pg_statistic,
>     > and so on. Only then it makes sense to describe the catalog structure
>     > in the SGML docs, I think. That's why I added some basic SGML docs for
>     > CREATE/DROP/ALTER STATISTICS, which I expect to be rather stable, and
>     > not the catalog and other low-level stuff (which is commented heavily
>     > in the code anyway).
>
>     Without "user-level docs" (now I understand that the term means all
>     SGML docs for you), it is very hard to find a visible
>     characteristics/behavior of the patch. CREATE/DROP/ALTER STATISTICS
>     just defines a user interface, and does not help how it affects to the
>     planning. The READMEs do not help either.
>
>     In this case reviewing your code is something like reviewing a program
>     which has no specification.
>
>     That's the reason why I said before below, but it was never seriously
>     considered.
>
>
> I would likely have said this myself but didn't even get that far.
>
> Your contribution was useful and went further than anybody else's
> review, so thank you.

100% agreed. Thanks for the useful feedback.

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers