Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaeMX-0001Zj-29 for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Nov 2020 12:27:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kaeMV-0003Em-3h for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Nov 2020 12:27:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaeMU-0003Ef-Sn for pgsql-hackers@lists.postgresql.org; Thu, 05 Nov 2020 12:27:30 +0000 Received: from forward3-smtp.messagingengine.com ([66.111.4.237]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaeMP-0005aa-Rv for pgsql-hackers@postgresql.org; Thu, 05 Nov 2020 12:27:30 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailforward.nyi.internal (Postfix) with ESMTP id 7DC2019428E1 for ; Thu, 5 Nov 2020 07:27:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 05 Nov 2020 07:27:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=TaXWha1o+n0Xtad5FRCMUZDIkgj7O Zx0YyGHZILi3Pc=; b=EpQfopPB3M4Y5mDmEMg6HPM2vTIItscEpWtAB4ZEkvl9x YvAL7y/nR+ZgHLmHeP+sRICYL2UAyh+JqxRJsGZCacixrax7eV9hKz6pq0AWQ/xh yc3rljyaqXw0AgwcUQzQKPnbbIc+rOPzR0DrPDxvGrH+yEXFZkcmBQBMH/d84cr7 2NRg3TeCb0wAoGOuB7pyM8FCPLNKBKbl7pewOkEXvyzjULa8E1CXZpcYFpCXJhX3 w4Z+PyLlB10pYeUnIwk56JnrfyKpR9NeCHDpDMltRpKjR65J6d2+eoDqh3NFblek A0Fc/lN7fCbkhT6TIRYCc1zCpGSVAPi0EvAPb7ThQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtjedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhuffvohfkffgfgggtsehmtderre dtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgv ihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtth gvrhhnpedvheekvdeggeelueehjefgkeeugeegjefgfeeggedtveehvefgtdefhffgtdfg vdenucfkphepkeejrddujeejrdejuddrvddvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghuthesvghn thgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: from april.pezone.net (p57b147e3.dip0.t-ipconnect.de [87.177.71.227]) by mail.messagingengine.com (Postfix) with ESMTPA id B3A69328037B for ; Thu, 5 Nov 2020 07:27:22 -0500 (EST) From: Peter Eisentraut Subject: redundant error messages To: pgsql-hackers Organization: EnterpriseDB Message-ID: <3e937641-88a1-e697-612e-99bba4b8e5e4@enterprisedb.com> Date: Thu, 5 Nov 2020 13:27:21 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------A61609ABA77917D35461EC1A" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------A61609ABA77917D35461EC1A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit A few client tools duplicate error messages already provided by libpq, such as pg_rewind: fatal: could not connect to server: could not connect to server: No such file or directory pg_basebackup: error: could not connect to server: could not connect to server: No such file or directory psql: error: could not connect to server: could not connect to server: No such file or directory The psql case is actually a regression introduced in PG12, but the other two appear to be ancient. Other client tools provide a different error message so in aggregate it looks like this: createdb: error: could not connect to database template1: could not connect to server: No such file or directory The attached patch removes the redundant message from the client tools. I suppose it's a bit dubious because there is no guarantee what the level of detail the message supplied by libpq has. But I think these few cases are not particularly hard to keep in sync. --------------A61609ABA77917D35461EC1A Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-Fix-redundant-error-messages-in-client-tools.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-redundant-error-messages-in-client-tools.patch" RnJvbSBhMmMxZTI2Y2VmZjA1ZWM2ZWJiZGI5Y2Y3NGEzMTcxZWJmOTY5OTExIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogVGh1LCA1IE5vdiAyMDIwIDEzOjI0OjQ3ICswMTAwClN1YmplY3Q6 IFtQQVRDSF0gRml4IHJlZHVuZGFudCBlcnJvciBtZXNzYWdlcyBpbiBjbGllbnQgdG9vbHMK CkEgZmV3IGNsaWVudCB0b29scyBkdXBsaWNhdGUgZXJyb3IgbWVzc2FnZXMgYWxyZWFkeSBw cm92aWRlZCBieSBsaWJwcS4KLS0tCiBzcmMvYmluL3BnX2Jhc2ViYWNrdXAvc3RyZWFtdXRp bC5jIHwgNSArKy0tLQogc3JjL2Jpbi9wZ19yZXdpbmQvcGdfcmV3aW5kLmMgICAgICB8IDMg Ky0tCiBzcmMvYmluL3BzcWwvc3RhcnR1cC5jICAgICAgICAgICAgIHwgMiArLQogMyBmaWxl cyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3N0cmVhbXV0aWwuYyBiL3NyYy9iaW4vcGdfYmFz ZWJhY2t1cC9zdHJlYW11dGlsLmMKaW5kZXggYmU2NTNlYmIyZC4uNWM1MzZlYjVmZCAxMDA2 NDQKLS0tIGEvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3N0cmVhbXV0aWwuYworKysgYi9zcmMv YmluL3BnX2Jhc2ViYWNrdXAvc3RyZWFtdXRpbC5jCkBAIC0xODMsNyArMTgzLDcgQEAgR2V0 Q29ubmVjdGlvbih2b2lkKQogCQkgKi8KIAkJaWYgKCF0bXBjb25uKQogCQl7Ci0JCQlwZ19s b2dfZXJyb3IoImNvdWxkIG5vdCBjb25uZWN0IHRvIHNlcnZlciIpOworCQkJcGdfbG9nX2Vy cm9yKCJvdXQgb2YgbWVtb3J5Iik7CiAJCQlleGl0KDEpOwogCQl9CiAKQEAgLTIwMCw4ICsy MDAsNyBAQCBHZXRDb25uZWN0aW9uKHZvaWQpCiAKIAlpZiAoUFFzdGF0dXModG1wY29ubikg IT0gQ09OTkVDVElPTl9PSykKIAl7Ci0JCXBnX2xvZ19lcnJvcigiY291bGQgbm90IGNvbm5l Y3QgdG8gc2VydmVyOiAlcyIsCi0JCQkJCSBQUWVycm9yTWVzc2FnZSh0bXBjb25uKSk7CisJ CXBnX2xvZ19lcnJvcigiJXMiLCBQUWVycm9yTWVzc2FnZSh0bXBjb25uKSk7CiAJCVBRZmlu aXNoKHRtcGNvbm4pOwogCQlmcmVlKHZhbHVlcyk7CiAJCWZyZWUoa2V5d29yZHMpOwpkaWZm IC0tZ2l0IGEvc3JjL2Jpbi9wZ19yZXdpbmQvcGdfcmV3aW5kLmMgYi9zcmMvYmluL3BnX3Jl d2luZC9wZ19yZXdpbmQuYwppbmRleCA0MjFhNDVlZjViLi41MmUzZmM0MGU4IDEwMDY0NAot LS0gYS9zcmMvYmluL3BnX3Jld2luZC9wZ19yZXdpbmQuYworKysgYi9zcmMvYmluL3BnX3Jl d2luZC9wZ19yZXdpbmQuYwpAQCAtMjgyLDggKzI4Miw3IEBAIG1haW4oaW50IGFyZ2MsIGNo YXIgKiphcmd2KQogCQljb25uID0gUFFjb25uZWN0ZGIoY29ubnN0cl9zb3VyY2UpOwogCiAJ CWlmIChQUXN0YXR1cyhjb25uKSA9PSBDT05ORUNUSU9OX0JBRCkKLQkJCXBnX2ZhdGFsKCJj b3VsZCBub3QgY29ubmVjdCB0byBzZXJ2ZXI6ICVzIiwKLQkJCQkJIFBRZXJyb3JNZXNzYWdl KGNvbm4pKTsKKwkJCXBnX2ZhdGFsKCIlcyIsIFBRZXJyb3JNZXNzYWdlKGNvbm4pKTsKIAog CQlpZiAoc2hvd3Byb2dyZXNzKQogCQkJcGdfbG9nX2luZm8oImNvbm5lY3RlZCB0byBzZXJ2 ZXIiKTsKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC9zdGFydHVwLmMgYi9zcmMvYmluL3Bz cWwvc3RhcnR1cC5jCmluZGV4IGU4ZDM1YTEwOGYuLjU4NmZjYjMzNjYgMTAwNjQ0Ci0tLSBh L3NyYy9iaW4vcHNxbC9zdGFydHVwLmMKKysrIGIvc3JjL2Jpbi9wc3FsL3N0YXJ0dXAuYwpA QCAtMjk1LDcgKzI5NSw3IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAogCWlm IChQUXN0YXR1cyhwc2V0LmRiKSA9PSBDT05ORUNUSU9OX0JBRCkKIAl7Ci0JCXBnX2xvZ19l cnJvcigiY291bGQgbm90IGNvbm5lY3QgdG8gc2VydmVyOiAlcyIsIFBRZXJyb3JNZXNzYWdl KHBzZXQuZGIpKTsKKwkJcGdfbG9nX2Vycm9yKCIlcyIsIFBRZXJyb3JNZXNzYWdlKHBzZXQu ZGIpKTsKIAkJUFFmaW5pc2gocHNldC5kYik7CiAJCWV4aXQoRVhJVF9CQURDT05OKTsKIAl9 Ci0tIAoyLjI4LjAKCg== --------------A61609ABA77917D35461EC1A--