Content-Type: multipart/mixed; boundary="------------TGXfDeyJXghAqrISLBDJy6h6"
Message-ID: <3eb40b3e-45c7-426a-b7f8-81f7d05a9b53@oss.nttdata.com>
Date: Wed, 9 Apr 2025 01:41:49 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Enhancing Memory Context Statistics Reporting
To: Daniel Gustafsson <daniel@yesql.se>, Rahila Syed <rahilasyed90@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <CAExHW5skNvp265od6XPs0O-RL3cwtgHW3N87Ob0+nByZ=_HzAA@mail.gmail.com>
 <CAH2L28sMyRh_ZomRxkx_RdaQoLcyGAwKCr1TSmrVudbbR_Q1eQ@mail.gmail.com>
 <F23526FA-407E-484B-88BC-4CA81C7CED52@yesql.se>
 <CAH2L28v9EU4dxKUpvMt_CFAzG72CYusPWxADsgT=cwFJP-fP0A@mail.gmail.com>
 <D3689B96-DB1E-4160-AC5E-C2F4E2ACA8CD@yesql.se>
 <54FAE93D-E156-4684-9352-1CEDE6BD4A1C@yesql.se>
 <CAH2L28s+s4JJdPz2RkALzOvXpxXUcmm=fvg-Y6M82g9Cp=bB-w@mail.gmail.com>
 <F50279EA-E138-4C93-BCF5-8B2FC338BFA1@yesql.se>
 <5bxhxniyvjyfldi7yjxcnxkl3i2ghci2grjyeclrbkfqnyhowk@dfkqzbvtbpml>
 <B5BF7FC9-D9AA-4C43-AC28-8A6599056CC0@yesql.se>
 <tesneyk3z2dtrjgwlmkw2wbr7e3olwkowlpke6kl463hfhxedb@fyyqsnwjcp4l>
 <CAH2L28tp8RMa0CrCgdCJw20vFzeGQMuHkXAoPgYC5JZuXY8_+g@mail.gmail.com>
 <F12013F0-F54F-4C3D-92C5-76F8AE944CED@yesql.se>
 <B15D670F-D47B-40DF-A447-0773504B5217@yesql.se>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <B15D670F-D47B-40DF-A447-0773504B5217@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/3eb40b3e-45c7-426a-b7f8-81f7d05a9b53%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------TGXfDeyJXghAqrISLBDJy6h6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2025/04/08 18:46, Daniel Gustafsson wrote:
>> On 8 Apr 2025, at 10:03, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> There was a bug in the shmem init function which caused it to fail on Windows,
>> the attached fixes that.
> 
> With this building green in CI over several re-builds, and another pass over
> the docs and code with pgindent etc done, I pushed this earlier today.  A few
> BF animals have built green so far but I will continue to monitor it.

Thanks for committing this feature!


I noticed that the third argument of pg_get_process_memory_contexts() is named
"retries" in pg_proc.dat, while the documentation refers to it as "timeout".
Since "retries" is misleading, how about renaming it to "timeout" in pg_proc.dat?
Patch attached.


Also, as I mentioned earlier, I encountered an issue when calling
pg_get_process_memory_contexts() on the PID of a backend that had just
encountered an error but hadn't finished rolling back. It led to
the following situation:

    Session 1 (PID=70011):
    =# begin;
    =# select 1/0;
    ERROR:  division by zero

    Session 2:
    =# select * from pg_get_process_memory_contexts(70011, false, 10);

    Session 1 terminated with:
    ERROR:  ResourceOwnerEnlarge called after release started
    FATAL:  terminating connection because protocol synchronization was lost

Shouldn't this be addressed?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------TGXfDeyJXghAqrISLBDJy6h6
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-Rename-misleading-argument-in-pg_get_process_memo.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-Rename-misleading-argument-in-pg_get_process_memo.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBhNzkwODRmZTNjYWFmNzkxZjJhYThkNDY2NjAzYzA4NWNjYjhjNWFmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFdlZCwgOSBBcHIgMjAyNSAwMToyNzo0OCArMDkwMApTdWJqZWN0OiBbUEFU
Q0ggdjFdIFJlbmFtZSBtaXNsZWFkaW5nIGFyZ3VtZW50IGluCiBwZ19nZXRfcHJvY2Vzc19t
ZW1vcnlfY29udGV4dHMoKS4KClByZXZpb3VzbHksIHRoZSB0aGlyZCBhcmd1bWVudCBvZiBw
Z19nZXRfcHJvY2Vzc19tZW1vcnlfY29udGV4dHMoKQp3YXMgbmFtZWQgcmV0cmllcyBpbiBw
Z19wcm9jLmRhdCwgZXZlbiB0aG91Z2ggaXQgYWN0dWFsbHkgc3BlY2lmaWVzCmEgdGltZW91
dCB2YWx1ZSBpbiBzZWNvbmRzLiBUaGlzIG5hbWUgd2FzIG1pc2xlYWRpbmcgdG8gdXNlcnMg
YW5kCmluY29uc2lzdGVudCB3aXRoIHRoZSBkb2N1bWVudGF0aW9uLCB3aGljaCBjb3JyZWN0
bHkgcmVmZXJyZWQgdG8gaXQKYXMgdGltZW91dC4KClRoaXMgY29tbWl0IHJlbmFtZXMgdGhl
IGFyZ3VtZW50IHRvIHRpbWVvdXQgaW4gcGdfcHJvYy5kYXQgdG8KaW1wcm92ZSBjbGFyaXR5
IGFuZCBtYWludGFpbiBjb25zaXN0ZW5jeSB3aXRoIHRoZSBkb2N1bWVudGF0aW9uLgotLS0K
IHNyYy9pbmNsdWRlL2NhdGFsb2cvcGdfcHJvYy5kYXQgfCAyICstCiAxIGZpbGUgY2hhbmdl
ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvaW5j
bHVkZS9jYXRhbG9nL3BnX3Byb2MuZGF0IGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19wcm9j
LmRhdAppbmRleCA0NzA4ZjU1YmUxOC4uNjJiZWI3MWRhMjggMTAwNjQ0Ci0tLSBhL3NyYy9p
bmNsdWRlL2NhdGFsb2cvcGdfcHJvYy5kYXQKKysrIGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9w
Z19wcm9jLmRhdApAQCAtODU3OCw3ICs4NTc4LDcgQEAKICAgcHJvcmV0dHlwZSA9PiAncmVj
b3JkJywgcHJvYXJndHlwZXMgPT4gJ2ludDQgYm9vbCBmbG9hdDgnLAogICBwcm9hbGxhcmd0
eXBlcyA9PiAne2ludDQsYm9vbCxmbG9hdDgsdGV4dCx0ZXh0LHRleHQsX2ludDQsaW50NCxp
bnQ4LGludDgsaW50OCxpbnQ4LGludDgsaW50NCx0aW1lc3RhbXB0en0nLAogICBwcm9hcmdt
b2RlcyA9PiAne2ksaSxpLG8sbyxvLG8sbyxvLG8sbyxvLG8sbyxvfScsCi0gIHByb2FyZ25h
bWVzID0+ICd7cGlkLCBzdW1tYXJ5LCByZXRyaWVzLCBuYW1lLCBpZGVudCwgdHlwZSwgcGF0
aCwgbGV2ZWwsIHRvdGFsX2J5dGVzLCB0b3RhbF9uYmxvY2tzLCBmcmVlX2J5dGVzLCBmcmVl
X2NodW5rcywgdXNlZF9ieXRlcywgbnVtX2FnZ19jb250ZXh0cywgc3RhdHNfdGltZXN0YW1w
fScsCisgIHByb2FyZ25hbWVzID0+ICd7cGlkLCBzdW1tYXJ5LCB0aW1lb3V0LCBuYW1lLCBp
ZGVudCwgdHlwZSwgcGF0aCwgbGV2ZWwsIHRvdGFsX2J5dGVzLCB0b3RhbF9uYmxvY2tzLCBm
cmVlX2J5dGVzLCBmcmVlX2NodW5rcywgdXNlZF9ieXRlcywgbnVtX2FnZ19jb250ZXh0cywg
c3RhdHNfdGltZXN0YW1wfScsCiAgIHByb3NyYyA9PiAncGdfZ2V0X3Byb2Nlc3NfbWVtb3J5
X2NvbnRleHRzJyB9LAogCiAjIG5vbi1wZXJzaXN0ZW50IHNlcmllcyBnZW5lcmF0b3IKLS0g
CjIuNDkuMAoK

--------------TGXfDeyJXghAqrISLBDJy6h6--