Subject: Re: TAP tests and symlinks on Windows
To: Michael Paquier <michael@paquier.xyz>,
 Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
References: <20200609071931.GE38342@paquier.xyz>
 <89a38304-8900-2e6b-de26-19a0312f3a87@2ndquadrant.com>
 <CAC+AXB3NfdDsp+egpYj=qgD+vPhb_dNRA4vwgcTL+Vmhj38UWw@mail.gmail.com>
 <87sgf4pmb8.fsf@wibble.ilmari.org> <20200612065957.GA3362@paquier.xyz>
 <CAC+AXB0VJ9A4f6Ob9b3wV8V_VGND5X3MBLKQRd0+8L6t-gMiCQ@mail.gmail.com>
 <20200613060054.GM3362@paquier.xyz> <20200615062319.GF52676@paquier.xyz>
 <11c4ee09-3706-5912-ffd7-dc3657de7a5e@2ndQuadrant.com>
 <20200617074434.GB118592@paquier.xyz> <20200623105527.GA1974@paquier.xyz>
Cc: =?UTF-8?Q?Juan_Jos=c3=a9_Santamar=c3=ada_Flecha?=
 <juanjo.santamaria@gmail.com>, =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?=
 <ilmari@ilmari.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <3ebcde2b-3b78-2e5f-9249-03c709dc23dd@2ndquadrant.com>
Date: Fri, 26 Jun 2020 14:00:37 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200623105527.GA1974@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-06-23 12:55, Michael Paquier wrote:
> I have implemented a patch based on the feedback received that does
> the following, tested with all three patterns (MSVC only on Windows):
> - Assume that all non-Windows platform have a proper symlink
> implementation for perl.
> - If on Windows, check for the presence of Win32::Symlink:
> -- If the module is not detected, skip the tests not supported.
> -- If the module is detected, run them.

We should be more accurate about things like this:

+# The following tests test symlinks. Windows may not have symlinks, so
+# skip there.

The issue isn't whether Windows has symlinks, since all versions of 
Windows supported by PostgreSQL do (AFAIK).  The issue is only whether 
the Perl installation that runs the tests has symlink support.  And that 
is only necessary if the test itself wants to create or inspect 
symlinks.  For example, there are existing tests involving tablespaces 
that work just fine on Windows.

Relatedly, your patch ends up skipping the tests on MSYS2, even though 
Perl supports symlinks there out of the box.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services