Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptnVS-0004OJ-JJ for pgsql-hackers@arkaria.postgresql.org; Tue, 02 May 2023 10:45:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ptnVQ-0001l9-JN for pgsql-hackers@arkaria.postgresql.org; Tue, 02 May 2023 10:45:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptnVQ-0001l0-7f for pgsql-hackers@lists.postgresql.org; Tue, 02 May 2023 10:45:12 +0000 Received: from mail1.dalibo.net ([51.159.93.128] helo=mail.dalibo.com) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ptnVN-0006d8-4Y for pgsql-hackers@postgresql.org; Tue, 02 May 2023 10:45:10 +0000 Received: from [192.168.1.16] (unknown [90.58.191.166]) by mail.dalibo.com (Postfix) with ESMTPSA id 9D46E1F6D2; Tue, 2 May 2023 12:44:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dalibo.com; s=a; t=1683024299; bh=nSqqfSU1+r0SMoly4TaJnkzPKxZNA3eGT7x3arVV6No=; h=Date:References:From:To:Cc:Subject:In-Reply-To:From; b=Tx6rlpW0UygH4b8oTG3vnZcq7jEtVFAcWBCiNwH7A4XZCTjwHC7wAGyMwGGaBRJhm t+5CCAyslPJfmUrXsOK1lPEzIn166L41ivFhNj+ls96X/mgAtku9boM0ipXMkvc9fs C4GTA9QbEzhL/MS3qEKYRdRJjtoxOpl41O8hMttU= Content-Type: multipart/mixed; boundary="------------aY6RuaAAaz5jKKprpzTjWC7J" Message-ID: <3ed1b53c-15c0-5638-a059-69bd6a2fb11d@dalibo.com> Date: Tue, 2 May 2023 12:44:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 References: Content-Language: fr From: =?UTF-8?Q?Benoit_Lobr=c3=a9au?= To: Robert Haas , Amit Kapila Cc: pgsql-hackers , Melanie Plageman Subject: Re: Logging parallel worker draught In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------aY6RuaAAaz5jKKprpzTjWC7J Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/1/23 18:33, Robert Haas wrote: > Why not? It seems like something some people might want to log and > others not. Running the whole server at DEBUG1 to get this information > doesn't seem like a suitable answer. Since the statement is also logged, it could spam the log with huge queries, which might also be a reason to stop logging this kind of problems until the issue is fixed. I attached the patch without the guc anyway just in case. > What I was wondering was whether we would be better off putting this > into the statistics collector, vs. doing it via logging. Both > approaches seem to have pros and cons. We tried to explore different options with my collegues in another thread [1]. I feel like both solutions are worthwhile, and would be helpful. I plan to take a look at the pg_stat_statement patch [2] next. Since it's my first patch, I elected to choose the easiest solution to implement first. I also proposed this because I think logging can help pinpoint a lot of problems at a minimal cost, since it is easy to setup and exploit for everyone, everywhere [1] https://www.postgresql.org/message-id/d657df20-c4bf-63f6-e74c-cb85a81d0383@dalibo.com [2] https://www.postgresql.org/message-id/flat/6acbe570-068e-bd8e-95d5-00c737b865e8%40gmail.com -- Benoit Lobréau Consultant http://dalibo.com --------------aY6RuaAAaz5jKKprpzTjWC7J Content-Type: text/plain; charset=UTF-8; name="0001-Add-logging-for-exceeded-parallel-worker-slot-limits.patch_v2_no_guc" Content-Disposition: attachment; filename*0="0001-Add-logging-for-exceeded-parallel-worker-slot-limits.pa"; filename*1="tch_v2_no_guc" Content-Transfer-Encoding: base64 RnJvbSBmYzcxZWY0MGYzM2Y5NGIwNTA2YTA5MmZiNWIzZGNkZTZkZTZkNjBhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBiZW5vaXQgPGJlbm9pdC5sb2JyZWF1QGRhbGliby5j b20+CkRhdGU6IFR1ZSwgMiBNYXkgMjAyMyAxMDowODowMCArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIEFkZCBsb2dnaW5nIGZvciBleGNlZWRlZCBwYXJhbGxlbCB3b3JrZXIgc2xvdCBsaW1p dHMKClByb2N1ZGUgYSBsb2cgbWVzc2FnZSB3aGVuIGEgYmFja2VuZCBhdHRlbXB0cyB0byBz cGF3biBhIHBhcmFsbGVsIHdvcmtlcgpidXQgZmFpbHMgZHVlIHRvIGluc3VmZmljaWVudCB3 b3JrZXIgc2xvdHMuIFRoZSBzaG9ydGFnZSBjYW4gc3RlbSBmcm9tCm1heF93b3JrZXJfcHJv Y2Vzc2VzLCBtYXhfcGFyYWxsZWxfd29ya2VyLCBvcgptYXhfcGFyYWxsZWxfbWFpbnRlbmFu Y2Vfd29ya2Vycy4gVGhlIGxvZyBtZXNzYWdlIGNhbiBoZWxwIGRhdGFiYXNlCmFkbWluaXN0 cmF0b3JzIGFuZCBkZXZlbG9wZXJzIGRpYWdub3NlIHBlcmZvcm1hbmNlIGlzc3VlcyByZWxh dGVkIHRvCnBhcmFsbGVsaXNtIGFuZCBvcHRpbWl6ZSB0aGUgY29uZmlndXJhdGlvbiBvZiB0 aGUgc3lzdGVtIGFjY29yZGluZ2x5LgotLS0KIHNyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2Ft L3BhcmFsbGVsLmMgfCA1ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCsp CgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0vcGFyYWxsZWwuYyBi L3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3BhcmFsbGVsLmMKaW5kZXggYjI2ZjJhNjRm Yi4uYzYwZDFiZDczOSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0v cGFyYWxsZWwuYworKysgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS9wYXJhbGxlbC5j CkBAIC02MzAsNiArNjMwLDExIEBAIExhdW5jaFBhcmFsbGVsV29ya2VycyhQYXJhbGxlbENv bnRleHQgKnBjeHQpCiAJCXBjeHQtPm5rbm93bl9hdHRhY2hlZF93b3JrZXJzID0gMDsKIAl9 CiAKKwlpZiAocGN4dC0+bndvcmtlcnNfbGF1bmNoZWQgPCBwY3h0LT5ud29ya2Vyc190b19s YXVuY2gpCisJCQllcmVwb3J0KExPRywKKwkJCQkoZXJybXNnKCJQYXJhbGxlbCBXb3JrZXIg ZHJhdWdodCBkdXJpbmcgc3RhdGVtZW50IGV4ZWN1dGlvbjogd29ya2VycyBzcGF3bmVkICVk LCByZXF1ZXN0ZWQgJWQiLAorCQkJCQlwY3h0LT5ud29ya2Vyc19sYXVuY2hlZCwgcGN4dC0+ bndvcmtlcnNfdG9fbGF1bmNoKSkpOworCiAJLyogUmVzdG9yZSBwcmV2aW91cyBtZW1vcnkg Y29udGV4dC4gKi8KIAlNZW1vcnlDb250ZXh0U3dpdGNoVG8ob2xkY29udGV4dCk7CiB9Ci0t IAoyLjM5LjIKCg== --------------aY6RuaAAaz5jKKprpzTjWC7J--