Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id EF20E632E5E for ; Thu, 26 Mar 2009 23:38:07 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 20024-10 for ; Thu, 26 Mar 2009 23:37:56 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.230]) by mail.postgresql.org (Postfix) with ESMTP id 3176C63245D for ; Thu, 26 Mar 2009 23:38:02 -0300 (ADT) Received: by rv-out-0506.google.com with SMTP id l9so1295212rvb.43 for ; Thu, 26 Mar 2009 19:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=9Kx0jQwvBKhifCYA4T4c8Bswhokg6w+OgBrR6iSixb8=; b=F+aCoe/3nag4tcoBnh+pvBBOMMJk2cPxFZ6E3dqvhE3J4XqAtg7DEsWzj/xDIoD26L CrQxD7Pj7rGRu3GVf6jGRddwOI6Be4OEyuvpGWgtLiKDJ9tucO738QM+eaqN9BvTrkxW 4q3mz7Isa8ChKhg/E1AzC+qSf63jwQGWs2QRM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=EVj/EeZbVoZ7z+kPsIOinjAIFeb/rw1pm+o9rnmkpnyQanxX6cThVX9+/uxJUXltmz 7ZgTNV7nZKddCJrJPHfRNOZpaf33c8zMGgArqRb/quNJ0QCG2jSMwN++AJYry4rwWHI2 yYbwvZGXlND0+OmaOSPb76lDZxnR8Q9l1En+A= MIME-Version: 1.0 Received: by 10.141.82.20 with SMTP id j20mr826039rvl.54.1238121480193; Thu, 26 Mar 2009 19:38:00 -0700 (PDT) In-Reply-To: <1d4e0c10903260454p10107c23j7ff9a3de8be09dde@mail.gmail.com> References: <3f0b79eb0903242329j12865d55s348f5c873a956e71@mail.gmail.com> <1d4e0c10903242350i505a9f6bsa7ba347dc02f90b6@mail.gmail.com> <3f0b79eb0903250144k453b3927mffa8b08678ed057b@mail.gmail.com> <1d4e0c10903250155w34bd79dcvfab2ad5c95e56011@mail.gmail.com> <49C9F255.EE98.0025.0@wicourts.gov> <1d4e0c10903250848x4e067c86ue611c0c50f25e49d@mail.gmail.com> <3f0b79eb0903251851v5936d6b4x49997ac8f04b98b9@mail.gmail.com> <1d4e0c10903260032v767da1fdg6cf7cea86c64cc45@mail.gmail.com> <1238064633.16568.420.camel@ebony.2ndQuadrant> <1d4e0c10903260454p10107c23j7ff9a3de8be09dde@mail.gmail.com> Date: Fri, 27 Mar 2009 11:38:00 +0900 Message-ID: <3f0b79eb0903261938l15a6a8b8v5a7f8dec2c795cef@mail.gmail.com> Subject: Re: New trigger option of pg_standby From: Fujii Masao To: Guillaume Smet Cc: Simon Riggs , Kevin Grittner , pgsql-hackers Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200903/1103 X-Sequence-Number: 135781 Hi, On Thu, Mar 26, 2009 at 8:54 PM, Guillaume Smet wrote: > Hi Simon. > > On Thu, Mar 26, 2009 at 11:50 AM, Simon Riggs wrote: >> Earlier, we discussed having a single trigger file that contains an >> option rather than two distinct trigger files. That design is better >> because it allows the user to choose at failover time, rather than >> making a binding decision at config time. That solution would be the >> ideal one, IMHO, because it gives user more choice - and would allow us >> to keep the -t option meaningfully. In that case the default should be >> patience. > > Or you can define both files in your command line to have the choice. Personally I like this. > I like the idea of removing -t and adding 2 new options so that people > are warned about the intended behavior. OK, I'll change the patch as Simon suggested; removing -t and adding two new options: -f = fast failover (existing behavior), -p patient failover. Also I'll default the patient failover, so it's performed when the signal (SIGINT or SIGUSR1) is received. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center