Message-ID: <3f137c66-ef48-4b3c-8028-9dceb2580df8@illuminatedcomputing.com>
Date: Thu, 29 Feb 2024 14:10:49 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: SQL:2011 application time
Content-Language: en-US
To: jian he <jian.universality@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail.gmail.com>
 <2d9740ad-3bb7-473c-8441-344351caa8ee@illuminatedcomputing.com>
 <fd41e772-296e-43e9-a70e-2e27bb8b1cd5@eisentraut.org>
 <af62a16b-9f88-4746-8e87-fdf0c242b266@illuminatedcomputing.com>
 <a37f180d-b54b-46d6-9e52-cc15f32be200@eisentraut.org>
 <596fefdd-6202-4228-b7c6-f240b1cbe06e@eisentraut.org>
 <df018b96-f0dc-49ba-98af-3a3983f683fe@illuminatedcomputing.com>
 <35400587-6865-4a2c-9ea4-4761669478ea@eisentraut.org>
 <71b45adb-b496-4e58-b134-0a091014e63f@illuminatedcomputing.com>
 <7be8724a-5c25-46d7-8325-1bd8be6fa523@eisentraut.org>
 <CACJufxHVg65raNhG2zBwXgjrD6jqace4NZbePyMhP8-_Q=iT8w@mail.gmail.com>
 <0af6a323-f026-4cd9-adf1-941038cd00de@illuminatedcomputing.com>
 <88518c81-dcdc-4c5b-9200-146b74a520ab@eisentraut.org>
 <113f5e25-4455-4bdb-98ec-56275705cc4e@illuminatedcomputing.com>
 <7bd1c8f9-a91a-41a3-990e-0f796ba692ec@eisentraut.org>
 <CACJufxHo4KneseUSV6PoBVeL19GPPwrvemrw1ggAzbTrLzP=mA@mail.gmail.com>
From: Paul Jungwirth <pj@illuminatedcomputing.com>
In-Reply-To: <CACJufxHo4KneseUSV6PoBVeL19GPPwrvemrw1ggAzbTrLzP=mA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/3f137c66-ef48-4b3c-8028-9dceb2580df8%40illuminatedcomputing.com>
Precedence: bulk

On 2/13/24 21:00, jian he wrote:
> Hi
> more minor issues.
> 
> + FindFKComparisonOperators(
> + fkconstraint, tab, i, fkattnum,
> + &old_check_ok, &old_pfeqop_item,
> + pktypoid[i], fktypoid[i], opclasses[i],
> + is_temporal, false,
> + &pfeqoperators[i], &ppeqoperators[i], &ffeqoperators[i]);
> + }
> + if (is_temporal) {
> + pkattnum[numpks] = pkperiodattnum;
> + pktypoid[numpks] = pkperiodtypoid;
> + fkattnum[numpks] = fkperiodattnum;
> + fktypoid[numpks] = fkperiodtypoid;
> 
> - pfeqop = get_opfamily_member(opfamily, opcintype, fktyped,
> - eqstrategy);
> - if (OidIsValid(pfeqop))
> - {
> - pfeqop_right = fktyped;
> - ffeqop = get_opfamily_member(opfamily, fktyped, fktyped,
> - eqstrategy);
> - }
> - else
> - {
> - /* keep compiler quiet */
> - pfeqop_right = InvalidOid;
> - ffeqop = InvalidOid;
> - }
> + FindFKComparisonOperators(
> + fkconstraint, tab, numpks, fkattnum,
> + &old_check_ok, &old_pfeqop_item,
> + pkperiodtypoid, fkperiodtypoid, opclasses[numpks],
> + is_temporal, true,
> + &pfeqoperators[numpks], &ppeqoperators[numpks], &ffeqoperators[numpks]);
> + numfks += 1;
> + numpks += 1;
> + }
> 
> opening curly brace should be the next line,

Fixed in v25 (submitted in my other email).

> also do you think it's
> good idea to add following in the `if (is_temporal)` branch
> `
> Assert(OidIsValid(fkperiodtypoid) && OidIsValid(pkperiodtypoid));
> Assert(OidIsValid(pkperiodattnum > 0 && fkperiodattnum > 0));
> `
> 
> ` if (is_temporal)` branch, you can set the FindFKComparisonOperators
> 10th argument (is_temporal)
> to true, since you are already in the ` if (is_temporal)` branch.
> 
> maybe we need some extra comments on
> `
> + numfks += 1;
> + numpks += 1;
> `
> since it might not be that evident?

That branch doesn't exist anymore. Same with the increments.

> Do you think it's a good idea to list arguments line by line (with
> good indentation) is good format? like:
> FindFKComparisonOperators(fkconstraint,
> tab,
> i,
> fkattnum,
> &old_check_ok,
> &old_pfeqop_item,
> pktypoid[i],
> fktypoid[i],
> opclasses[i],
> false,
> false,
> &pfeqoperators[i],
> &ppeqoperators[i],
> &ffeqoperators[i]);

There are places we do that, but most code I've seen tries to fill the line. I haven't followed that 
strictly here, but I'm trying to get better at doing what pg_indent wants.

Yours,

-- 
Paul              ~{:-)
pj@illuminatedcomputing.com