Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDpTo-00050Q-0P for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 15:49:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDpTl-00007T-Ix for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 15:49:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDpTl-0008S2-9A for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 15:49:45 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDpTg-00022m-Iw for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 15:49:44 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 60C6A5C01B4; Tue, 19 Jul 2022 11:49:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 19 Jul 2022 11:49:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1658245777; x=1658332177; bh=N aWUzppQiYk1ac6Wpye6GdRllawjPZNhKMJJMrzHauk=; b=iHuiJpEwrxFcl2O2T 5OAHtFzSMGKdvybDhdHemO1ePLpmq4APE9V+U35xFwBQokGxokvFojYj4/unFV7W zLxwjeU3rlZvIYZOu6zj0AKNs2EmwbPpsPzcLVgmmsEHnaJ4P/AD6LpXQt4yEjoq DRZOXDiQG2ZN7wHncGKuYmZvuOYfkB45KAZISKdDXaFDNl2a3gsyu8HafOY2buvG a89X53QG40ISQDRUHBs5kYGBjOfcBykf1RyOiJ0yKOrHKINUlTvx6wmd3ZonCxQC j4F2wIBl9fkXRXAuvEVttlhe6b6BAGbdiyTHZcFLDVyK3Qr6fDLR6tjEUeVFYFHL VGBJg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeltddgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghr rdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrg htthgvrhhnpeefjeegheetuefhveevudelueeftdejteeiffetvdduhfdtieefgfeutedt veeggfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hpvghtvghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Jul 2022 11:49:35 -0400 (EDT) Message-ID: <3f5d4811-92db-a358-0ef4-c69adf974d61@enterprisedb.com> Date: Tue, 19 Jul 2022 17:49:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Convert planner's AggInfo and AggTransInfo to Nodes Content-Language: en-US To: Tom Lane , pgsql-hackers@lists.postgresql.org References: <742479.1658160504@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: <742479.1658160504@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 18.07.22 18:08, Tom Lane wrote: > I'm kind of tempted to mount an effort to get rid of as many of > pathnodes.h's "read_write_ignore" annotations as possible. Some are > necessary to prevent infinite recursion, and others represent considered > judgments that they'd bloat node dumps more than they're worth --- but > I think quite a lot of them arose from plain laziness about updating > outfuncs.c. With the infrastructure we have now, that's no longer > a good reason. That was my impression as well, and I agree it would be good to sort that out.