Feedback-ID: ie0a040ee:Fastmail
Message-ID: <3fa9ef0f-b277-4c13-850a-8ccc04de1406@eisentraut.org>
Date: Mon, 25 Mar 2024 12:55:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: speed up a logical replica setup
To: Euler Taveira <euler@eulerto.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
 Shlok Kyal <shlok.kyal.oss@gmail.com>,
 "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com>,
 vignesh C <vignesh21@gmail.com>
References: <9a9c7e65-c47b-4400-a63e-ac6169c0860e@app.fastmail.com>
 <e390e35e-508e-4eb8-92e4-e6b066407a41@app.fastmail.com>
 <TYCPR01MB12077121263EFF7680486B635F5212@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <40595e73-c7e1-463a-b8be-49792e870007@app.fastmail.com>
 <6423dfeb-a729-45d3-b71e-7bf1b3adb0c9@enterprisedb.com>
 <TYCPR01MB12077DE77454D68E959E85E35F5272@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <e8564096-3c4f-4990-ac7d-ba089739b878@app.fastmail.com>
 <CANhcyEW6-dH28gLbFc5XpDTJ6JPizU+t5g-aKUWJBf5W_Zriqw@mail.gmail.com>
 <2f0b73f3-e7c0-4e95-9712-1993442a6b64@app.fastmail.com>
 <CAA4eK1JtnzqYNQ_S+mj_XsPfgk7szxegKiVQq4-8fY1wUcUnpg@mail.gmail.com>
 <34637e7f-0330-420d-8f45-1d022962d2fe@app.fastmail.com>
 <7a970912-0b77-4942-84f7-2c9ca0bc05a5@eisentraut.org>
 <d546c4bb-92d1-4e2d-898f-48234b12ed25@app.fastmail.com>
 <CANhcyEWdTTO71v+GFYUTsOOUvHus1qccg88bRmsU9KykJqjSrQ@mail.gmail.com>
 <44de4e04-db22-40ed-8ba9-46387dc8bf83@app.fastmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <44de4e04-db22-40ed-8ba9-46387dc8bf83@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/3fa9ef0f-b277-4c13-850a-8ccc04de1406%40eisentraut.org>
Precedence: bulk

On 22.03.24 04:31, Euler Taveira wrote:
> On Thu, Mar 21, 2024, at 6:49 AM, Shlok Kyal wrote:
>> There is a compilation error while building postgres with the patch
>> due to a recent commit. I have attached a top-up patch v32-0003 to
>> resolve this compilation error.
>> I have not updated the version of the patch as I have not made any
>> change in v32-0001 and v32-0002 patch.
> 
> I'm attaching a new version (v33) to incorporate this fix (v32-0003) 
> into the
> main patch (v32-0001). This version also includes 2 new tests:
> 
> - refuse to run if the standby server is running
> - refuse to run if the standby was promoted e.g. it is not in recovery
> 
> The first one exercises a recent change (standby should be stopped) and the
> second one covers an important requirement.

I have committed your version v33.  I did another pass over the 
identifier and literal quoting.  I added quoting for replication slot 
names, for example, even though they can only contain a restricted set 
of characters, but it felt better to be defensive there.

I'm happy to entertain follow-up patches on some of the details like 
option naming that were still being discussed.  I just wanted to get the 
main functionality in in good time.  We can fine-tune the rest over the 
next few weeks.

> Based on the discussion [1] about the check functions, Vignesh suggested 
> that it
> should check both server before exiting. v33-0003 implements it. I don't 
> have a
> strong preference; feel free to apply it.

I haven't done anything about this.