public inbox for [email protected]  
help / color / mirror / Atom feed
[PATCH 4/6] 0002 review
2+ messages / 2 participants
[nested] [flat]

* [PATCH 4/6] 0002 review
@ 2021-02-15 15:31 Tomas Vondra <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Tomas Vondra @ 2021-02-15 15:31 UTC (permalink / raw)

---
 doc/src/sgml/ref/analyze.sgml      | 2 +-
 doc/src/sgml/ref/cluster.sgml      | 2 +-
 doc/src/sgml/ref/copy.sgml         | 2 +-
 doc/src/sgml/ref/create_index.sgml | 2 +-
 doc/src/sgml/ref/reindex.sgml      | 2 +-
 doc/src/sgml/ref/vacuum.sgml       | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/src/sgml/ref/analyze.sgml b/doc/src/sgml/ref/analyze.sgml
index 9db9070b62..5a9e3322b3 100644
--- a/doc/src/sgml/ref/analyze.sgml
+++ b/doc/src/sgml/ref/analyze.sgml
@@ -275,7 +275,7 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
   </para>
 
   <para>
-    Each backend running the <command>ANALYZE</command> command will report their
+    Each backend running the <command>ANALYZE</command> command will report its
     progress to the <structname>pg_stat_progress_analyze</structname> view.
     See <xref linkend="analyze-progress-reporting"/> for details.
   </para>
diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml
index 5c2270f71b..70c4b33454 100644
--- a/doc/src/sgml/ref/cluster.sgml
+++ b/doc/src/sgml/ref/cluster.sgml
@@ -193,7 +193,7 @@ CLUSTER [VERBOSE]
    </para>
 
   <para>
-    Each backend running the <command>CLUSTER</command> command will report their
+    Each backend running the <command>CLUSTER</command> command will report its
     progress to the <structname>pg_stat_progress_cluster</structname> view.
     See <xref linkend="cluster-progress-reporting"/> for details.
   </para>
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index af3ce72561..41e1d7c371 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -84,7 +84,7 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
   </para>
 
   <para>
-    Each backend running the <command>COPY</command> command will report their
+    Each backend running the <command>COPY</command> command will report its
     progress to the <structname>pg_stat_progress_copy</structname> view.
     See <xref linkend="copy-progress-reporting"/> for details.
   </para>
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 278058f500..6079a0ef28 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -868,7 +868,7 @@ Indexes:
 
   <para>
     Each backend running the <command>CREATE INDEX</command> command will 
-    report their progress to the 
+    report it's progress to the 
     <structname>pg_stat_progress_create_index</structname> view.
     See <xref linkend="create-index-progress-reporting"/> for details.
   </para>
diff --git a/doc/src/sgml/ref/reindex.sgml b/doc/src/sgml/ref/reindex.sgml
index f69f5db403..3b4d409856 100644
--- a/doc/src/sgml/ref/reindex.sgml
+++ b/doc/src/sgml/ref/reindex.sgml
@@ -496,7 +496,7 @@ Indexes:
 
   <para>
     Each backend running the <command>REINDEX</command> command will report
-    their progress to the <structname>pg_stat_progress_create_index</structname>
+    its progress to the <structname>pg_stat_progress_create_index</structname>
     view. See <xref linkend="create-index-progress-reporting"/> for details.
   </para>
   </refsect2>
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index bab3d00313..0624235696 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -395,7 +395,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
    </para>
    <para>
     Each backend running the <command>VACUUM</command> command without the
-    <literal>FULL</literal> option will report their progress in the 
+    <literal>FULL</literal> option will report its progress in the 
     <structname>pg_stat_progress_vacuum</structname> view. Backends running
     <command>VACUUM</command> with the <literal>FULL</literal> option report 
     progress in the <structname>pg_stat_progress_cluster</structname> instead.
-- 
2.26.2


--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
 name="v7-0005-Add-copy-progress-reporting-regression-tests.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment;
 filename*0="v7-0005-Add-copy-progress-reporting-regression-tests.patch"



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* meson documentation build open issues
@ 2023-03-15 07:14 Peter Eisentraut <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2023-03-15 07:14 UTC (permalink / raw)
  To: pgsql-hackers

I have identified several open issues with the documentation build under 
Meson (approximately in priority order):

1. Image files are not handled at all, so they don't show up in the 
final product.

2. Defaults to website stylesheet, no way to configure.  This should be 
adjusted to match the make build.

3. The various build targets and their combinations are mismatching and 
incomplete.  For example:

Top-level GNUmakefile has these targets:

- docs (builds html and man)
- html
- man

(Those are the formats that are part of a distribution build.)

doc/src/sgml/Makefile has these documented targets:

- default target is html
- all (builds html and man, maps to top-level "docs")
- html
- man
- postgres-A4.pdf
- postgres-US.pdf
- check

as well as (undocumented):

- htmlhelp
- postgres.html
- postgres.txt
- epub
- postgres.epub
- postgres.info

meson has the following documented targets:

- docs (builds only html)
- alldocs (builds all formats, including obscure ones)

as well as the following undocumented targets:

- html
- man
- html_help [sic]
- postgres-A4.pdf
- postgres-US.pdf
- postgres.epub

- [info is not implemented at all]
- [didn't find an equivalent of check]

As you can see, this is all over the place.  I'd like to arrive at some 
consistency across all build systems for handling each tier of 
documentation formats, in terms of what is documented, what the targets 
are named, and how they are grouped.

4. There doesn't appear to be a way to install the documentation.
(There are also some open questions in the top-level meson.build about
the installation directories, but I suppose if we can't install them
then exactly where to install them hasn't been thought about too
much.)

5. There doesn't appear to be an equivalent of "make world" and "make
install-world" that includes documentation builds.






^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-03-15 07:14 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 15:31 [PATCH 4/6] 0002 review Tomas Vondra <[email protected]>
2023-03-15 07:14 meson documentation build open issues Peter Eisentraut <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox