Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------Q088AlRpXuzlETDPQ8jl4Bgl"
Message-ID: <3fd0f1bc-4483-4ba9-8aa0-64765b052039@eisentraut.org>
Date: Wed, 8 Nov 2023 09:41:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Remove MSVC scripts from the tree
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
References: <ZQzp_VMJcerM1Cs_@paquier.xyz>
 <a08e14cf-23c0-b4b6-37f5-dec671e85e7f@eisentraut.org>
 <ZRpzY4Yz9FcW1ZKV@paquier.xyz>
 <d8c7c426-ca50-86be-ce74-d0a8110c40fe@eisentraut.org>
 <ZSeCz50wip_ruKr_@paquier.xyz>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <ZSeCz50wip_ruKr_@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/3fd0f1bc-4483-4ba9-8aa0-64765b052039%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------Q088AlRpXuzlETDPQ8jl4Bgl
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12.10.23 07:23, Michael Paquier wrote:
>> - Is src/backend/utils/README.Gen_dummy_probes still correct after this?
>> AFAICT, the Perl-based MSVC build system uses Gen_dummy_probes.pl, but the
>> meson build uses Gen_dummy_probes.sed even on Windows.  Is that correct,
>> intended?
> Interesting point.  This may depend on the environment at the end?  As
> far as I can see, sed is currently a hard requirement in the meson
> build and we'd fail if the command cannot be used.  The buildfarm
> machines that test meson are able to find sed, making
> Gen_dummy_probes.pl not necessary:
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=drongo&dt=2023-10-11%2020%3A21%3A17&stg=configure
> 
> So the $1000 question is: could there be a point in keeping the perl
> script around if sed cannot be found?  The buildfarm coverage is
> currently saying no thanks to chocolatey, at least.  The VM images
> compiled by Andres for the CI seem to have the same opinion.

I don't think we should rely on sed being there on Windows.  Maybe it's 
true now on the handful of buildfarm/CI machines and early adopters, but 
do we have any indication that that is systematic or just an accident?

Since we definitely require Perl now, we could just as well use the Perl 
script and avoid this issue.

Attached is a Perl version of the sed script, converted by hand (so not 
the super-verbose s2p thing).  It's basically just the sed script with 
semicolons added and the backslashes in the regular expressions moved 
around.  I think we could use something like that for all platforms now.


--------------Q088AlRpXuzlETDPQ8jl4Bgl
Content-Type: text/x-perl-script; charset=UTF-8; name="Gen_dummy_probes2.pl"
Content-Disposition: attachment; filename="Gen_dummy_probes2.pl"
Content-Transfer-Encoding: base64

Iy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0KIyBQZXJsIHNjcmlwdCB0byBjcmVhdGUgZHVtbXkgcHJv
YmVzLmggZmlsZSB3aGVuIGR0cmFjZSBpcyBub3QgYXZhaWxhYmxlCiMKIyBDb3B5cmlnaHQg
KGMpIDIwMDgtMjAyMywgUG9zdGdyZVNRTCBHbG9iYWwgRGV2ZWxvcG1lbnQgR3JvdXAKIwoj
IHNyYy9iYWNrZW5kL3V0aWxzL0dlbl9kdW1teV9wcm9iZXMucGwKIy0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0KCnVzZSBzdHJpY3Q7CnVzZSB3YXJuaW5nczsKCm0vXlsgCV0qcHJvYmUgLyB8fCBu
ZXh0OwpzL15bIAldKnByb2JlIChbXihdKikoLiopOy8kMSQyLzsKcy9fXy9fL2c7CnkvYWJj
ZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXovQUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVovOwpz
L14vI2RlZmluZSBUUkFDRV9QT1NUR1JFU1FMXy87CnMvXChbXiwpXXsxLH1cKS8oSU5UMSkv
OwpzL1woW14sKV17MSx9LCBbXiwpXXsxLH1cKS8oSU5UMSwgSU5UMikvOwpzL1woW14sKV17
MSx9LCBbXiwpXXsxLH0sIFteLCldezEsfVwpLyhJTlQxLCBJTlQyLCBJTlQzKS87CnMvXChb
XiwpXXsxLH0sIFteLCldezEsfSwgW14sKV17MSx9LCBbXiwpXXsxLH1cKS8oSU5UMSwgSU5U
MiwgSU5UMywgSU5UNCkvOwpzL1woW14sKV17MSx9LCBbXiwpXXsxLH0sIFteLCldezEsfSwg
W14sKV17MSx9LCBbXiwpXXsxLH1cKS8oSU5UMSwgSU5UMiwgSU5UMywgSU5UNCwgSU5UNSkv
OwpzL1woW14sKV17MSx9LCBbXiwpXXsxLH0sIFteLCldezEsfSwgW14sKV17MSx9LCBbXiwp
XXsxLH0sIFteLCldezEsfVwpLyhJTlQxLCBJTlQyLCBJTlQzLCBJTlQ0LCBJTlQ1LCBJTlQ2
KS87CnMvXChbXiwpXXsxLH0sIFteLCldezEsfSwgW14sKV17MSx9LCBbXiwpXXsxLH0sIFte
LCldezEsfSwgW14sKV17MSx9LCBbXiwpXXsxLH1cKS8oSU5UMSwgSU5UMiwgSU5UMywgSU5U
NCwgSU5UNSwgSU5UNiwgSU5UNykvOwpzL1woW14sKV17MSx9LCBbXiwpXXsxLH0sIFteLCld
ezEsfSwgW14sKV17MSx9LCBbXiwpXXsxLH0sIFteLCldezEsfSwgW14sKV17MSx9LCBbXiwp
XXsxLH1cKS8oSU5UMSwgSU5UMiwgSU5UMywgSU5UNCwgSU5UNSwgSU5UNiwgSU5UNywgSU5U
OCkvOwpzLyQvIGRvIHt9IHdoaWxlICgwKS87CnByaW50OwpzL1woLiokL19FTkFCTEVEKCkg
KDApLzsKcHJpbnQ7Cg==

--------------Q088AlRpXuzlETDPQ8jl4Bgl--