Feedback-ID: id4a34324:Fastmail
Date: Sun, 5 Apr 2026 19:12:08 -0400
From: Andres Freund <andres@anarazel.de>
To: Lukas Fittl <lukas@fittl.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Zsolt Parragi <zsolt.parragi@percona.com>,
	Tomas Vondra <tomas@vondra.me>, Peter Smith <smithpb2250@gmail.com>
Subject: Re: Stack-based tracking of per-node WAL/buffer usage
Message-ID: <3xbje45m5knff52mye5dfnrjdnwv7it2bzmqac3jqe66fvop4a@xvhy6zx7n6sb>
References: 
 <CAP53PkznofNg+ii363QQGoje30nhssuSz_hV5U4YANAt-Yr_Yg@mail.gmail.com>
 <a1edb578-8a54-4f7a-ad74-11ce9cef291a@iki.fi>
 <CAP53PkwCk7X_ryOak_3x6ek2f+4kCgGjWe8aVy39D59Q8y9wTg@mail.gmail.com>
 <CAP53Pky2=31B1AS9vg=Ca9308_hb0H4g968cSKxiFgT0moJfYg@mail.gmail.com>
 <CAP53PkybGzJTAo7V07ssUae5047pBY3jc_F07tGY13cNhqe+AQ@mail.gmail.com>
 <57biou6l65r7gr4nunoe6lignz2x6m3w45gihoypaez4pc46di@txj3bakhj66l>
 <CAP53PkxDupm5U6TV0LF_YWHQ2wfcSiLsgnDBcO6b5AchLJhp=A@mail.gmail.com>
 <mtjyijvuv7xavvcdy3rosg43ycy3t5sluioxkef46se25ajtxp@e3e2xvesqhzu>
 <CAP53Pky4zHCueAyPkWE-cH6SqE_m+Kppmy=zE5K36X3HvCFZLw@mail.gmail.com>
 <pgvy7lsoa5jldwgyay2g757xivzbmgyan547wealc7cwtduvra@dysyw6dtqdgs>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <pgvy7lsoa5jldwgyay2g757xivzbmgyan547wealc7cwtduvra@dysyw6dtqdgs>
Archived-At: 
 <https://www.postgresql.org/message-id/3xbje45m5knff52mye5dfnrjdnwv7it2bzmqac3jqe66fvop4a%40xvhy6zx7n6sb>
Precedence: bulk

Hi,

On 2026-04-05 17:02:28 -0400, Andres Freund wrote:
> With that I pushed 0001.

For 0002 I:
- fixed a few comments still refering to node in the generic Instr* functions
- added comment about the async_mode buglet to the commit message
- added an async_mode argument to InstrInitNode(), as its callsite already
  needed to be touched, and it felt wrong that InstrAllocNode() could do
  things that were not possible with InstrInitNode()
- Deduplicated the code between InstrStop() and InstrStotNode() by introducing
  InstrStopCommon()

After those (and some testing) I pushed this.

Greetings,

Andres Freund