Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WfwTD-0002en-Ci for pgsql-hackers@arkaria.postgresql.org; Thu, 01 May 2014 19:16:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1WfwTC-0006zM-TO for pgsql-hackers@arkaria.postgresql.org; Thu, 01 May 2014 19:16:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WfwTC-0006zD-5l for pgsql-hackers@postgreSQL.org; Thu, 01 May 2014 19:16:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1WfwT8-0004bh-O1 for pgsql-hackers@postgreSQL.org; Thu, 01 May 2014 19:16:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id s41JGS7K004014; Thu, 1 May 2014 15:16:28 -0400 From: Tom Lane To: Noah Misch cc: pgsql-hackers@postgreSQL.org Subject: Re: Obsolete coding in fork_process.c In-reply-to: <20140501183231.GA1190179@tornado.leadboat.com> References: <30040.1398960808@sss.pgh.pa.us> <20140501183231.GA1190179@tornado.leadboat.com> Comments: In-reply-to Noah Misch message dated "Thu, 01 May 2014 14:32:31 -0400" Date: Thu, 01 May 2014 15:16:28 -0400 Message-ID: <4013.1398971788@sss.pgh.pa.us> X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Noah Misch writes: > On Thu, May 01, 2014 at 12:13:28PM -0400, Tom Lane wrote: >> Is there any reason not to change this to just fflush(NULL)? We dropped >> support for SunOS 4.1 quite some time ago ... > Modern systems have other fflush(NULL) problems: > http://www.nntp.perl.org/group/perl.perl5.porters/2013/09/msg207692.html > http://perl5.git.perl.org/metaconfig.git/blob/master:/U/perl/fflushall.U Fun. I doubt that the postmaster's stdin would ever be a pipe, but maybe we'd better leave well enough alone. Should update the comment though. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers