From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
cc: Euler Taveira <euler@eulerto.com>, Thomas Munro <thomas.munro@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        Euler Taveira <euler.taveira@2ndquadrant.com>,
        Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: cleanup temporary files after crash
In-reply-to: <19bc3276-6280-43bd-d868-ab3cb146266a@enterprisedb.com>
References: 
 <CAH503wDKdYzyq7U-QJqGn=Gm6XmoK+6_6xTJ-Yn5WSvoHLY1Ww@mail.gmail.com>
 <363cb85c-3a03-9a49-b830-8b645c1241d9@enterprisedb.com>
 <YEdqlL3Gr3rZ/aC8@paquier.xyz>
 <CA+hUKGJtZqpMZtYtJZ2cAGfQT5ELEZGKpnK_TjV-fNeB=rYSNw@mail.gmail.com>
 <4245d284-97b2-4056-96c2-455792d9b564@www.fastmail.com>
 <8740f056-a7c0-ff12-0a50-de5324a928ee@enterprisedb.com>
 <822e3a60-56a1-219d-c473-365751c3e108@enterprisedb.com>
 <a32a7f28-570c-24a2-aa2a-9f7c96abd88b@enterprisedb.com>
 <54663718-1d87-46f2-a27b-e7edacbfae0d@www.fastmail.com>
 <1ec33f3d-ea4c-28c8-502c-3eb0a008a6ac@enterprisedb.com>
 <34226249-c5ba-4780-a1bb-f3433d19716e@www.fastmail.com>
 <05d307fc-8391-4091-b279-1b3214658f10@www.fastmail.com>
 <049a2752-fc99-194d-31b2-b15ffa914cd4@enterprisedb.com>
 <a26a35c6-8816-4c2b-91b9-7a428e430a57@www.fastmail.com>
 <482a6498-7713-e937-c554-7d235c415fba@enterprisedb.com> <112f0847-a71!
 a-eec2-e561-2d39dc26127a@enterprisedb.com> <4028905.1616122655@sss.pgh.pa.us>
 <19bc3276-6280-43bd-d868-ab3cb146266a@enter!
 prisedb.com>
Comments: In-reply-to Tomas Vondra <tomas.vondra@enterprisedb.com>
	message dated "Fri, 19 Mar 2021 04:07:05 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4030088.1616124234.1@sss.pgh.pa.us>
Date: Thu, 18 Mar 2021 23:23:54 -0400
Message-ID: <4030089.1616124234@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4030089.1616124234%40sss.pgh.pa.us>
Precedence: bulk

[ reads code... ]
... no, I think the problem is the test is still full of race conditions.

In the first place, waiting till you see the output of a SELECT that's
before the useful query is not enough to guarantee that the useful query
is done, or even started.  That's broken on both sessions.

In the second place, even if the second INSERT has started, you don't know
that it's reached the point of blocking on the tuple conflict yet.
Which in turn means that it might not've filled its tuplestore yet.

In short, this script is designed to ensure that the test query can't
finish too soon, but that proves nothing about whether the test query
has even started.  And since you also haven't really guaranteed that the
intended-to-be-blocking query is done, I don't think that the first
condition really holds either.

			regards, tom lane