Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pUaQ4-0003uV-Vb
	for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Feb 2023 21:43:28 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pUaP5-0001MM-SR
	for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Feb 2023 21:42:27 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pUaP5-0001MC-J6
	for pgsql-hackers@lists.postgresql.org; Tue, 21 Feb 2023 21:42:27 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pUaP3-0002av-F4
	for pgsql-hackers@postgresql.org; Tue, 21 Feb 2023 21:42:27 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 31LLgNPV4032394;
	Tue, 21 Feb 2023 16:42:23 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump: Remove some dead code
In-reply-to: <144be239-c893-9361-704f-ac85b5b98d1a@enterprisedb.com>
References: <144be239-c893-9361-704f-ac85b5b98d1a@enterprisedb.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@enterprisedb.com>
	message dated "Tue, 21 Feb 2023 22:30:54 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4032392.1677015743.1@sss.pgh.pa.us>
Date: Tue, 21 Feb 2023 16:42:23 -0500
Message-ID: <4032393.1677015743@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/4032393.1677015743%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> I have found that the per-column atttypmod tracking in pg_dump isn't 
> actually used anywhere.  (The values are read but not used for writing 
> out any commands.)  This is because some time ago we started formatting 
> all types through format_type() on the server.  So this dead code can be 
> removed.

Good catch.  LGTM.

			regards, tom lane