Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oddpY-0005W2-Vm for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Sep 2022 20:38:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oddpX-00043b-Gl for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Sep 2022 20:38:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oddpX-00043S-7Q for pgsql-hackers@lists.postgresql.org; Wed, 28 Sep 2022 20:38:55 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oddpV-0002wM-7B for pgsql-hackers@postgresql.org; Wed, 28 Sep 2022 20:38:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28SKcp5d4036167; Wed, 28 Sep 2022 16:38:51 -0400 From: Tom Lane To: Kyotaro Horiguchi cc: bdrouvot@amazon.com, sawada.mshk@gmail.com, ashutosh.bapat.oss@gmail.com, pgsql-hackers@postgresql.org Subject: Re: more descriptive message for process termination due to max_slot_wal_keep_size In-reply-to: <4035599.1664397037@sss.pgh.pa.us> References: <03ee95c3-6496-90b7-5c8b-13fe69ee73dd@amazon.com> <20220907.112019.758274712731312487.horikyota.ntt@gmail.com> <95534909-b8a0-d447-b940-b91006397962@amazon.com> <20220908.134020.228552226800754222.horikyota.ntt@gmail.com> <4035599.1664397037@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Wed, 28 Sep 2022 16:30:37 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4036165.1664397531.1@sss.pgh.pa.us> Date: Wed, 28 Sep 2022 16:38:51 -0400 Message-ID: <4036166.1664397531@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk ... oh, one other point is that using %ld to print an int64 is entirely not portable, as indeed the cfbot is complaining about. I think our best practice on that is to put %lld in the format string and explicitly cast the corresponding argument to "long long". regards, tom lane