From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade generated files in subdir follow-up
In-reply-to: <181A6DA8-3B7F-4B71-82D5-363FF0146820@yesql.se>
References: <181A6DA8-3B7F-4B71-82D5-363FF0146820@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 31 Aug 2022 14:09:06 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4061926.1661954367.1@sss.pgh.pa.us>
Date: Wed, 31 Aug 2022 09:59:27 -0400
Message-ID: <4061927.1661954367@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4061927.1661954367%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> Commit 38bfae36526 moved the .txt files pg_upgrade generates to a separate
> subdir, but there are a few left which are written to cwd.  The thread
> resulting in that patch doesn't discuss these files specifically so it seems
> they are just an oversight. Unless I'm missing something.

> Should something the attached be applied to ensure all generated files are
> placed in the subdirectory?

It certainly looks inconsistent ATM.  I wondered if maybe the plan was to
put routine output into the log directory but problem-reporting files
into cwd --- but that isn't what's happening now.

As long as we report the path to where the file is, I don't see a reason
not to put problem-reporting files in the subdir too.

			regards, tom lane