Message-ID: <406ded23-6d09-4cd2-acd1-9eb24ac988c6@pgbackrest.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Fix logging for invalid recovery timeline
To: =?UTF-8?Q?Benoit_Lobr=C3=A9au?= <benoit.lobreau@dalibo.com>,
 Michael Paquier <michael@paquier.xyz>
Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: <d0b27c08-d30f-4a1d-990d-5c90ca0a650a@pgbackrest.org>
 <4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>
 <2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org>
 <Z7aJU2_ZAplbpTsL@paquier.xyz>
 <6273ef0b-033b-4ac7-ab05-71a04e7ac626@pgbackrest.org>
 <173a9a4a-bad3-4a42-91e1-637f70e9512f@dalibo.com>
 <5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org>
 <Z7vF1hyg5JOFTWst@paquier.xyz>
 <f0e04cf5-e7e3-4c16-9c7a-dc7a2aa2c069@dalibo.com>
 <26fd4e28-8b75-4e61-a3fd-aed3b7442606@pgbackrest.org>
 <Z7zzpAv-D1iWVQok@paquier.xyz>
 <e5666a9d-8bbe-4aaa-a4c0-87ab13595a29@dalibo.com>
Content-Language: en-US
From: David Steele <david@pgbackrest.org>
In-Reply-To: <e5666a9d-8bbe-4aaa-a4c0-87ab13595a29@dalibo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Date: Tue, 25 Feb 2025 16:25:40 +0000 (UTC)
Archived-At: 
 <https://www.postgresql.org/message-id/406ded23-6d09-4cd2-acd1-9eb24ac988c6%40pgbackrest.org>
Precedence: bulk

On 2/25/25 04:07, Benoit Lobréau wrote:
> On 2/24/25 11:33 PM, Michael Paquier wrote:
>> On Mon, Feb 24, 2025 at 05:30:35PM +0000, David Steele wrote:
>>> +                                /* translator: %s is a backup_label or
>>> pg_control file */
>>
>> See for example PostmasterMain() with the "/* translator: %s is a
>> configuration file */".
> 
> Thank you Michael and David.
> I never paid attention to thoses...

This looks good to me.

Regards,
-David