From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: macOS 15.4 versus strchrnul()
In-reply-to: <aee5f0db-a167-4b3c-869b-3a8213cb7857@eisentraut.org>
References: <385134.1743523038@sss.pgh.pa.us>
 <aee5f0db-a167-4b3c-869b-3a8213cb7857@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Tue, 01 Apr 2025 19:07:02 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <407463.1743535559.1@sss.pgh.pa.us>
Date: Tue, 01 Apr 2025 15:25:59 -0400
Message-ID: <407464.1743535559@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/407464.1743535559%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> On 01.04.25 17:57, Tom Lane wrote:
>> I speculate that the meson test for preadv/pwritev has never worked
>> for macOS either, and we haven't noticed because nobody has tried to
>> build with meson on a machine with low enough default deployment
>> target to not have preadv/pwritev.

> Agreed.  Attached is a patch that implements the test more along the 
> lines of how Autoconf does it.  This gives correct results for me for 
> strchrnul() in various configurations.

Cool.  Let me try it here, and I'll push if no problems arise.

> Btw., I see on the buildfarm that strchrnul() is also available on 
> FreeBSD, DragonFly BSD, NetBSD, and musl (Alpine Linux).  So perhaps 
> some of the comments ought to be rewritten away from that it's a 
> glibc-specific extension.

OK, will do something about that --- maybe like "originally glibc
specific, but later adopted by other platforms"?

			regards, tom lane