From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Christensen <david@pgguru.net>
cc: Andrey Borodin <x4mmm@yandex-team.ru>,
        Peter Eisentraut <peter@eisentraut.org>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        Jelte Fennema-Nio <postgres@jeltef.nl>
Subject: Re: [PATCH] GROUP BY ALL
In-reply-to: 
 <CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com>
References: <4D2047B0-E8D8-472B-B7E8-61206B1E6AFA@yandex-team.ru>
 <F694DABC-6A42-4614-B254-643180B9D6F6@pgguru.net>
 <CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com>
Comments: In-reply-to David Christensen <david@pgguru.net>
	message dated "Fri, 26 Sep 2025 10:45:53 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4083062.1758902694.1@sss.pgh.pa.us>
Date: Fri, 26 Sep 2025 12:04:54 -0400
Message-ID: <4083063.1758902694@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4083063.1758902694%40sss.pgh.pa.us>
Precedence: bulk

David Christensen <david@pgguru.net> writes:
> Here is a rebased version with a few more tests.  I also changed the
> main check here to using `!contain_agg_clause` instead of
> `!IsA(Aggref))` directly.  (This was defined in `optimizer/clauses.h`,
> but we already are pulling in `optimizer.h`, so it felt valid to me.)

contain_agg_clause will blow up on a SubLink, so I doubt this is
gonna be robust.

			regards, tom lane