Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uIs6X-00CnHM-O2 for pgsql-hackers@arkaria.postgresql.org; Sat, 24 May 2025 16:52:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uIs6W-00Ci1F-6E for pgsql-hackers@arkaria.postgresql.org; Sat, 24 May 2025 16:52:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uIs6V-00Ci17-Rf for pgsql-hackers@lists.postgresql.org; Sat, 24 May 2025 16:52:11 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uIs6Q-000ltn-2R for pgsql-hackers@lists.postgresql.org; Sat, 24 May 2025 16:52:08 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-60410a9c6dcso947824a12.1 for ; Sat, 24 May 2025 09:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748105526; x=1748710326; darn=lists.postgresql.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=hpNStLPNCgAp+KNMaIolkoArW2S8/M0ZbrFI6sctAyE=; b=KlfrfsYRYAN0zji7tl1TDJRDuMJjcfrnfZ+V0PaEYzk7/Vp+WRburQDGqFS/NlZKOd uTHRrfxivtOxZnfXVYL5ZKak5kGFFli5RyDiwbwSwDDZlsAHaer/+kV1EDThUqldmMEU 7HG40qI9cEBNZfYJ81InSSLcOhCNOTCJitcX80u8wy+dFcjl2fr9hji7mTkwesUKSWxr 4EA8Eh9xh8OtalrU180rKOv6fqQwEFaCb0TwaeGan9BMm3ag9n2dOIlzSdlcAhsfeP5X JpanTrQe/xeY7BzssqbapZZX0zLpbva3YtFuN8Lj2wSgvdkoLHLqcfnM1VT2UmVF/kx1 80QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748105526; x=1748710326; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hpNStLPNCgAp+KNMaIolkoArW2S8/M0ZbrFI6sctAyE=; b=r6gJAbEsyslOYtAvOmnBKG4GNbQxdx5uMU/0oSyknn+IB7joaffmrzN0MEdNHMaF4X EVwu1Kn3ffQGMSl64YGWTQjhIjjPmy8PwzhWs6rojbUnl/TbVyuTT0j9qxSXLkhPfDLM sX/V0cNwKac4GKKLvTUKPaG1AhhsjHpia5vMTVFIHIT+So+3+XHmpGP5IUINQ+SKhsnZ n9GEmj7Hdmg689X4DiQPkLrsAIh7l9bLHaeRM8nwUnyK694/Q/hnnsbaMS2EWiIop8Hi Hi/vi9m/p8MHdn8hNnwaCzVEiwzmN5Jfoveqr0NGN5Z5X7C2RQS1B8FzdF0MwRcBWph5 k8Nw== X-Forwarded-Encrypted: i=1; AJvYcCX/VtTVor5YT6ZQCL8L7LRG2/8fuy0yoEeXt44WtttLrDnFAeeSPzplQ6kLKomvnjJkw3rQeTx9hJVSmUsK@lists.postgresql.org X-Gm-Message-State: AOJu0YwkHqzZ/XZFa2gCvjrjaQJg+X+iioFl6oHLTEkc2Nsy5At/kTs6 qrozjuo6o/ADkBrTAkUtT6K7ZTy8K8TeLZpDMOSfC9NpC4zr6tkvCoMT X-Gm-Gg: ASbGncuk3E+eyDFjb2U8It66F6VCFNXUTtTpzD6lTCkafojp/zkaGeLvSia2lBUjxHe 03jJPJBSPvBTk2QsRlQ5IT2DKoh5P2e9zffySGy21/vxogmrpjDDh3C/RRLoeqJMEOufVS21/Rw 65tgniCcWVJiZvHeJodaGPA1uhELdiTlphOjYRWkYKg1IbCfuYFQzaH/zDb2jutW+UUHqCtgWox NfC61xT7vc1ajJxuG57bwodwIRQgyfSR14hEJd7uRUCUYsTTlW5zBfJUNTNgsvHI9wxUDqUmNY4 SsqEEwWDmSBSBbg5ItXoIBV/fC40S5RV5nD7MllPahBdOkmR9m0bJL2YjTN/22/IENkXDzpxMqv 9/cTJsbNX7+CSGRAvOx18THRO13jseGlpeDjG X-Google-Smtp-Source: AGHT+IEF72zEiBzLxq12DHchCN0W2AXo6rQQg+/yEMeE3e7//f1bKWSHf3ck+NZmcVgv3mQ8vpVtPg== X-Received: by 2002:a05:6402:1d4e:b0:5fd:2069:bbbb with SMTP id 4fb4d7f45d1cf-602d9df980cmr2671062a12.3.1748105525795; Sat, 24 May 2025 09:52:05 -0700 (PDT) Received: from smtpclient.apple (adsl-138.176.58.226.tellas.gr. [176.58.226.138]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6044e95c32dsm622666a12.44.2025.05.24.09.52.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 May 2025 09:52:04 -0700 (PDT) From: Florents Tselai Message-Id: <40912112-7FFE-400F-A38F-368827C4BDF1@gmail.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_031C04D3-625B-4987-AE78-AE4A916FB8BB" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part Date: Sat, 24 May 2025 19:51:32 +0300 In-Reply-To: Cc: Tom Lane , Peter Eisentraut , Robert Haas , Alexander Korotkov , pgsql-hackers , Andrew Dunstan To: "David E. Wheeler" References: <145894.1727298237@sss.pgh.pa.us> <7e9debe6-4e96-4b0d-a801-b531e962ef43@eisentraut.org> <01DC1C38-0692-461B-AA63-5394330356BE@gmail.com> <2568904.1748022721@sss.pgh.pa.us> X-Mailer: Apple Mail (2.3826.600.51.1.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail=_031C04D3-625B-4987-AE78-AE4A916FB8BB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 24 May 2025, at 7:08=E2=80=AFPM, David E. Wheeler = wrote: >=20 > On May 23, 2025, at 13:52, Tom Lane wrote: >=20 >>> I assume you mean that they=E2=80=99re set at initdb time, so = there=E2=80=99s no mutability concern? >>=20 >> Yeah, I think Peter's right and I'm wrong. Obviously this ties into >> our philosophical debate about how immutable is immutable. But as >> long as the functions only depend on locale settings that are fixed >> at database creation, I think it's okay to consider them immutable. >>=20 >> If you were, say, depending on LC_NUMERIC, it would clearly be unsafe >> to consider that immutable, so I'm not quite sure if this is the end >> of the discussion. But for what's mentioned in the thread title, >> I think we only care about LC_CTYPE. >=20 > Oh, so maybe all this is moot, and Florents can go ahead and add = support for the functions to the non-_tz functions? >=20 I think the patch is still in reasonably good shape and hasn=E2=80=99t = changed much since September 24. So yes, I=E2=80=99d hope there are still some valid points to consider = or improve. Otherwise, I=E2=80=99ll have only myself to blame for not pushing harder = before the feature freeze. =F0=9F=98=85= --Apple-Mail=_031C04D3-625B-4987-AE78-AE4A916FB8BB Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 24 May 2025, at 7:08=E2=80=AFPM, David E. Wheeler = <david@justatheory.com> wrote:

On May 23, 2025, at 13:52, = Tom Lane <tgl@sss.pgh.pa.us> wrote:

I assume you mean that they=E2=80=99= re set at initdb time, so there=E2=80=99s no mutability concern? =

Yeah, I think Peter's right and I'm wrong. =  Obviously this ties into
our philosophical debate about how = immutable is immutable.  But as
long as the functions only = depend on locale settings that are fixed
at database creation, I = think it's okay to consider them immutable.

If you were, say, = depending on LC_NUMERIC, it would clearly be unsafe
to consider that = immutable, so I'm not quite sure if this is the end
of the = discussion.  But for what's mentioned in the thread title,
I = think we only care about LC_CTYPE.

Oh, so maybe all = this is moot, and Florents can go ahead and add support for the = functions to the non-_tz = functions?


I think the = patch is still in reasonably good shape and hasn=E2=80=99t changed much = since September 24.
So yes, I=E2=80=99= d hope there are still some valid points to consider or = improve.
Otherwise, = I=E2=80=99ll have only myself to blame for not pushing harder before the = feature freeze. =F0=9F=98=85
= --Apple-Mail=_031C04D3-625B-4987-AE78-AE4A916FB8BB--