Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7gfC-0000b6-2d for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Feb 2021 15:35:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l7gfB-0003pp-0K for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Feb 2021 15:35:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7gfA-0003pi-Pw for pgsql-hackers@lists.postgresql.org; Thu, 04 Feb 2021 15:35:20 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7gf8-0005RL-Pm for pgsql-hackers@postgresql.org; Thu, 04 Feb 2021 15:35:19 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 114FZDlI4095953; Thu, 4 Feb 2021 10:35:13 -0500 From: Tom Lane To: Alvaro Herrera cc: Heikki Linnakangas , Michael Paquier , pgsql-hackers Subject: Re: Removing support for COPY FROM STDIN in protocol version 2 In-reply-to: <20210204152548.GA6658@alvherre.pgsql> References: <20210204152548.GA6658@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Thu, 04 Feb 2021 12:25:48 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4095951.1612452913.1@sss.pgh.pa.us> Date: Thu, 04 Feb 2021 10:35:13 -0500 Message-ID: <4095952.1612452913@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > Yeah, the changes I was thinking about are all in libpq-int.h so that's > not really a problem. But one enum in libpq-fe.h renumbers values, and > I think it's better to keep the old value labelled as "unused" to avoid > any changes. Oh, yeah, can't do that. libpq-fe.h probably shouldn't change at all; but certainly we can't renumber existing enum values there. regards, tom lane