Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qZTh3-005WYb-Jr
	for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Aug 2023 10:05:29 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qZTh1-001LKU-Np
	for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Aug 2023 10:05:27 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <vik@postgresfriends.org>)
	id 1qZTh1-001LK5-DR
	for pgsql-hackers@lists.postgresql.org; Fri, 25 Aug 2023 10:05:27 +0000
Received: from relay5-d.mail.gandi.net ([217.70.183.197])
	by magus.postgresql.org with esmtps  (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <vik@postgresfriends.org>)
	id 1qZTgs-000x1G-E3
	for pgsql-hackers@lists.postgresql.org; Fri, 25 Aug 2023 10:05:24 +0000
Received: by mail.gandi.net (Postfix) with ESMTPSA id CC0791C0009;
	Fri, 25 Aug 2023 10:05:15 +0000 (UTC)
Message-ID: <40b65c4b-bca6-5713-39df-6080b97891b1@postgresfriends.org>
Date: Fri, 25 Aug 2023 12:05:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] Add XMLText function (SQL/XML X038)
Content-Language: en-US
To: Jim Jones <jim.jones@uni-muenster.de>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <86617a66-ec95-581f-8d54-08059cca8885@uni-muenster.de>
From: Vik Fearing <vik@postgresfriends.org>
In-Reply-To: <86617a66-ec95-581f-8d54-08059cca8885@uni-muenster.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-GND-Sasl: vik@postgresfriends.org
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/40b65c4b-bca6-5713-39df-6080b97891b1%40postgresfriends.org>
Precedence: bulk

On 3/25/23 12:49, Jim Jones wrote:
> Hi,
> 
> This small patch proposes the implementation of the standard SQL/XML 
> function XMLText (X038). It basically converts a text parameter into an 
> xml text node. It uses the libxml2 function xmlEncodeSpecialChars[1] to 
> escape possible predefined entities.
> 
> This patch also contains documentation and regression tests.
> 
> Any thoughts?

I am replying to this email, but my comments are based on the v2 patch.

Thank you for working on this, and I think this is a valuable addition. 
However, I have two issues with it.

1) There seems to be several spurious blank lines added that I do not 
think are warranted.

2) This patch does nothing to address the <XML returning clause> so we 
can't claim to implement X038 without a disclaimer.  Upon further 
review, the same is true of XMLCOMMENT() so maybe that is okay for this 
patch, and a more comprehensive patch for our xml features is necessary.
-- 
Vik Fearing