Message-ID: <40fd0768-b389-a4de-efdf-207343aacc98@gmail.com>
Date: Mon, 11 Dec 2023 18:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: brininsert optimization opportunity
To: Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Ashwin Agrawal <ashwinstar@gmail.com>
References: <20230704112358.bkm6r3fxp275m4lu@alvherre.pgsql>
 <2b672382-c0b3-3f44-b72c-86b1077b082b@enterprisedb.com>
 <CAE-ML+_ecaX4jRQZaRdzdTk4zGPY5qUDB6Y3eV=KQu--k49yeQ@mail.gmail.com>
 <11f78627-a934-1f8b-084e-21ed95f2564c@enterprisedb.com>
 <CAE-ML+-9K2h2R7zcvQGq8FarxvSVhgAGZkgH57iQCnWQoxOFww@mail.gmail.com>
 <35e7be37-0d35-d8ea-a4d5-eff84aefcc39@enterprisedb.com>
 <CAE-ML+9JVD3vt7JZtmNy8hOFQKtP2jxJtf27=kE=ViGyv36V3w@mail.gmail.com>
 <CAE-ML+_jerNg64mSD5VYy=bOxcRQSr-QfESHvCVFPEwMM_jufQ@mail.gmail.com>
 <CAE-ML+-nBfDXQEfh0Ex0bp=tZdzzs7y5bvmQJg1WC7KpJSZVmQ@mail.gmail.com>
 <CAE-ML+_9Adp8rRfZ9FP4ODtQZLZcMaBvae5ACO9H+-FZdk_v9w@mail.gmail.com>
 <1d68ef1d-41c5-7159-c6c0-b44dad4e3148@enterprisedb.com>
 <CAEze2WhR0zkCTYrs1_-xJErcZkyKLnV-9=cKq43D6EURj6OSgQ@mail.gmail.com>
 <CAE-ML+_1nGVH7CitWieLZNR3W54V+RUGG8RQEon5EdEHucGEFw@mail.gmail.com>
 <12d42882-7860-9b46-7572-3b2fae6c916f@enterprisedb.com>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <12d42882-7860-9b46-7572-3b2fae6c916f@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/40fd0768-b389-a4de-efdf-207343aacc98%40gmail.com>
Precedence: bulk

Hello Tomas and Soumyadeep,

25.11.2023 23:06, Tomas Vondra wrote:
> I've done a bit more cleanup on the last version of the patch (renamed
> the fields to start with bis_ as agreed, rephrased the comments / docs /
> commit message a bit) and pushed.

Please look at a query, which produces warnings similar to the ones
observed upthread:
CREATE TABLE t(a INT);
INSERT INTO t SELECT x FROM generate_series(1,10000) x;
CREATE INDEX idx ON t USING brin (a);
REINDEX index CONCURRENTLY idx;

WARNING:  resource was not closed: [1863] (rel=base/16384/16389, blockNum=1, flags=0x93800000, refcount=1 1)
WARNING:  resource was not closed: [1862] (rel=base/16384/16389, blockNum=0, flags=0x93800000, refcount=1 1)

The first bad commit for this anomaly is c1ec02be1.

May be you would also want to fix in passing some typos/inconsistencies
introduced with recent brin-related commits:
s/bs_blkno/bt_blkno/
s/emptry/empty/
s/firt/first/
s/indexinsertcleanup/aminsertcleanup/
s/ maxRange/ nextRange/
s/paga /page /

Best regards,
Alexander