public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Julien Rouhaud <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add parameter jit_warn_above_fraction
Date: Sat, 09 Apr 2022 10:42:12 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <YlEJqTkG9rG7OcYs@jrouhaud>
References: <[email protected]>
<CABUevEy9H+HPAuM1ofC=OuY2+bESOsA4hHSAY6HbLYyTG1oaPw@mail.gmail.com>
<20220329100846.3iedk5ear3ewdi5j@jrouhaud>
<CA+TgmoZ-AoXM=J5J===maHDY9O+Mbz-=Sfz-A23ZbiJoMKe_Rg@mail.gmail.com>
<CAApHDvrEoQ5p61NjDCKVgEWaH0qm1KprYw2-7m8-6ZGGJ8A2Dw@mail.gmail.com>
<CABUevExkr8pajkKFD=OnTj3q0S0GZc-u6iqD6L0ZXjO8z3-1gQ@mail.gmail.com>
<CABUevEw+dC=6sieitWSqqEjz8OaACOihxpWempoLewdKGnnrig@mail.gmail.com>
<CAApHDvor25wyUUPm6vAZn8uDNaQ=15fDh+4XuBGo3-_QCmfZUg@mail.gmail.com>
<CABUevEwT+nMj+m+=z=wPyYzq3Mh9ohuqrWBjR7q9uZawBA6j3A@mail.gmail.com>
<[email protected]>
<YlEJqTkG9rG7OcYs@jrouhaud>
Julien Rouhaud <[email protected]> writes:
> On Fri, Apr 08, 2022 at 09:39:18AM -0400, Stephen Frost wrote:
>> Having this in pg_stat_statements is certainly helpful but having a
>> warning also is. I don't think we have to address this in only one way.
>> A lot faster to flip this guc and then look in the logs on a busy system
>> than to install pg_stat_statements, restart the cluster once you get
>> permission to do so, and then query it.
> +1, especially if you otherwise don't really need or want to have
> pg_stat_statements enabled, as it's far from being free. Sure you could enable
> it by default with pg_stat_statements.track = none, but that seems a lot more
> troublesome than just dynamically enabling a GUC, possibly for a short time
> and/or for a specific database/role.
The arguments against the GUC were not about whether it's convenient.
They were about whether the information it gives you is actually going
to be of any use.
Also, good luck with "looking in the logs", because by default
WARNING-level messages don't go to the postmaster log. If that's
the intended use-case then the message ought to appear at LOG
level (which'd also change the desirable name for the GUC).
regards, tom lane
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add parameter jit_warn_above_fraction
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox