Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qh5JJ-0017v6-9n for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Sep 2023 09:40:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qh5JI-00F8Zr-5I for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Sep 2023 09:40:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qh5Hn-00F5cV-RQ for pgsql-hackers@lists.postgresql.org; Fri, 15 Sep 2023 09:38:51 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qh5Hf-005CxO-EO for pgsql-hackers@lists.postgresql.org; Fri, 15 Sep 2023 09:38:50 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 7AD2F6084B for ; Fri, 15 Sep 2023 18:38:37 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_22a4aed5a0a6997a310e883d5beee631" Content-Transfer-Encoding: 7bit Date: Fri, 15 Sep 2023 18:38:37 +0900 From: bt23nguyent To: pgsql-hackers@lists.postgresql.org Subject: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set User-Agent: Roundcube Webmail/1.4.11 Message-ID: <4109578306242a7cd5661171647e11b2@oss.nttdata.com> X-Sender: bt23nguyent@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_22a4aed5a0a6997a310e883d5beee631 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, When archive_library is set to 'basic_archive' but basic_archive.archive_directory is not set, WAL archiving doesn't work and only the following warning message is logged. $ emacs $PGDATA/postgresql.conf archive_mode = on archive_library = 'basic_archive' $ bin/pg_ctl -D $PGDATA restart .... WARNING: archive_mode enabled, yet archiving is not configured The issue here is that this warning message doesn't suggest any hint regarding the cause of WAL archiving failure. In other words, I think that the log message in this case should report that WAL archiving failed because basic_archive.archive_directory is not set. Thus, I think it's worth implementing new patch that improves that warning message, and here is the patch for that. Best regards, Tung Nguyen --=_22a4aed5a0a6997a310e883d5beee631 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v1-0001-Improve-log-message-output-of-basic-archive.patch Content-Disposition: attachment; filename=v1-0001-Improve-log-message-output-of-basic-archive.patch; size=2934 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvYmFzaWNfYXJjaGl2ZS9iYXNpY19hcmNoaXZlLmMgYi9jb250 cmliL2Jhc2ljX2FyY2hpdmUvYmFzaWNfYXJjaGl2ZS5jCmluZGV4IDRkNzhjMzE4NTkuLmRlZGM1 M2MzNjcgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvYmFzaWNfYXJjaGl2ZS9iYXNpY19hcmNoaXZlLmMK KysrIGIvY29udHJpYi9iYXNpY19hcmNoaXZlL2Jhc2ljX2FyY2hpdmUuYwpAQCAtNDgsNyArNDgs NyBAQCB0eXBlZGVmIHN0cnVjdCBCYXNpY0FyY2hpdmVEYXRhCiBzdGF0aWMgY2hhciAqYXJjaGl2 ZV9kaXJlY3RvcnkgPSBOVUxMOwogCiBzdGF0aWMgdm9pZCBiYXNpY19hcmNoaXZlX3N0YXJ0dXAo QXJjaGl2ZU1vZHVsZVN0YXRlICpzdGF0ZSk7Ci1zdGF0aWMgYm9vbCBiYXNpY19hcmNoaXZlX2Nv bmZpZ3VyZWQoQXJjaGl2ZU1vZHVsZVN0YXRlICpzdGF0ZSk7CitzdGF0aWMgYm9vbCBiYXNpY19h cmNoaXZlX2NvbmZpZ3VyZWQoQXJjaGl2ZU1vZHVsZVN0YXRlICpzdGF0ZSwgY29uc3QgY2hhciAq KmVycm1zZyk7CiBzdGF0aWMgYm9vbCBiYXNpY19hcmNoaXZlX2ZpbGUoQXJjaGl2ZU1vZHVsZVN0 YXRlICpzdGF0ZSwgY29uc3QgY2hhciAqZmlsZSwgY29uc3QgY2hhciAqcGF0aCk7CiBzdGF0aWMg dm9pZCBiYXNpY19hcmNoaXZlX2ZpbGVfaW50ZXJuYWwoY29uc3QgY2hhciAqZmlsZSwgY29uc3Qg Y2hhciAqcGF0aCk7CiBzdGF0aWMgYm9vbCBjaGVja19hcmNoaXZlX2RpcmVjdG9yeShjaGFyICoq bmV3dmFsLCB2b2lkICoqZXh0cmEsIEd1Y1NvdXJjZSBzb3VyY2UpOwpAQCAtMTU5LDkgKzE1OSwx NSBAQCBjaGVja19hcmNoaXZlX2RpcmVjdG9yeShjaGFyICoqbmV3dmFsLCB2b2lkICoqZXh0cmEs IEd1Y1NvdXJjZSBzb3VyY2UpCiAgKiBDaGVja3MgdGhhdCBhcmNoaXZlX2RpcmVjdG9yeSBpcyBu b3QgYmxhbmsuCiAgKi8KIHN0YXRpYyBib29sCi1iYXNpY19hcmNoaXZlX2NvbmZpZ3VyZWQoQXJj aGl2ZU1vZHVsZVN0YXRlICpzdGF0ZSkKK2Jhc2ljX2FyY2hpdmVfY29uZmlndXJlZChBcmNoaXZl TW9kdWxlU3RhdGUgKnN0YXRlLCBjb25zdCBjaGFyICoqZXJybXNnKQogewotCXJldHVybiBhcmNo aXZlX2RpcmVjdG9yeSAhPSBOVUxMICYmIGFyY2hpdmVfZGlyZWN0b3J5WzBdICE9ICdcMCc7CisJ aWYgKGFyY2hpdmVfZGlyZWN0b3J5ID09IE5VTEwgfHwgYXJjaGl2ZV9kaXJlY3RvcnlbMF0gPT0g J1wwJykKKyAgICB7CisgICAgICAgICplcnJtc2cgPSAiV0FMIGFyY2hpdmluZyBmYWlsZWQgYmVj YXVzZSBiYXNpY19hcmNoaXZlLmFyY2hpdmVfZGlyZWN0b3J5IGlzIG5vdCBzZXQiOworICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgfQorICAgIGVsc2UKKyAgICAgICAgcmV0dXJuIHRydWU7CiB9 CiAKIC8qCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL3BnYXJjaC5jIGIvc3Jj L2JhY2tlbmQvcG9zdG1hc3Rlci9wZ2FyY2guYwppbmRleCA0NmFmMzQ5NTY0Li4xMDBlMzNmNDhk IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL3BnYXJjaC5jCisrKyBiL3NyYy9i YWNrZW5kL3Bvc3RtYXN0ZXIvcGdhcmNoLmMKQEAgLTkxLDYgKzkxLDcgQEAgdHlwZWRlZiBzdHJ1 Y3QgUGdBcmNoRGF0YQogfSBQZ0FyY2hEYXRhOwogCiBjaGFyCSAgICpYTG9nQXJjaGl2ZUxpYnJh cnkgPSAiIjsKK2NoYXIgICAgICAgKm1zZzsKIAogCiAvKiAtLS0tLS0tLS0tCkBAIC00MTAsMTAg KzQxMSwxMSBAQCBwZ2FyY2hfQXJjaGl2ZXJDb3B5TG9vcCh2b2lkKQogCiAJCQkvKiBjYW4ndCBk byBhbnl0aGluZyBpZiBub3QgY29uZmlndXJlZCAuLi4gKi8KIAkJCWlmIChBcmNoaXZlQ2FsbGJh Y2tzLT5jaGVja19jb25maWd1cmVkX2NiICE9IE5VTEwgJiYKLQkJCQkhQXJjaGl2ZUNhbGxiYWNr cy0+Y2hlY2tfY29uZmlndXJlZF9jYihhcmNoaXZlX21vZHVsZV9zdGF0ZSkpCisJCQkJIUFyY2hp dmVDYWxsYmFja3MtPmNoZWNrX2NvbmZpZ3VyZWRfY2IoYXJjaGl2ZV9tb2R1bGVfc3RhdGUsICZt c2cpKQogCQkJewogCQkJCWVyZXBvcnQoV0FSTklORywKLQkJCQkJCShlcnJtc2coImFyY2hpdmVf bW9kZSBlbmFibGVkLCB5ZXQgYXJjaGl2aW5nIGlzIG5vdCBjb25maWd1cmVkIikpKTsKKwkJCQkJ CShlcnJtc2coImFyY2hpdmVfbW9kZSBlbmFibGVkLCB5ZXQgYXJjaGl2aW5nIGlzIG5vdCBjb25m aWd1cmVkIikpLAorCQkJCQkJKG1zZyAhPSBOVUxMKSA/IGVycmhpbnQoIiVzIiwgbXNnKSA6IDAp OwogCQkJCXJldHVybjsKIAkJCX0KIApkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvYXJjaGl2ZS9h cmNoaXZlX21vZHVsZS5oIGIvc3JjL2luY2x1ZGUvYXJjaGl2ZS9hcmNoaXZlX21vZHVsZS5oCmlu ZGV4IDY3OWNlNWE2ZGIuLjdmN2ZiZWFlOGEgMTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL2FyY2hp dmUvYXJjaGl2ZV9tb2R1bGUuaAorKysgYi9zcmMvaW5jbHVkZS9hcmNoaXZlL2FyY2hpdmVfbW9k dWxlLmgKQEAgLTM2LDcgKzM2LDcgQEAgdHlwZWRlZiBzdHJ1Y3QgQXJjaGl2ZU1vZHVsZVN0YXRl CiAgKiBhcmNoaXZlIG1vZHVsZXMgZG9jdW1lbnRhdGlvbi4KICAqLwogdHlwZWRlZiB2b2lkICgq QXJjaGl2ZVN0YXJ0dXBDQikgKEFyY2hpdmVNb2R1bGVTdGF0ZSAqc3RhdGUpOwotdHlwZWRlZiBi b29sICgqQXJjaGl2ZUNoZWNrQ29uZmlndXJlZENCKSAoQXJjaGl2ZU1vZHVsZVN0YXRlICpzdGF0 ZSk7Cit0eXBlZGVmIGJvb2wgKCpBcmNoaXZlQ2hlY2tDb25maWd1cmVkQ0IpIChBcmNoaXZlTW9k dWxlU3RhdGUgKnN0YXRlLCBjb25zdCBjaGFyICoqZXJybXNnKTsKIHR5cGVkZWYgYm9vbCAoKkFy Y2hpdmVGaWxlQ0IpIChBcmNoaXZlTW9kdWxlU3RhdGUgKnN0YXRlLCBjb25zdCBjaGFyICpmaWxl LCBjb25zdCBjaGFyICpwYXRoKTsKIHR5cGVkZWYgdm9pZCAoKkFyY2hpdmVTaHV0ZG93bkNCKSAo QXJjaGl2ZU1vZHVsZVN0YXRlICpzdGF0ZSk7 --=_22a4aed5a0a6997a310e883d5beee631--