Message-ID: <4112581f-1d01-8a62-3030-22ca4fda2e63@enterprisedb.com>
Date: Wed, 30 Mar 2022 20:43:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: range_agg with multirange inputs
Content-Language: en-US
To: Paul Jungwirth <pj@illuminatedcomputing.com>,
 Chapman Flack <chap@anastigmatix.net>, pgsql-hackers@lists.postgresql.org
References: <007ef255-35ef-fd26-679c-f97e7a7f30c2@illuminatedcomputing.com>
 <007ef255-35ef-fd26-679c-f97e7a7f30c2@illuminatedcomputing.com>
 <164592443404.882.11296254043197567171.pgcf@coridan.postgresql.org>
 <6556b959-f839-aee2-4b4b-0b5107c0db11@illuminatedcomputing.com>
 <621E912C.3020307@anastigmatix.net>
 <42454377-d914-0e22-37da-1b63ce3b9f9d@illuminatedcomputing.com>
 <622A7690.4020800@anastigmatix.net>
 <71eabe81-3e69-0476-347a-c8342de5cd41@illuminatedcomputing.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <71eabe81-3e69-0476-347a-c8342de5cd41@illuminatedcomputing.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4112581f-1d01-8a62-3030-22ca4fda2e63%40enterprisedb.com>
Precedence: bulk

This patch has been committed.  I split it into a few pieces.

On 12.03.22 04:18, Paul Jungwirth wrote:
> On 3/10/22 14:07, Chapman Flack wrote:
>> When I apply this patch, I get a func.sgml with two entries for
>> range_intersect_agg(anymultirange).
> 
> Arg, fixed.
> 
>> In range_agg_transfn, you've changed the message in the "must be called
>> with a range or multirange"; that seems like another good candidate to
>> be an elog.
> 
> Agreed. Updated here.

I kept those messages as "range" or "multirange" separately, instead of 
"range or multirange".  This way, we don't have to update all the 
messages of this kind when a new function is added.  Since these are 
only internal messages anyway, I opted for higher maintainability.