Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tKjbT-00ATSn-JZ
	for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Dec 2024 19:39:35 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tKjbR-00B2Sq-2S
	for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Dec 2024 19:39:34 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tKjbQ-00B2Sc-Ou
	for pgsql-hackers@lists.postgresql.org; Mon, 09 Dec 2024 19:39:33 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tKjbP-001x7g-Is
	for pgsql-hackers@postgresql.org; Mon, 09 Dec 2024 19:39:32 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4B9JdUJ64113326;
	Mon, 9 Dec 2024 14:39:30 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: pgsql-hackers@postgresql.org
Subject: Re: unused-but-set-variable warning on REL_13_STABLE
In-reply-to: <Z1dCFnzrP24O8WNR@nathan>
References: <Z1dCFnzrP24O8WNR@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Mon, 09 Dec 2024 13:16:38 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4113324.1733773170.1@sss.pgh.pa.us>
Date: Mon, 09 Dec 2024 14:39:30 -0500
Message-ID: <4113325.1733773170@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/4113325.1733773170%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Adding PG_USED_FOR_ASSERTS_ONLY (as in the attached patch) seems sufficient
> to suppress this warning.  On newer versions, this variable is used for
> more than assertions, so the patch only needs to be applied to v13.  Since
> this is trivial, I plan to commit it shortly.

LGTM

			regards, tom lane