From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
        reid.thompson@crunchydata.com, Thomas Munro <thomas.munro@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Andres Freund <andres@anarazel.de>, Tristan Partin <tristan@neon.tech>
Subject: Re: Refactoring backend fork+exec code
In-reply-to: <47965166-073f-49c8-9e8d-fd6ba37c61fb@iki.fi>
References: <59527c9b-c3f7-4d0c-a3f1-00d0ed5cc186@iki.fi>
 <f3ecd4cb-85ee-4e54-8278-5fabfb3a4ed0@iki.fi>
 <20240122210740.7vq5fd4woixpwx3f@awork3.anarazel.de>
 <8171f1aa-496f-46a6-afc3-c46fe7a9b407@iki.fi>
 <20240123195009.44wtutga24p5sh3s@awork3.anarazel.de>
 <08eff756-beeb-4a11-9eb5-d45b6af38998@iki.fi>
 <5997ff317a5827496537580078bcd19f4441f8d2.camel@crunchydata.com>
 <606a62d6-321c-4967-92c1-2d4e20a2c136@iki.fi>
 <20240207182521.wyt5dmd75l4v27zk@awork3.anarazel.de>
 <2136fb4f-1630-43e9-9cf6-b32772b4b0a0@iki.fi>
 <20240214213711.2gjlezqll37mg7lg@awork3.anarazel.de>
 <CA+Tgmoa=m3qogg1QH8kbicTgCtipgK1hTUDWpHd5SBra7kV6Ew@mail.gmail.com>
 <8f695109-8341-4f7c-8b0d-3cadc7eddc9e@iki.fi>
 <0c247a78-9dac-4584-8e87-39f2b45bec68@iki.fi>
 <861f42c1-01c4-42e6-ab2f-d5743ff69607@iki.fi>
 <CZM6WDX5H4QI.NZG1YUCKWLA@neon.tech>
 <53a0a952-1b58-4346-941c-6b767108963a@iki.fi>
 <47965166-073f-49c8-9e8d-fd6ba37c61fb@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Mon, 18 Mar 2024 11:41:41 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4119679.1710913067.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 20 Mar 2024 01:37:47 -0400
Message-ID: <4119680.1710913067@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4119680.1710913067%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Committed, with some final cosmetic cleanups. Thanks everyone!

A couple of buildfarm animals don't like these tests:

	Assert(child_type >=3D 0 && child_type < lengthof(child_process_kinds));

for example

 ayu           | 2024-03-19 13:08:05 | launch_backend.c:211:39: warning: c=
omparison of constant 16 with expression of type 'BackendType' (aka 'enum =
BackendType') is always true [-Wtautological-constant-out-of-range-compare=
]
 ayu           | 2024-03-19 13:08:05 | launch_backend.c:233:39: warning: c=
omparison of constant 16 with expression of type 'BackendType' (aka 'enum =
BackendType') is always true [-Wtautological-constant-out-of-range-compare=
]

I'm not real sure why it's moaning about the "<" check but not the
">=3D 0" check, which ought to be equally tautological given the
assumption that the input is a valid member of the enum.  But
in any case, exactly how much value do these assertions carry?
If you're intent on keeping them, perhaps casting child_type to
int here would suppress the warnings.  But personally I think
I'd lose the Asserts.

			regards, tom lane