Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lXQS2-00080G-W5
	for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Apr 2021 15:32:10 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lXQS1-0000yy-S0
	for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Apr 2021 15:32:09 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lXQS1-0000yr-Kp
	for pgsql-hackers@lists.postgresql.org; Fri, 16 Apr 2021 15:32:09 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lXQRz-0000qk-Ir
	for pgsql-hackers@postgresql.org; Fri, 16 Apr 2021 15:32:09 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 13GFW1E44120955;
	Fri, 16 Apr 2021 11:32:02 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Subject: Re: wrong units in ExplainPropertyFloat
In-reply-to: <20210415163846.GA3315@telsasoft.com>
References: <20210415163846.GA3315@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Thu, 15 Apr 2021 11:38:46 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4120953.1618587121.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 16 Apr 2021 11:32:01 -0400
Message-ID: <4120954.1618587121@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/4120954.1618587121%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> Text mode uses appendStringInfo() for high density output, so this only =
affects
> non-text output, but it turns out that units aren't shown for nontext fo=
rmat
> anyway - this seems like a deficiency, but it means there's no visible b=
ug.

Yeah, I concur: these should say "ms", but it's only latent so it's
not surprising nobody's noticed.  Pushed.

			regards, tom lane